mirror of
git://sourceware.org/git/lvm2.git
synced 2025-01-03 05:18:29 +03:00
56c68b3476
Move checking the lvmetad state, and the possible rescan, out of lvmetad_send() to the start of the command. Previously, the token mismatch and rescan would occur within lvmetad_send() for some other request. Now, the token mismatch is detected earlier, so the rescan can be done before the main command is in progress. Rescanning deep within the processing of another command will disturb the lvmcache state of that other command. A rescan already exists at the start of the command for the case where foreign VGs are going to be read. This same rescan is now also performed when there is an lvmetad token mismatch (from a changed global_filter). The commands pvscan/vgscan/lvscan/vgimport are excluded from this preemptive checking/rescanning for lvmetad because they want to do rescanning themselves explicitly. If rescanning devices fails, then lvmetad has not been correctly repopulated and should not be used, so make the command revert to not using lvmetad.
91 lines
2.6 KiB
C
91 lines
2.6 KiB
C
/*
|
|
* Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved.
|
|
* Copyright (C) 2004-2009 Red Hat, Inc. All rights reserved.
|
|
*
|
|
* This file is part of LVM2.
|
|
*
|
|
* This copyrighted material is made available to anyone wishing to use,
|
|
* modify, copy, or redistribute it subject to the terms and conditions
|
|
* of the GNU Lesser General Public License v.2.1.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#include "tools.h"
|
|
|
|
static int vgscan_single(struct cmd_context *cmd, const char *vg_name,
|
|
struct volume_group *vg,
|
|
struct processing_handle *handle __attribute__((unused)))
|
|
{
|
|
log_print_unless_silent("Found %svolume group \"%s\" using metadata type %s",
|
|
vg_is_exported(vg) ? "exported " : "", vg_name,
|
|
vg->fid->fmt->name);
|
|
|
|
check_current_backup(vg);
|
|
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
int vgscan(struct cmd_context *cmd, int argc, char **argv)
|
|
{
|
|
int maxret, ret;
|
|
|
|
if (argc) {
|
|
log_error("Too many parameters on command line");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (arg_is_set(cmd, notifydbus_ARG)) {
|
|
if (!lvmnotify_is_supported()) {
|
|
log_error("Cannot notify dbus: lvm is not built with dbus support.");
|
|
return ECMD_FAILED;
|
|
}
|
|
if (!find_config_tree_bool(cmd, global_notify_dbus_CFG, NULL)) {
|
|
log_error("Cannot notify dbus: notify_dbus is disabled in lvm config.");
|
|
return ECMD_FAILED;
|
|
}
|
|
set_pv_notify(cmd);
|
|
set_vg_notify(cmd);
|
|
set_lv_notify(cmd);
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
if (!lock_vol(cmd, VG_GLOBAL, LCK_VG_WRITE, NULL)) {
|
|
log_error("Unable to obtain global lock.");
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (cmd->filter->wipe)
|
|
cmd->filter->wipe(cmd->filter);
|
|
lvmcache_destroy(cmd, 1, 0);
|
|
|
|
if (!lvmetad_used() && arg_is_set(cmd, cache_long_ARG))
|
|
log_verbose("Ignoring vgscan --cache command because lvmetad is not in use.");
|
|
|
|
if (lvmetad_used() && (arg_is_set(cmd, cache_long_ARG) || !lvmetad_token_matches(cmd))) {
|
|
if (lvmetad_used() && !lvmetad_pvscan_all_devs(cmd, NULL, arg_is_set(cmd, cache_long_ARG))) {
|
|
log_warn("WARNING: Not using lvmetad because cache update failed.");
|
|
lvmetad_set_active(cmd, 0);
|
|
}
|
|
}
|
|
|
|
if (!lvmetad_used())
|
|
log_print_unless_silent("Reading all physical volumes. This may take a while...");
|
|
else
|
|
log_print_unless_silent("Reading volume groups from cache.");
|
|
|
|
maxret = process_each_vg(cmd, argc, argv, NULL, 0, NULL,
|
|
&vgscan_single);
|
|
|
|
if (arg_count(cmd, mknodes_ARG)) {
|
|
ret = vgmknodes(cmd, argc, argv);
|
|
if (ret > maxret)
|
|
maxret = ret;
|
|
}
|
|
|
|
unlock_vg(cmd, VG_GLOBAL);
|
|
return maxret;
|
|
}
|