1
0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
lvm2/lib/metadata
David Teigland 6ab2a22fcf lvremove: fix failed remove of all LVs in shared VG
commit a125a3bb50 "lv_remove: reduce commits for removed LVs"
changed "lvremove <vgname>" from removing one LV at a time,
to removing all LVs in one vg write/commit.  It also changed
the behavior if some of the LVs could not be removed, from
removing those LVs that could be removed, to removing nothing
if any LV could not be removed.  This caused a regression in
shared VGs using sanlock, in which the on-disk lease was
removed for any LV that could be removed, even if the command
decided to remove nothing.  This would leave LVs without a
valid ondisk lease, and "lock failed: error -221" would be
returned for any command attempting to lock the LV.

Fix this by not freeing the on-disk leases until after the
command has decided to go ahead and remove everything, and
has written the VG metadata.

Before the fix:

node1: lvchange -ay vg/lv1
node2: lvchange -ay vg/lv2

node1: lvs
  lv1  test -wi-a----- 4.00m
  lv2  test -wi------- 4.00m
node2: lvs
  lv1  test -wi------- 4.00m
  lv2  test -wi-a----- 4.00m

node1: lvremove -y vg/lv1 vg/lv2
  LV locked by other host: vg/lv2

(lvremove removed neither of the LVs, but it freed
the lock for lv1, which could have been removed
except for the proper locking failure on lv2.)

node1: lvs
  lv1  test -wi------- 4.00m
  lv2  test -wi------- 4.00m

node1: lvremove -y vg/lv1
LV vg/lv1 lock failed: error -221

(The lock for lv1 is gone, so nothing can be done with it.)
2024-10-16 13:18:14 -05:00
..
cache_manip.c cleanup: typos in comments 2024-08-30 16:51:15 +02:00
integrity_manip.c cov: avoid expression overflow 2024-08-09 13:20:44 +02:00
lv_alloc.h build: Don't generate symlinks in include/ dir 2018-05-14 10:30:20 +01:00
lv_manip.c lvremove: fix failed remove of all LVs in shared VG 2024-10-16 13:18:14 -05:00
lv.c vg: remove unused hostnames hash table 2024-09-23 15:04:53 -05:00
lv.h lv: remove unused declaration 2024-01-10 14:02:22 +01:00
merge.c cleanup: typos in logging 2024-08-30 16:51:15 +02:00
metadata-exported.h cleanup: typos in comments 2024-08-30 16:51:15 +02:00
metadata.c cleanup: typos in comments 2024-08-30 16:51:15 +02:00
metadata.h cleanup: typos in comments 2024-08-30 16:51:15 +02:00
mirror.c cleanup: typos in comments 2024-08-30 16:51:15 +02:00
pool_manip.c cleanup: typos in comments 2024-08-30 16:51:15 +02:00
pv_alloc.h doc: change fsf address 2016-01-21 12:11:37 +01:00
pv_list.c devices: fix dev_name assumptions 2022-02-24 17:22:04 -06:00
pv_manip.c cov: remove unneeded includes 2021-07-28 00:49:28 +02:00
pv_map.c build: Don't generate symlinks in include/ dir 2018-05-14 10:30:20 +01:00
pv_map.h build: Don't generate symlinks in include/ dir 2018-05-14 10:30:20 +01:00
pv.c cov: clean up pvid and vgid usage 2021-08-16 11:31:15 -05:00
pv.h cov: clean up pvid and vgid usage 2021-08-16 11:31:15 -05:00
raid_manip.c cleanup: typos in comments 2024-08-30 16:51:15 +02:00
segtype.c segtype: add linear 2018-06-05 16:23:18 +02:00
segtype.h metadata: use lv_hash in segment-specific metadata parsing 2024-09-10 11:51:15 -05:00
snapshot_manip.c cleanup: typos in comments 2024-08-30 16:51:15 +02:00
takeover_matrix.h const: raid takover arrays 2024-05-04 01:01:57 +02:00
thin_manip.c cleanup: typos in comments 2024-08-30 16:51:15 +02:00
vdo_manip.c vdo: depcreate unused settings 2024-09-26 16:25:12 +02:00
vg.c lvremove: fix failed remove of all LVs in shared VG 2024-10-16 13:18:14 -05:00
vg.h lvremove: fix failed remove of all LVs in shared VG 2024-10-16 13:18:14 -05:00
writecache_manip.c cov: drop unused header inclusion 2024-08-09 13:20:44 +02:00