mirror of
git://sourceware.org/git/lvm2.git
synced 2024-12-21 13:34:40 +03:00
96b777167c
pvid and vgid are sometimes a null-terminated string, and other times a 'struct id', and the two types were often cast between each other. When a struct id was cast to a char pointer, the resulting string would not necessarily be null terminated. Casting a null-terminated string id to a struct id is fine, but is still avoided when possible. A struct id is: int8_t uuid[ID_LEN] A string id is: char pvid[ID_LEN + 1] A convention is introduced to help distinguish them: - variables and struct fields named "pvid" or "vgid" should be null-terminated strings. - variables and struct fields named "pv_id" or "vg_id" should be struct id's. - examples: char pvid[ID_LEN + 1]; char vgid[ID_LEN + 1]; struct id pv_id; struct id vg_id; Function names also attempt to follow this convention. Avoid casting between the two types as much as possible, with limited exceptions when known to be safe and clearly commented. Avoid using variations of strcpy and strcmp, and instead use memcpy/memcmp with ID_LEN (with similar limited exceptions possible.) |
||
|---|---|---|
| .. | ||
| cache_manip.c | ||
| integrity_manip.c | ||
| lv_alloc.h | ||
| lv_manip.c | ||
| lv.c | ||
| lv.h | ||
| merge.c | ||
| metadata-exported.h | ||
| metadata.c | ||
| metadata.h | ||
| mirror.c | ||
| pool_manip.c | ||
| pv_alloc.h | ||
| pv_list.c | ||
| pv_manip.c | ||
| pv_map.c | ||
| pv_map.h | ||
| pv.c | ||
| pv.h | ||
| raid_manip.c | ||
| segtype.c | ||
| segtype.h | ||
| snapshot_manip.c | ||
| takeover_matrix.h | ||
| thin_manip.c | ||
| vdo_manip.c | ||
| vg.c | ||
| vg.h | ||
| writecache_manip.c | ||