shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-30 17:18:21 +03:00
Code Releases Activity
LVM2 mirror repository https://sourceware.org/lvm2/
7,417 Commits 425 Branches 667 Tags 54 MiB
C 75.5%
Shell 18.7%
Python 2.9%
M4 1%
Makefile 0.8%
Other 1%
7e5e2dd4ee
Go to file
Peter Rajnoha 7e5e2dd4ee vgextend: do not allow PV with 0 MDAs to be added while already in a VG 
If extending a VG and including a PV with 0 MDAs that was already
a part of a VG, the vgextend allowed that PV to be added and we
ended up *with one PV in two VGs*!

The vgextend code used the 'pv_by_path' fn that returned a PV for
a given path. However, when the PV did not have any metadata areas,
the fn just returned a PV without any reference to existing VG.
Consequently, any checks for the existing VG failed.

[0] raw/~ # pvcreate --metadatacopies 0 /dev/sda
  Physical volume "/dev/sda" successfully created

[0] raw/~ # pvcreate --metadatacopies 1 /dev/sdb
  Physical volume "/dev/sdb" successfully created

[0] raw/~ # vgcreate vg1 /dev/sda /dev/sdb
  Volume group "vg1" successfully created

[0] raw/~ # pvcreate --metadatacopies 1 /dev/sdc
  Physical volume "/dev/sdc" successfully created

[0] raw/~ # vgcreate vg2 /dev/sdc
  Volume group "vg2" successfully created

Before this patch (incorrect):
[0] raw/~ # vgextend vg2 /dev/sda
  Volume group "vg2" successfully extended

With this patch (correct):
[0] raw/~ # vgextend vg2 /dev/sda
  Physical volume '/dev/sda' is already in volume group 'vg1'
  Unable to add physical volume '/dev/sda' to volume group 'vg2'.
2013-03-19 14:57:36 +01:00
autoconf Using Fedora 14's autoreconf. 2011-01-07 14:38:34 +00:00
daemons config: refer to config nodes using assigned IDs 2013-03-06 10:14:33 +01:00
doc config: use config checks and add support for creating trees from config definition (config_def_create_tree fn) 2013-03-06 10:46:35 +01:00
include config: add config_settings.h 2013-03-06 10:14:32 +01:00
lib vgextend: do not allow PV with 0 MDAs to be added while already in a VG 2013-03-19 14:57:36 +01:00
libdaemon locales: use higher prio LC_ALL variable 2013-01-22 11:25:02 +01:00
libdm RAID: Code changes missing from previous commit (bbc6378) 2013-03-06 10:17:11 -06:00
liblvm config: refer to config nodes using assigned IDs 2013-03-06 10:14:33 +01:00
man man: update pvcreate/pvs/vgconvert man page to cover embedding area support 2013-02-26 14:46:42 +01:00
old-tests Add .gitignore files for an in-source-tree build. 2012-06-08 16:26:21 +01:00
po INSTALL rules updates 2010-04-09 21:42:48 +00:00
python lvm2app: No special behavior for 0 for max_snap_size in lvm_lv_snapshot() 2012-12-17 14:14:38 -08:00
report-generators add copyright notices to new files 2010-07-28 12:20:38 +00:00
reports [REPORT-GENERATORS] cut down stylsheet.css to what we actually use 2010-07-21 10:00:38 +00:00
scripts headers: add headers for musl libc 2013-02-05 14:27:25 +01:00
test test: Fix the way in_sync calculates the sync field location 2013-03-06 11:12:09 -06:00
tools metadata: add 'allow_orphan' arg to find_pv_by_name fn 2013-03-19 14:57:31 +01:00
udev activation: fix autoactivation to not trigger on each PV change 2012-12-21 10:34:48 +01:00
unit-tests cleanup: replace memset with struct initilization 2012-06-22 13:23:03 +02:00
.gitignore gitignore: Ignore files ending in ~ 2012-06-11 16:13:02 +01:00
aclocal.m4 Add aclocal.m4 (for pkgconfig). 2011-01-07 16:27:05 +00:00
configure configure: autoreconf 2012-10-12 14:45:26 +02:00
configure.in scripts: introduce blkdeactivate 2012-10-12 14:44:24 +02:00
COPYING Outline docs 2001-12-31 16:12:40 +00:00
COPYING.LIB Fix inconsistent licence notices: executables are GPLv2; libraries LGPLv2.1. 2007-08-20 20:55:30 +00:00
INSTALL quick review of docs 2008-11-04 17:49:22 +00:00
make.tmpl.in configure: Respect pkg-config --cflags for udev. 2013-02-22 14:49:31 +01:00
Makefile.in Makefiles: fix distclean dir dependency 2012-10-15 14:15:59 +01:00
README Rename git report from LVM2.git to lvm2.git. 2012-06-08 17:41:43 +01:00
VERSION version: update 2012-10-22 14:16:06 +02:00
VERSION_DM version: update 2012-10-22 14:16:06 +02:00
WHATS_NEW thin: move update_pool_params 2013-03-13 15:13:54 +01:00
WHATS_NEW_DM dmsetup: fix 'splitname -o' to not fail if used without '-c' 2013-03-12 13:01:57 +01:00

README 

This tree contains the LVM2 and device-mapper tools and libraries.

For more information about LVM2 read the changelog in the WHATS_NEW file.
Installation instructions are in INSTALL.

There is no warranty - see COPYING and COPYING.LIB.

Tarballs are available from:
  ftp://sources.redhat.com/pub/lvm2/

The source code is stored in git:
  http://git.fedorahosted.org/git/lvm2.git
  git clone git://git.fedorahosted.org/git/lvm2.git

Mailing list for general discussion related to LVM2:
  linux-lvm@redhat.com
  Subscribe from https://www.redhat.com/mailman/listinfo/linux-lvm

Mailing lists for LVM2 development, patches and commits:
  lvm-devel@redhat.com
  Subscribe from https://www.redhat.com/mailman/listinfo/linux-lvm

  lvm2-commits@lists.fedorahosted.org (Read-only archive of commits)
  Subscribe from https://fedorahosted.org/mailman/listinfo/lvm2-commits

Mailing list for device-mapper development, including kernel patches
and multipath-tools:
  dm-devel@redhat.com
  Subscribe from https://www.redhat.com/mailman/listinfo/dm-devel

The source code repository used until 7th June 2012 is accessible here:
  http://sources.redhat.com/cgi-bin/cvsweb.cgi/LVM2/?cvsroot=lvm2.