Alasdair G Kergon 80900dcf76 metadata: Fix metadata repair when devs still missing. ...

_check_reappeared_pv() incorrectly clears the MISSING_PV flags of
PVs with unknown devices.
While one caller avoids passing such PVs into the function, the other
doesn't.  Move the check inside the function so it's not forgotten.

Without this patch, if the normal VG reading code tries to repair
inconsistent metadata while there is an unknown PV, it incorrectly
considers the missing PVs no longer to be missing and produces
incorrect 'pvs' output omitting the missing PV, for example.

Easy reproducer:
Create a VG with 3 PVs pv1, pv2, pv3.
Hide pv2.
Run vgreduce --removemissing.
Reinstate the hidden PV pv2 and at the same time hide a different PV
pv3.
Run 'pvs' - incorrect output.
Run 'pvs' again - correct output.

See https://bugzilla.redhat.com/1434054

2017-05-11 02:17:34 +01:00

..

cache_manip.c

cache: enable usage of --cachemetadataformat

2017-03-10 19:33:01 +01:00

lv_alloc.h

lvconvert: add infrastructure for RaidLV reshaping support

2017-02-24 05:20:58 +01:00

lv_manip.c

mirror/raid: display adjusted region size with units

2017-04-20 20:42:21 +02:00

lv.c

properties: only thin-pool provides discards

2017-03-17 14:22:33 +01:00

lv.h

lv: introduce lvseg_percent_with_info_and_seg_status

2016-05-27 15:47:24 +02:00

merge.c

cache: validation for cache_metadata_format

2017-03-10 19:33:01 +01:00

metadata-exported.h

pvresize: Prompt when non-default size supplied.

2017-04-27 02:36:34 +01:00

metadata.c

metadata: Fix metadata repair when devs still missing.

2017-05-11 02:17:34 +01:00

metadata.h

thin: enforce there is some free space in thin pool metadata

2016-09-19 14:00:56 +02:00

mirror.c

mirror/raid: display adjusted region size with units

2017-04-20 20:42:21 +02:00

pool_manip.c

cleanup: minor cosmetics

2017-03-10 19:33:01 +01:00

pv_alloc.h

doc: change fsf address

2016-01-21 12:11:37 +01:00

pv_manip.c

pvresize: Missing a message on error path.

2017-04-27 15:00:41 +01:00

pv_map.c

doc: change fsf address

2016-01-21 12:11:37 +01:00

pv_map.h

doc: change fsf address

2016-01-21 12:11:37 +01:00

pv.c

lvmcache: add optional dev arg to lvmcache_info_from_pvid

2016-06-07 15:15:47 -05:00

pv.h

pv: add is_used_pv fn

2016-02-15 12:44:46 +01:00

raid_manip.c

raid: handle insufficent PVs on takeover to/from raid4

2017-04-22 01:19:44 +02:00

replicator_manip.c

lvmetad: two phase vg_update

2016-06-28 02:30:31 +01:00

segtype.c

lvconvert: add infrastructure for RaidLV reshaping support

2017-02-24 05:20:58 +01:00

segtype.h

lvconvert: add segment type raid10_near

2017-04-12 01:28:22 +02:00

snapshot_manip.c

lvconvert: add infrastructure for RaidLV reshaping support

2017-02-24 05:20:58 +01:00

takeover_matrix.h

lvconvert: add infrastructure for RaidLV reshaping support

2017-02-24 05:20:58 +01:00

thin_manip.c

pre-release

2017-03-28 16:11:35 +01:00

vg.c

macros: Use is_power_of_2.

2016-06-30 17:59:44 +01:00

vg.h

lvmetad: two phase vg_update

2016-06-28 02:30:31 +01:00