1
0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
LVM2 mirror repository https://sourceware.org/lvm2/
Go to file
Jonathan Brassow 82228acfc9 Mirror/Thin: Disallow thinpools on mirror logical volumes
The same corner cases that exist for snapshots on mirrors exist for
any logical volume layered on top of mirror.  (One example is when
a mirror image fails and a non-repair LVM command is the first to
detect it via label reading.  In this case, the LVM command will hang
and prevent the necessary LVM repair command from running.)  When
a better alternative exists, it makes no sense to allow a new target
to stack on mirrors as a new feature.  Since, RAID is now capable of
running EX in a cluster and thin is not active-active aware, it makes
sense to pair these two rather than mirror+thinpool.

As further background, here are some additional comments that I made
when addressing a bug related to mirror+thinpool:
(https://bugzilla.redhat.com/show_bug.cgi?id=919604#c9)
I am going to disallow thin* on top of mirror logical volumes.
Users will have to use the "raid1" segment type if they want this.

This bug has come down to a choice between:
1) Disallowing thin-LVs from being used as PVs.
2) Disallowing thinpools on top of mirrors.

The problem is that the code in dev_manager.c:device_is_usable() is unable
to tell whether there is a mirror device lower in the stack from the device
being checked.  Pretty much anything layered on top of a mirror will suffer
from this problem.  (Snapshots are a good example of this; and option #1
above has been chosen to deal with them.  This can also be seen in
dev_manager.c:device_is_usable().)  When a mirror failure occurs, the
kernel blocks all I/O to it.  If there is an LVM command that comes along
to do the repair (or a different operation that requires label reading), it
would normally avoid the mirror when it sees that it is blocked.  However,
if there is a snapshot or a thin-LV that is on a mirror, the above code
will not detect the mirror underneath and will issue label reading I/O.
This causes the command to hang.

Choosing #1 would mean that thin-LVs could never be used as PVs - even if
they are stacked on something other than mirrors.

Choosing #2 means that thinpools can never be placed on mirrors.  This is
probably better than we think, since it is preferred that people use the
"raid1" segment type in the first place.  However, RAID* cannot currently
be used in a cluster volume group - even in EX-only mode.  Thus, a complete
solution for option #2 must include the ability to activate RAID logical
volumes (and perform RAID operations) in a cluster volume group.  I've
already begun working on this.
2013-09-11 15:58:44 -05:00
autoconf Using Fedora 14's autoreconf. 2011-01-07 14:38:34 +00:00
conf conf: more comments about use_lvmetad + autoactivation relation 2013-08-22 08:29:20 +02:00
daemons cmirrord: Prevent secondary checkpoints from corrupting bitmaps 2013-08-20 13:21:09 -05:00
doc conf: add separate 'conf' dir for config files 2013-07-02 15:22:11 +02:00
include filters: check for mpath before opening devs 2013-08-13 23:26:58 +01:00
lib RAID: Make RAID single-machine-exclusive capable in a cluster 2013-09-10 16:33:22 -05:00
libdaemon cleanup: easier to read loop code 2013-06-18 22:13:41 +02:00
libdm Misc/RAID: Enable resume_lv to handle some renaming conflicts. 2013-09-09 15:07:28 -05:00
liblvm lvm2app: lvm_list_pvs_free seg. fault when no PVs 2013-08-14 15:17:39 -05:00
man tools: add -b/--background for pvscan --cache -aay 2013-09-03 16:49:21 +02:00
old-tests Add .gitignore files for an in-source-tree build. 2012-06-08 16:26:21 +01:00
po INSTALL rules updates 2010-04-09 21:42:48 +00:00
python python-lvm: Correct parsing arguments for integers 2013-07-26 10:24:01 -05:00
report-generators add copyright notices to new files 2010-07-28 12:20:38 +00:00
reports [REPORT-GENERATORS] cut down stylsheet.css to what we actually use 2010-07-21 10:00:38 +00:00
scripts systemd: lvm2-activation-generator: remove default dir if args not specified and require all args to be given 2013-08-28 16:06:51 +02:00
test Mirror/Thin: Disallow thinpools on mirror logical volumes 2013-09-11 15:58:44 -05:00
tools Mirror/Thin: Disallow thinpools on mirror logical volumes 2013-09-11 15:58:44 -05:00
udev udev: override new udev default timeout of 30s to original 3min 2013-09-11 12:47:38 +02:00
unit-tests cleanup: replace memset with struct initilization 2012-06-22 13:23:03 +02:00
.gitignore gitignore: Ignore files ending in ~ 2012-06-11 16:13:02 +01:00
aclocal.m4 Add aclocal.m4 (for pkgconfig). 2011-01-07 16:27:05 +00:00
configure configure: autoreconf 2013-07-31 15:59:05 +02:00
configure.in thin: add thin_repair and thin_dump options 2013-07-31 15:30:47 +02:00
COPYING Outline docs 2001-12-31 16:12:40 +00:00
COPYING.LIB Fix inconsistent licence notices: executables are GPLv2; libraries LGPLv2.1. 2007-08-20 20:55:30 +00:00
INSTALL quick review of docs 2008-11-04 17:49:22 +00:00
make.tmpl.in cleanup: comments and a message 2013-07-24 22:10:37 +01:00
Makefile.in test: Add a new "check_full" target, which also tests with real /dev. 2013-08-28 14:53:23 +02:00
README Rename git report from LVM2.git to lvm2.git. 2012-06-08 17:41:43 +01:00
VERSION post-release 2013-08-13 11:54:48 +01:00
VERSION_DM post-release 2013-08-13 11:54:48 +01:00
WHATS_NEW Mirror/Thin: Disallow thinpools on mirror logical volumes 2013-09-11 15:58:44 -05:00
WHATS_NEW_DM libdm: new name can't be empty 2013-08-31 21:40:28 +02:00

This tree contains the LVM2 and device-mapper tools and libraries.

For more information about LVM2 read the changelog in the WHATS_NEW file.
Installation instructions are in INSTALL.

There is no warranty - see COPYING and COPYING.LIB.

Tarballs are available from:
  ftp://sources.redhat.com/pub/lvm2/

The source code is stored in git:
  http://git.fedorahosted.org/git/lvm2.git
  git clone git://git.fedorahosted.org/git/lvm2.git

Mailing list for general discussion related to LVM2:
  linux-lvm@redhat.com
  Subscribe from https://www.redhat.com/mailman/listinfo/linux-lvm

Mailing lists for LVM2 development, patches and commits:
  lvm-devel@redhat.com
  Subscribe from https://www.redhat.com/mailman/listinfo/linux-lvm

  lvm2-commits@lists.fedorahosted.org (Read-only archive of commits)
  Subscribe from https://fedorahosted.org/mailman/listinfo/lvm2-commits

Mailing list for device-mapper development, including kernel patches
and multipath-tools:
  dm-devel@redhat.com
  Subscribe from https://www.redhat.com/mailman/listinfo/dm-devel

The source code repository used until 7th June 2012 is accessible here:
  http://sources.redhat.com/cgi-bin/cvsweb.cgi/LVM2/?cvsroot=lvm2.