mirror of
git://sourceware.org/git/lvm2.git
synced 2024-10-27 18:55:19 +03:00
90b96af68f
When using vgmetadatacopies value other than "umanaged" (0), prompt the user if the usage of --metadataignore would change the value of vgmetadatacopies. The main 2 cases are: 1) pvchange --metadataignore 2) vgextend --metadataignore We leave the prompt check in the tools, and do not change anything if the user says 'n'. Examples: vgextend --metadataignore y vgtest /dev/loop0 Setting metadataignore will override preferred number of copies of VG vgtest metadata. Are you sure? [y/n]: y No physical volume label read from /dev/loop0 Physical volume "/dev/loop0" successfully created Volume group "vgtest" successfully extended pvchange --metadataignore y /dev/loop3 Setting metadataignore on /dev/loop3 will override preferred number of copies of VG vgtest metadata. Are you sure? [y/n]: y WARNING: Changing preferred number of copies of VG vgtest metadata from 3 to 2 Physical volume "/dev/loop3" changed 1 physical volume changed / 0 physical volumes not changed Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
102 lines
2.7 KiB
C
102 lines
2.7 KiB
C
/*
|
|
* Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved.
|
|
* Copyright (C) 2004-2009 Red Hat, Inc. All rights reserved.
|
|
*
|
|
* This file is part of LVM2.
|
|
*
|
|
* This copyrighted material is made available to anyone wishing to use,
|
|
* modify, copy, or redistribute it subject to the terms and conditions
|
|
* of the GNU Lesser General Public License v.2.1.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include "tools.h"
|
|
|
|
int vgextend(struct cmd_context *cmd, int argc, char **argv)
|
|
{
|
|
char *vg_name;
|
|
struct volume_group *vg = NULL;
|
|
int r = ECMD_FAILED;
|
|
struct pvcreate_params pp;
|
|
|
|
if (!argc) {
|
|
log_error("Please enter volume group name and "
|
|
"physical volume(s)");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
vg_name = skip_dev_dir(cmd, argv[0], NULL);
|
|
argc--;
|
|
argv++;
|
|
|
|
if (arg_count(cmd, metadatacopies_ARG)) {
|
|
log_error("Invalid option --metadatacopies, "
|
|
"use --pvmetadatacopies instead.");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
pvcreate_params_set_defaults(&pp);
|
|
if (!pvcreate_params_validate(cmd, argc, argv, &pp)) {
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
log_verbose("Checking for volume group \"%s\"", vg_name);
|
|
vg = vg_read_for_update(cmd, vg_name, NULL, 0);
|
|
if (vg_read_error(vg)) {
|
|
vg_release(vg);
|
|
stack;
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!lock_vol(cmd, VG_ORPHANS, LCK_VG_WRITE)) {
|
|
log_error("Can't get lock for orphan PVs");
|
|
unlock_and_release_vg(cmd, vg, vg_name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!archive(vg))
|
|
goto_bad;
|
|
|
|
if (arg_count(cmd, metadataignore_ARG) &&
|
|
(vg_mda_copies(vg) != VGMETADATACOPIES_UNMANAGED) &&
|
|
yes_no_prompt("Setting metadataignore will override "
|
|
"preferred number of copies of VG %s "
|
|
"metadata.\nAre you sure? [y/n]: ",
|
|
vg_name) == 'n') {
|
|
log_error("Volume group %s not changed", vg_name);
|
|
goto_bad;
|
|
}
|
|
|
|
/* extend vg */
|
|
if (!vg_extend(vg, argc, argv, &pp))
|
|
goto_bad;
|
|
|
|
if (arg_count(cmd, metadataignore_ARG) &&
|
|
(vg_mda_copies(vg) != VGMETADATACOPIES_UNMANAGED) &&
|
|
(vg_mda_copies(vg) != vg_mda_used_count(vg))) {
|
|
log_warn("WARNING: Changing preferred number of copies of VG %s "
|
|
"metadata from %"PRIu32" to %"PRIu32, vg_name,
|
|
vg_mda_copies(vg), vg_mda_used_count(vg));
|
|
vg_set_mda_copies(vg, vg_mda_used_count(vg));
|
|
}
|
|
|
|
/* ret > 0 */
|
|
log_verbose("Volume group \"%s\" will be extended by %d new "
|
|
"physical volumes", vg_name, argc);
|
|
|
|
/* store vg on disk(s) */
|
|
if (!vg_write(vg) || !vg_commit(vg))
|
|
goto_bad;
|
|
|
|
backup(vg);
|
|
log_print("Volume group \"%s\" successfully extended", vg_name);
|
|
r = ECMD_PROCESSED;
|
|
|
|
bad:
|
|
unlock_vg(cmd, VG_ORPHANS);
|
|
unlock_and_release_vg(cmd, vg, vg_name);
|
|
return r;
|
|
}
|