mirror of
git://sourceware.org/git/lvm2.git
synced 2024-12-22 17:35:59 +03:00
d50795ed09
Split vg_remove_single into vg_remove_check (mandatory checks before vgremove) and vg_remove (do actual remove by committing to disk). In liblvm, we'd like to provide an consistent API that allows multiple changes in memory, then let lvm_vg_write() control the commit to disk. In some cases (for example, lvresize calls fsadm) this may not be possible. However, since we are using an object model and dividing things into small operations, the most logical model seems to be the lvm_vg_write model, and handling the special cases as they arrive. So as best as possible we move towards this end. A possible optimization would be to consolidate vg_remove (committing) code with vgreduce code. A second possible optimization is making vgreduce of the last device equivalent to vgremove. Today, lvm_vg_reduce fails if vgreduce is called with the last device, but from an object model perspective we could view this as equivalent to vgremove and allow it. My gut feel is we do not want to do this though. Author: Dave Wysochanski <dwysocha@redhat.com>
71 lines
1.7 KiB
C
71 lines
1.7 KiB
C
/*
|
|
* Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved.
|
|
* Copyright (C) 2004-2009 Red Hat, Inc. All rights reserved.
|
|
*
|
|
* This file is part of LVM2.
|
|
*
|
|
* This copyrighted material is made available to anyone wishing to use,
|
|
* modify, copy, or redistribute it subject to the terms and conditions
|
|
* of the GNU Lesser General Public License v.2.1.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include "tools.h"
|
|
|
|
static int vgremove_single(struct cmd_context *cmd, const char *vg_name,
|
|
struct volume_group *vg,
|
|
void *handle __attribute((unused)))
|
|
{
|
|
unsigned lv_count;
|
|
force_t force;
|
|
|
|
if (vg_read_error(vg))
|
|
return ECMD_FAILED;
|
|
|
|
if (!vg_check_status(vg, EXPORTED_VG))
|
|
return ECMD_FAILED;
|
|
|
|
lv_count = vg_visible_lvs(vg);
|
|
|
|
force = arg_count(cmd, force_ARG);
|
|
if (lv_count) {
|
|
if ((force == PROMPT) &&
|
|
(yes_no_prompt("Do you really want to remove volume "
|
|
"group \"%s\" containing %u "
|
|
"logical volumes? [y/n]: ",
|
|
vg_name, lv_count) == 'n')) {
|
|
log_print("Volume group \"%s\" not removed", vg_name);
|
|
return ECMD_FAILED;
|
|
}
|
|
if (!remove_lvs_in_vg(cmd, vg, force))
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!vg_remove_check(vg))
|
|
return ECMD_FAILED;
|
|
|
|
if (!vg_remove(vg))
|
|
return ECMD_FAILED;
|
|
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
int vgremove(struct cmd_context *cmd, int argc, char **argv)
|
|
{
|
|
int ret;
|
|
|
|
if (!argc) {
|
|
log_error("Please enter one or more volume group paths");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
ret = process_each_vg(cmd, argc, argv,
|
|
READ_FOR_UPDATE,
|
|
NULL, &vgremove_single);
|
|
|
|
return ret;
|
|
}
|