mirror of
git://sourceware.org/git/lvm2.git
synced 2025-03-11 20:58:50 +03:00
bc29785d09
There are two known bugs in the lvconvert-raid-status-validation.sh test. The first one I consider to be more of an annoyance (1507719). The second one I consider to be more serious (1507729). RHBZ 1507719 simply documents the fact that the three RAID status fields may not always be coherent due to the way they are set and unset when the MD thread is shutting down and starting up. For example, the sync ratio may be 100% but the sync action may not yet have switched to "idle" and the health characters may not yet all be 'A's (i.e. the devices set to InSync). RHBZ 1507729 is more serious. The sync ratio can be 100% for a short period of time after upconverting linear -> RAID1. It is reset to 0 once the MD sync thread gets to work on it. It does this because, technically, the array /is/ in-sync if the new devices are excluded - i.e. the data is 100% available and consistent. I'm not sure what to do about this problem, but we'd much rather not have this state that looks exactly like the end of the process when the sync ratio is 100% because the "recover" process finished, but the sync action and health characters haven't been updated yet. Put simply, the problem is that we can't tell if a sync is starting or finished based on the status output.
159 lines
5.2 KiB
Bash
159 lines
5.2 KiB
Bash
#!/usr/bin/env bash
|
|
|
|
# Copyright (C) 2017 Red Hat, Inc. All rights reserved.
|
|
#
|
|
# This copyrighted material is made available to anyone wishing to use,
|
|
# modify, copy, or redistribute it subject to the terms and conditions
|
|
# of the GNU General Public License v.2.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software Foundation,
|
|
# Inc., 51 Franklin Street, Fifth Floor, Boston, MA2110-1301 USA
|
|
|
|
#######################################################################
|
|
# This series of tests is meant to validate the correctness of
|
|
# 'dmsetup status' for RAID LVs - especially during various sync action
|
|
# transitions, like: recover, resync, check, repair, idle, reshape, etc
|
|
#######################################################################
|
|
SKIP_WITH_LVMLOCKD=1
|
|
SKIP_WITH_LVMPOLLD=1
|
|
|
|
export LVM_TEST_LVMETAD_DEBUG_OPTS=${LVM_TEST_LVMETAD_DEBUG_OPTS-}
|
|
|
|
. lib/inittest
|
|
|
|
# check for version 1.9.0
|
|
# - it is the point at which linear->raid1 uses "recover"
|
|
# check for version 1.13.0 instead
|
|
# - it is the point at which a finishing "recover" doesn't print all 'a's
|
|
aux have_raid 1 13 0 || skip
|
|
|
|
|
|
|
|
aux prepare_pvs 9
|
|
get_devs
|
|
|
|
vgcreate -s 2m "$vg" "${DEVICES[@]}"
|
|
|
|
###########################################
|
|
# Upconverted RAID1 should never have all 'a's in status output
|
|
###########################################
|
|
aux delay_dev "$dev2" 0 50
|
|
lvcreate -aey -l 2 -n $lv1 $vg "$dev1"
|
|
lvconvert --type raid1 -y -m 1 $vg/$lv1 "$dev2"
|
|
while ! check in_sync $vg $lv1; do
|
|
a=( $(dmsetup status $vg-$lv1) ) || die "Unable to get status of $vg/$lv1"
|
|
b=( $(echo "${a[6]}" | sed s:/:' ':) )
|
|
if [ "${b[0]}" -ne "${b[1]}" ]; then
|
|
# First, 'check in_sync' should only need to check the ratio
|
|
# If we are here, it is probably doing more than that.
|
|
# If not in-sync, then we should only ever see "Aa"
|
|
[ "${a[5]}" == "Aa" ]
|
|
else
|
|
[ "${a[5]}" != "aa" ]
|
|
should [ "${a[5]}" == "AA" ] # RHBZ 1507719
|
|
fi
|
|
sleep .1
|
|
done
|
|
aux enable_dev "$dev2"
|
|
lvremove -ff $vg
|
|
|
|
###########################################
|
|
# Upconverted RAID1 should not be at 100% right after upconvert
|
|
###########################################
|
|
aux delay_dev "$dev2" 0 50
|
|
lvcreate -aey -l 2 -n $lv1 $vg "$dev1"
|
|
lvconvert --type raid1 -y -m 1 $vg/$lv1 "$dev2"
|
|
a=( $(dmsetup status $vg-$lv1) ) || die "Unable to get status of $vg/$lv1"
|
|
b=( $(echo "${a[6]}" | sed s:/:' ':) )
|
|
should [ "${b[0]}" -ne "${b[1]}" ] # RHBZ 1507729
|
|
aux enable_dev "$dev2"
|
|
lvremove -ff $vg
|
|
|
|
###########################################
|
|
# Catch anything suspicious with linear -> RAID1 upconvert
|
|
###########################################
|
|
aux delay_dev "$dev2" 0 50
|
|
lvcreate -aey -l 2 -n $lv1 $vg "$dev1"
|
|
lvconvert --type raid1 -y -m 1 $vg/$lv1 "$dev2"
|
|
while true; do
|
|
a=( $(dmsetup status $vg-$lv1) ) || die "Unable to get status of $vg/$lv1"
|
|
b=( $(echo "${a[6]}" | sed s:/:' ':) )
|
|
if [ "${b[0]}" -ne "${b[1]}" ]; then
|
|
# If the sync operation ("recover" in this case) is not
|
|
# finished, then it better be as follows:
|
|
[ "${a[5]}" = "Aa" ]
|
|
[ "${a[7]}" = "recover" ]
|
|
else
|
|
# Tough to tell the INVALID case,
|
|
# Before starting sync thread: "Aa X/X recover"
|
|
# from the valid case,
|
|
# Just finished sync thread: "Aa X/X recover"
|
|
should [ "${a[5]}" = "AA" ] # RHBZ 1507719
|
|
should [ "${a[7]}" = "idle" ] # RHBZ 1507719
|
|
break
|
|
fi
|
|
sleep .1
|
|
done
|
|
aux enable_dev "$dev2"
|
|
lvremove -ff $vg
|
|
|
|
###########################################
|
|
# Catch anything suspicious with RAID1 2-way -> 3-way upconvert
|
|
###########################################
|
|
aux delay_dev "$dev3" 0 50
|
|
lvcreate --type raid1 -m 1 -aey -l 2 -n $lv1 $vg "$dev1" "$dev2"
|
|
aux wait_for_sync $vg $lv1
|
|
lvconvert -y -m +1 $vg/$lv1 "$dev3"
|
|
while true; do
|
|
a=( $(dmsetup status $vg-$lv1) ) || die "Unable to get status of $vg/$lv1"
|
|
b=( $(echo "${a[6]}" | sed s:/:' ':) )
|
|
if [ "${b[0]}" -ne "${b[1]}" ]; then
|
|
# If the sync operation ("recover" in this case) is not
|
|
# finished, then it better be as follows:
|
|
[ "${a[5]}" = "AAa" ]
|
|
[ "${a[7]}" = "recover" ]
|
|
else
|
|
# Tough to tell the INVALID case,
|
|
# Before starting sync thread: "AAa X/X recover"
|
|
# from the valid case,
|
|
# Just finished sync thread: "AAa X/X recover"
|
|
should [ "${a[5]}" = "AAA" ] # RHBZ 1507719
|
|
should [ "${a[7]}" = "idle" ] # RHBZ 1507719
|
|
break
|
|
fi
|
|
sleep .1
|
|
done
|
|
aux enable_dev "$dev3"
|
|
lvremove -ff $vg
|
|
|
|
###########################################
|
|
# Catch anything suspicious with RAID1 initial resync
|
|
###########################################
|
|
aux delay_dev "$dev2" 0 50
|
|
lvcreate --type raid1 -m 1 -aey -l 2 -n $lv1 $vg "$dev1" "$dev2"
|
|
while true; do
|
|
a=( $(dmsetup status $vg-$lv1) ) || die "Unable to get status of $vg/$lv1"
|
|
b=( $(echo "${a[6]}" | sed s:/:' ':) )
|
|
if [ "${b[0]}" -ne "${b[1]}" ]; then
|
|
# If the sync operation ("resync" in this case) is not
|
|
# finished, then it better be as follows:
|
|
[ "${a[5]}" = "aa" ]
|
|
|
|
# Should be in "resync", but it is possible things are only
|
|
# just getting going - in which case, it could be "idle"
|
|
# with 0% sync ratio
|
|
[ "${a[7]}" = "resync" ] || \
|
|
[[ "${a[7]}" = "idle" && "${b[0]}" -eq "0" ]]
|
|
else
|
|
should [ "${a[5]}" = "AA" ] # RHBZ 1507719
|
|
should [ "${a[7]}" = "idle" ] # RHBZ 1507719
|
|
break
|
|
fi
|
|
sleep .1
|
|
done
|
|
aux enable_dev "$dev2"
|
|
lvremove -ff $vg
|
|
|
|
vgremove -ff $vg
|