mirror of
git://sourceware.org/git/lvm2.git
synced 2025-10-27 11:33:19 +03:00
f1f94d987d
Add Coverity annotations to suppress false positive warnings in several files where the static analysis tool incorrectly flags potential issues that are actually safe due to proper validation or intentional behavior. The annotations address the following false positives: - daemons/dmeventd/dmeventd.c: overflow_sink warnings for 'current' variable that is validated to be positive before use in buffer operations - daemons/lvmlockd/lvmlockd-core.c: overflow_sink warning for 'ret' variable that is validated to be positive before use - lib/config/config.c: overflow_sink warning for 'sz' variable that is validated to be positive before use in read operations - libdm/dm-tools/dmsetup.c: overflow_sink, overflow, and deref_overflow warnings for 'n' variable that is validated to be positive before use in buffer operations and string termination - libdm/libdm-stats.c: overflow_sink warning for 'i & j' variables that are validated to be positive before use in array indexing
103 lines
2.7 KiB
C
103 lines
2.7 KiB
C
/*
|
|
* Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved.
|
|
* Copyright (C) 2004-2013 Red Hat, Inc. All rights reserved.
|
|
*
|
|
* This file is part of LVM2.
|
|
*
|
|
* This copyrighted material is made available to anyone wishing to use,
|
|
* modify, copy, or redistribute it subject to the terms and conditions
|
|
* of the GNU Lesser General Public License v.2.1.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#include "base/memory/zalloc.h"
|
|
#include "lib/misc/lib.h"
|
|
#include "lib/filters/filter.h"
|
|
#include "lib/device/device.h"
|
|
|
|
static int _and_p(struct cmd_context *cmd, struct dev_filter *f, struct device *dev, const char *use_filter_name)
|
|
{
|
|
struct dev_filter **filters;
|
|
int ret = 1;
|
|
|
|
/* coverity[unchecked_value] - return value is passed through */
|
|
dev_ext_enable(dev, external_device_info_source());
|
|
|
|
for (filters = (struct dev_filter **) f->private; *filters; ++filters) {
|
|
if (use_filter_name && strcmp((*filters)->name, use_filter_name))
|
|
continue;
|
|
ret = (*filters)->passes_filter(cmd, *filters, dev, use_filter_name);
|
|
|
|
if (!ret) {
|
|
ret = 0; /* No 'stack': a filter, not an error. */
|
|
break;
|
|
}
|
|
}
|
|
|
|
dev_ext_disable(dev);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static void _composite_destroy(struct dev_filter *f)
|
|
{
|
|
struct dev_filter **filters;
|
|
|
|
if (f->use_count)
|
|
log_error(INTERNAL_ERROR "Destroying composite filter while in use %u times.", f->use_count);
|
|
|
|
for (filters = (struct dev_filter **) f->private; *filters; ++filters)
|
|
(*filters)->destroy(*filters);
|
|
|
|
free(f->private);
|
|
free(f);
|
|
}
|
|
|
|
static void _wipe(struct cmd_context *cmd, struct dev_filter *f, struct device *dev, const char *use_filter_name)
|
|
{
|
|
struct dev_filter **filters;
|
|
|
|
for (filters = (struct dev_filter **) f->private; *filters; ++filters) {
|
|
if (use_filter_name && strcmp((*filters)->name, use_filter_name))
|
|
continue;
|
|
if ((*filters)->wipe)
|
|
(*filters)->wipe(cmd, *filters, dev, use_filter_name);
|
|
}
|
|
}
|
|
|
|
struct dev_filter *composite_filter_create(int n, struct dev_filter **filters)
|
|
{
|
|
struct dev_filter **filters_copy, *cft;
|
|
|
|
if (!filters)
|
|
return_NULL;
|
|
|
|
if (!(filters_copy = malloc(sizeof(*filters) * (n + 1)))) {
|
|
log_error("Composite filters allocation failed.");
|
|
return NULL;
|
|
}
|
|
|
|
memcpy(filters_copy, filters, sizeof(*filters) * n);
|
|
filters_copy[n] = NULL;
|
|
|
|
if (!(cft = zalloc(sizeof(*cft)))) {
|
|
log_error("Composite filters allocation failed.");
|
|
free(filters_copy);
|
|
return NULL;
|
|
}
|
|
|
|
cft->passes_filter = _and_p;
|
|
cft->destroy = _composite_destroy;
|
|
cft->wipe = _wipe;
|
|
cft->use_count = 0;
|
|
cft->private = filters_copy;
|
|
cft->name = "composite";
|
|
|
|
log_debug_devs("Composite filter initialised.");
|
|
|
|
return cft;
|
|
}
|