mirror of
git://sourceware.org/git/lvm2.git
synced 2025-10-22 19:33:16 +03:00
bdfdc52093
Improve the consistency and readability of warning messages. Capitalize the first word of all warning messages. Add periods at the end of warning messages. The changes are purely cosmetic and do not affect functionality.
100 lines
2.5 KiB
C
100 lines
2.5 KiB
C
/*
|
|
* Copyright (C) 2011 Red Hat, Inc. All rights reserved.
|
|
*
|
|
* This file is part of LVM2.
|
|
*
|
|
* This copyrighted material is made available to anyone wishing to use,
|
|
* modify, copy, or redistribute it subject to the terms and conditions
|
|
* of the GNU Lesser General Public License v.2.1.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#include "base/memory/zalloc.h"
|
|
#include "lib/misc/lib.h"
|
|
#include "lib/filters/filter.h"
|
|
#include "lib/device/device_id.h"
|
|
|
|
#ifdef __linux__
|
|
|
|
#include <dirent.h>
|
|
|
|
static int _lvmdevices_update_msg;
|
|
|
|
static int _ignore_mpath_component(struct cmd_context *cmd, struct dev_filter *f, struct device *dev, const char *use_filter_name)
|
|
{
|
|
dev_t mpath_devno = 0;
|
|
|
|
dev->filtered_flags &= ~DEV_FILTERED_MPATH_COMPONENT;
|
|
|
|
if (dev_is_mpath_component(cmd, dev, &mpath_devno)) {
|
|
log_debug_devs("%s: Skipping mpath component device", dev_name(dev));
|
|
dev->filtered_flags |= DEV_FILTERED_MPATH_COMPONENT;
|
|
|
|
/*
|
|
* Warn about misconfigure where an mpath component is
|
|
* in the devices file, but its mpath device is not.
|
|
*/
|
|
if ((dev->flags & DEV_MATCHED_USE_ID) && mpath_devno) {
|
|
if (!get_du_for_devno(cmd, mpath_devno)) {
|
|
struct device *mpath_dev = dev_cache_get_by_devt(cmd, mpath_devno);
|
|
log_warn("WARNING: Devices file is missing %s (%u:%u) using multipath component %s.",
|
|
mpath_dev ? dev_name(mpath_dev) : "unknown",
|
|
MAJOR(mpath_devno), MINOR(mpath_devno), dev_name(dev));
|
|
if (!_lvmdevices_update_msg && strcmp(get_cmd_name(), "lvmdevices")) {
|
|
log_warn("See lvmdevices --update for devices file update.");
|
|
_lvmdevices_update_msg = 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
static void _destroy(struct dev_filter *f)
|
|
{
|
|
if (f->use_count)
|
|
log_error(INTERNAL_ERROR "Destroying mpath filter while in use %u times.", f->use_count);
|
|
|
|
free(f);
|
|
}
|
|
|
|
struct dev_filter *mpath_filter_create(struct dev_types *dt)
|
|
{
|
|
struct dev_filter *f;
|
|
const char *sysfs_dir = dm_sysfs_dir();
|
|
|
|
if (!*sysfs_dir) {
|
|
log_verbose("No proc filesystem found: skipping multipath filter");
|
|
return NULL;
|
|
}
|
|
|
|
if (!(f = zalloc(sizeof(*f)))) {
|
|
log_error("mpath filter allocation failed");
|
|
return NULL;
|
|
}
|
|
|
|
f->passes_filter = _ignore_mpath_component;
|
|
f->destroy = _destroy;
|
|
f->use_count = 0;
|
|
f->name = "mpath";
|
|
|
|
log_debug_devs("mpath filter initialised.");
|
|
|
|
return f;
|
|
}
|
|
|
|
#else
|
|
|
|
struct dev_filter *mpath_filter_create(struct dev_types *dt)
|
|
{
|
|
return NULL;
|
|
}
|
|
|
|
#endif
|