mirror of
git://sourceware.org/git/lvm2.git
synced 2024-10-27 10:25:13 +03:00
6e826bb6a4
When vg_read fails, it internally unlocks VG if it's been locked, so in error path we should skip unlock_vg for this case. (user would see ugly internal warning)
344 lines
8.4 KiB
C
344 lines
8.4 KiB
C
/*
|
|
* Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved.
|
|
* Copyright (C) 2004-2009 Red Hat, Inc. All rights reserved.
|
|
*
|
|
* This file is part of LVM2.
|
|
*
|
|
* This copyrighted material is made available to anyone wishing to use,
|
|
* modify, copy, or redistribute it subject to the terms and conditions
|
|
* of the GNU Lesser General Public License v.2.1.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include "tools.h"
|
|
#include "lv_alloc.h"
|
|
|
|
static int _remove_pv(struct volume_group *vg, struct pv_list *pvl, int silent)
|
|
{
|
|
char uuid[64] __attribute__((aligned(8)));
|
|
|
|
if (vg->pv_count == 1) {
|
|
log_error("Volume Groups must always contain at least one PV");
|
|
return 0;
|
|
}
|
|
|
|
if (!id_write_format(&pvl->pv->id, uuid, sizeof(uuid)))
|
|
return_0;
|
|
|
|
log_verbose("Removing PV with UUID %s from VG %s", uuid, vg->name);
|
|
|
|
if (pvl->pv->pe_alloc_count) {
|
|
if (!silent)
|
|
log_error("LVs still present on PV with UUID %s: "
|
|
"Can't remove from VG %s", uuid, vg->name);
|
|
return 0;
|
|
}
|
|
|
|
vg->free_count -= pvl->pv->pe_count;
|
|
vg->extent_count -= pvl->pv->pe_count;
|
|
del_pvl_from_vgs(vg, pvl);
|
|
free_pv_fid(pvl->pv);
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int _consolidate_vg(struct cmd_context *cmd, struct volume_group *vg)
|
|
{
|
|
struct pv_list *pvl;
|
|
struct lv_list *lvl;
|
|
int r = 1;
|
|
|
|
dm_list_iterate_items(lvl, &vg->lvs)
|
|
if (lvl->lv->status & PARTIAL_LV) {
|
|
log_warn("WARNING: Partial LV %s needs to be repaired "
|
|
"or removed. ", lvl->lv->name);
|
|
r = 0;
|
|
}
|
|
|
|
if (!r) {
|
|
cmd->handles_missing_pvs = 1;
|
|
log_error("There are still partial LVs in VG %s.", vg->name);
|
|
log_error("To remove them unconditionally use: vgreduce --removemissing --force.");
|
|
log_warn("Proceeding to remove empty missing PVs.");
|
|
}
|
|
|
|
dm_list_iterate_items(pvl, &vg->pvs) {
|
|
if (pvl->pv->dev && !is_missing_pv(pvl->pv))
|
|
continue;
|
|
if (r && !_remove_pv(vg, pvl, 0))
|
|
return_0;
|
|
}
|
|
|
|
return r;
|
|
}
|
|
|
|
static int _make_vg_consistent(struct cmd_context *cmd, struct volume_group *vg)
|
|
{
|
|
struct lv_list *lvl;
|
|
struct logical_volume *lv;
|
|
|
|
cmd->partial_activation = 1;
|
|
|
|
restart:
|
|
vg_mark_partial_lvs(vg, 1);
|
|
|
|
dm_list_iterate_items(lvl, &vg->lvs) {
|
|
lv = lvl->lv;
|
|
|
|
/* Are any segments of this LV on missing PVs? */
|
|
if (lv->status & PARTIAL_LV) {
|
|
if (lv->status & MIRRORED) {
|
|
if (!mirror_remove_missing(cmd, lv, 1))
|
|
return_0;
|
|
goto restart;
|
|
}
|
|
|
|
if (arg_count(cmd, mirrorsonly_ARG) &&!(lv->status & MIRRORED)) {
|
|
log_error("Non-mirror-image LV %s found: can't remove.", lv->name);
|
|
continue;
|
|
}
|
|
|
|
if (!lv_is_visible(lv))
|
|
continue;
|
|
log_warn("Removing partial LV %s.", lv->name);
|
|
if (!lv_remove_with_dependencies(cmd, lv, DONT_PROMPT, 0))
|
|
return_0;
|
|
goto restart;
|
|
}
|
|
}
|
|
|
|
_consolidate_vg(cmd, vg);
|
|
|
|
return 1;
|
|
}
|
|
|
|
/* Or take pv_name instead? */
|
|
static int _vgreduce_single(struct cmd_context *cmd, struct volume_group *vg,
|
|
struct physical_volume *pv,
|
|
void *handle __attribute__((unused)))
|
|
{
|
|
struct pv_list *pvl;
|
|
struct volume_group *orphan_vg = NULL;
|
|
int r = ECMD_FAILED;
|
|
const char *name = pv_dev_name(pv);
|
|
|
|
if (pv_pe_alloc_count(pv)) {
|
|
log_error("Physical volume \"%s\" still in use", name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (vg->pv_count == 1) {
|
|
log_error("Can't remove final physical volume \"%s\" from "
|
|
"volume group \"%s\"", name, vg->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!lock_vol(cmd, VG_ORPHANS, LCK_VG_WRITE)) {
|
|
log_error("Can't get lock for orphan PVs");
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
pvl = find_pv_in_vg(vg, name);
|
|
|
|
if (!archive(vg))
|
|
goto_bad;
|
|
|
|
log_verbose("Removing \"%s\" from volume group \"%s\"", name, vg->name);
|
|
|
|
if (pvl)
|
|
del_pvl_from_vgs(vg, pvl);
|
|
|
|
pv->vg_name = vg->fid->fmt->orphan_vg_name;
|
|
pv->status = ALLOCATABLE_PV;
|
|
|
|
if (!dev_get_size(pv_dev(pv), &pv->size)) {
|
|
log_error("%s: Couldn't get size.", pv_dev_name(pv));
|
|
goto bad;
|
|
}
|
|
|
|
vg->free_count -= pv_pe_count(pv) - pv_pe_alloc_count(pv);
|
|
vg->extent_count -= pv_pe_count(pv);
|
|
|
|
orphan_vg = vg_read_for_update(cmd, vg->fid->fmt->orphan_vg_name,
|
|
NULL, 0);
|
|
|
|
if (vg_read_error(orphan_vg))
|
|
goto bad;
|
|
|
|
if (!vg_split_mdas(cmd, vg, orphan_vg) || !vg->pv_count) {
|
|
log_error("Cannot remove final metadata area on \"%s\" from \"%s\"",
|
|
name, vg->name);
|
|
goto bad;
|
|
}
|
|
|
|
if (!vg_write(vg) || !vg_commit(vg)) {
|
|
log_error("Removal of physical volume \"%s\" from "
|
|
"\"%s\" failed", name, vg->name);
|
|
goto bad;
|
|
}
|
|
|
|
if (!pv_write(cmd, pv, 0)) {
|
|
log_error("Failed to clear metadata from physical "
|
|
"volume \"%s\" "
|
|
"after removal from \"%s\"", name, vg->name);
|
|
goto bad;
|
|
}
|
|
|
|
backup(vg);
|
|
|
|
log_print("Removed \"%s\" from volume group \"%s\"", name, vg->name);
|
|
r = ECMD_PROCESSED;
|
|
bad:
|
|
if (pvl)
|
|
free_pv_fid(pvl->pv);
|
|
unlock_and_release_vg(cmd, orphan_vg, VG_ORPHANS);
|
|
return r;
|
|
}
|
|
|
|
int vgreduce(struct cmd_context *cmd, int argc, char **argv)
|
|
{
|
|
struct volume_group *vg;
|
|
const char *vg_name;
|
|
int ret = ECMD_FAILED;
|
|
int fixed = 1;
|
|
int repairing = arg_count(cmd, removemissing_ARG);
|
|
int saved_ignore_suspended_devices = ignore_suspended_devices();
|
|
int locked = 0;
|
|
|
|
if (!argc && !repairing) {
|
|
log_error("Please give volume group name and "
|
|
"physical volume paths");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (!argc) { /* repairing */
|
|
log_error("Please give volume group name");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (arg_count(cmd, mirrorsonly_ARG) && !repairing) {
|
|
log_error("--mirrorsonly requires --removemissing");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (argc == 1 && !arg_count(cmd, all_ARG) && !repairing) {
|
|
log_error("Please enter physical volume paths or option -a");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (argc > 1 && arg_count(cmd, all_ARG)) {
|
|
log_error("Option -a and physical volume paths mutually "
|
|
"exclusive");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (argc > 1 && repairing) {
|
|
log_error("Please only specify the volume group");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
vg_name = skip_dev_dir(cmd, argv[0], NULL);
|
|
argv++;
|
|
argc--;
|
|
|
|
log_verbose("Finding volume group \"%s\"", vg_name);
|
|
|
|
if (repairing) {
|
|
init_ignore_suspended_devices(1);
|
|
cmd->handles_missing_pvs = 1;
|
|
}
|
|
|
|
vg = vg_read_for_update(cmd, vg_name, NULL, READ_ALLOW_EXPORTED);
|
|
if (vg_read_error(vg) == FAILED_ALLOCATION ||
|
|
vg_read_error(vg) == FAILED_NOTFOUND)
|
|
goto_out;
|
|
|
|
/* FIXME We want to allow read-only VGs to be changed here? */
|
|
if (vg_read_error(vg) && vg_read_error(vg) != FAILED_READ_ONLY
|
|
&& !arg_count(cmd, removemissing_ARG))
|
|
goto_out;
|
|
|
|
locked = !vg_read_error(vg);
|
|
|
|
if (repairing) {
|
|
if (!vg_read_error(vg) && !vg_missing_pv_count(vg)) {
|
|
log_error("Volume group \"%s\" is already consistent",
|
|
vg_name);
|
|
ret = ECMD_PROCESSED;
|
|
goto out;
|
|
}
|
|
|
|
release_vg(vg);
|
|
log_verbose("Trying to open VG %s for recovery...", vg_name);
|
|
|
|
vg = vg_read_for_update(cmd, vg_name, NULL,
|
|
READ_ALLOW_INCONSISTENT
|
|
| READ_ALLOW_EXPORTED);
|
|
|
|
locked |= !vg_read_error(vg);
|
|
if (vg_read_error(vg) && vg_read_error(vg) != FAILED_READ_ONLY
|
|
&& vg_read_error(vg) != FAILED_INCONSISTENT)
|
|
goto_out;
|
|
|
|
if (!archive(vg))
|
|
goto_out;
|
|
|
|
if (arg_count(cmd, force_ARG)) {
|
|
if (!_make_vg_consistent(cmd, vg))
|
|
goto_out;
|
|
} else
|
|
fixed = _consolidate_vg(cmd, vg);
|
|
|
|
if (!vg_write(vg) || !vg_commit(vg)) {
|
|
log_error("Failed to write out a consistent VG for %s",
|
|
vg_name);
|
|
goto out;
|
|
}
|
|
backup(vg);
|
|
|
|
if (fixed) {
|
|
log_print("Wrote out consistent volume group %s",
|
|
vg_name);
|
|
ret = ECMD_PROCESSED;
|
|
} else
|
|
ret = ECMD_FAILED;
|
|
|
|
} else {
|
|
if (!vg_check_status(vg, EXPORTED_VG | LVM_WRITE | RESIZEABLE_VG))
|
|
goto_out;
|
|
|
|
/* FIXME: Pass private struct through to all these functions */
|
|
/* and update in batch here? */
|
|
ret = process_each_pv(cmd, argc, argv, vg, READ_FOR_UPDATE, 0, NULL,
|
|
_vgreduce_single);
|
|
|
|
}
|
|
out:
|
|
init_ignore_suspended_devices(saved_ignore_suspended_devices);
|
|
if (locked)
|
|
unlock_vg(cmd, vg_name);
|
|
|
|
release_vg(vg);
|
|
|
|
return ret;
|
|
|
|
/******* FIXME
|
|
log_error ("no empty physical volumes found in volume group \"%s\"", vg_name);
|
|
|
|
log_verbose
|
|
("volume group \"%s\" will be reduced by %d physical volume%s",
|
|
vg_name, np, np > 1 ? "s" : "");
|
|
log_verbose ("reducing volume group \"%s\" by physical volume \"%s\"",
|
|
vg_name, pv_names[p]);
|
|
|
|
log_print
|
|
("volume group \"%s\" %ssuccessfully reduced by physical volume%s:",
|
|
vg_name, error > 0 ? "NOT " : "", p > 1 ? "s" : "");
|
|
log_print("%s", pv_this[p]->pv_name);
|
|
********/
|
|
|
|
}
|