mirror of
git://sourceware.org/git/lvm2.git
synced 2024-12-22 17:35:59 +03:00
d38bf3616c
Fix missing VG unlocks in some pvchange error paths. Add some missing validation of VG names. Rename validate_vg_name() to validate_new_vg_name(). Change orphan lock to VG_ORPHANS. Change format1 to use ORPHAN as orphan VG name.
141 lines
3.5 KiB
C
141 lines
3.5 KiB
C
/*
|
|
* Copyright (C) 2002-2004 Sistina Software, Inc. All rights reserved.
|
|
* Copyright (C) 2004-2007 Red Hat, Inc. All rights reserved.
|
|
*
|
|
* This file is part of LVM2.
|
|
*
|
|
* This copyrighted material is made available to anyone wishing to use,
|
|
* modify, copy, or redistribute it subject to the terms and conditions
|
|
* of the GNU Lesser General Public License v.2.1.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include "tools.h"
|
|
|
|
const char _really_wipe[] =
|
|
"Really WIPE LABELS from physical volume \"%s\" of volume group \"%s\" [y/n]? ";
|
|
|
|
/*
|
|
* Decide whether it is "safe" to wipe the labels on this device.
|
|
* 0 indicates we may not.
|
|
*/
|
|
static int pvremove_check(struct cmd_context *cmd, const char *name)
|
|
{
|
|
struct physical_volume *pv;
|
|
|
|
/* is the partition type set correctly ? */
|
|
if ((arg_count(cmd, force_ARG) < 1) && !is_lvm_partition(name)) {
|
|
log_error("%s: Not LVM partition type: use -f to override",
|
|
name);
|
|
return 0;
|
|
}
|
|
|
|
/* Is there a pv here already? */
|
|
/* If not, this is an error unless you used -f. */
|
|
if (!(pv = pv_read(cmd, name, NULL, NULL, 1))) {
|
|
if (arg_count(cmd, force_ARG))
|
|
return 1;
|
|
log_error("Physical Volume %s not found", name);
|
|
return 0;
|
|
}
|
|
|
|
/* orphan ? */
|
|
if (is_orphan(pv))
|
|
return 1;
|
|
|
|
/* Allow partial & exported VGs to be destroyed. */
|
|
/* we must have -ff to overwrite a non orphan */
|
|
if (arg_count(cmd, force_ARG) < 2) {
|
|
log_error("Can't pvremove physical volume \"%s\" of "
|
|
"volume group \"%s\" without -ff", name, pv_vg_name(pv));
|
|
return 0;
|
|
}
|
|
|
|
/* prompt */
|
|
if (!arg_count(cmd, yes_ARG) &&
|
|
yes_no_prompt(_really_wipe, name, pv_vg_name(pv)) == 'n') {
|
|
log_print("%s: physical volume label not removed", name);
|
|
return 0;
|
|
}
|
|
|
|
if (arg_count(cmd, force_ARG)) {
|
|
log_warn("WARNING: Wiping physical volume label from "
|
|
"%s%s%s%s", name,
|
|
!is_orphan(pv) ? " of volume group \"" : "",
|
|
!is_orphan(pv) ? pv_vg_name(pv) : "",
|
|
!is_orphan(pv) ? "\"" : "");
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int pvremove_single(struct cmd_context *cmd, const char *pv_name,
|
|
void *handle __attribute((unused)))
|
|
{
|
|
struct device *dev;
|
|
int ret = ECMD_FAILED;
|
|
|
|
if (!lock_vol(cmd, VG_ORPHANS, LCK_VG_WRITE)) {
|
|
log_error("Can't get lock for orphan PVs");
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!pvremove_check(cmd, pv_name))
|
|
goto error;
|
|
|
|
if (!(dev = dev_cache_get(pv_name, cmd->filter))) {
|
|
log_error("%s: Couldn't find device. Check your filters?",
|
|
pv_name);
|
|
goto error;
|
|
}
|
|
|
|
if (!dev_test_excl(dev)) {
|
|
log_error("Can't open %s exclusively - not removing. "
|
|
"Mounted filesystem?", dev_name(dev));
|
|
goto error;
|
|
}
|
|
|
|
/* Wipe existing label(s) */
|
|
if (!label_remove(dev)) {
|
|
log_error("Failed to wipe existing label(s) on %s", pv_name);
|
|
goto error;
|
|
}
|
|
|
|
log_print("Labels on physical volume \"%s\" successfully wiped",
|
|
pv_name);
|
|
|
|
ret = ECMD_PROCESSED;
|
|
|
|
error:
|
|
unlock_vg(cmd, VG_ORPHANS);
|
|
|
|
return ret;
|
|
}
|
|
|
|
int pvremove(struct cmd_context *cmd, int argc, char **argv)
|
|
{
|
|
int i, r;
|
|
int ret = ECMD_PROCESSED;
|
|
|
|
if (!argc) {
|
|
log_error("Please enter a physical volume path");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (arg_count(cmd, yes_ARG) && !arg_count(cmd, force_ARG)) {
|
|
log_error("Option y can only be given with option f");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
for (i = 0; i < argc; i++) {
|
|
r = pvremove_single(cmd, argv[i], NULL);
|
|
if (r > ret)
|
|
ret = r;
|
|
}
|
|
|
|
return ret;
|
|
}
|