mirror of
git://sourceware.org/git/lvm2.git
synced 2024-12-21 13:34:40 +03:00
80bcdb93ff
Split out the partitioned device filter that needs to open the device and move the multipath filter in front of it. When a device is multipathed, sending I/O to the underlying paths may cause problems, the most obvious being I/O errors visible to lvm if a path is down. Revert the incorrect <backtrace> messages added when a device doesn't pass a filter. Log each filter initialisation to show sequence. Avoid duplicate 'Using $device' debug messages.
97 lines
2.4 KiB
C
97 lines
2.4 KiB
C
/*
|
|
* Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved.
|
|
* Copyright (C) 2004-2013 Red Hat, Inc. All rights reserved.
|
|
*
|
|
* This file is part of LVM2.
|
|
*
|
|
* This copyrighted material is made available to anyone wishing to use,
|
|
* modify, copy, or redistribute it subject to the terms and conditions
|
|
* of the GNU Lesser General Public License v.2.1.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include "lib.h"
|
|
#include "filter.h"
|
|
|
|
static int _and_p(struct dev_filter *f, struct device *dev)
|
|
{
|
|
struct dev_filter **filters;
|
|
|
|
for (filters = (struct dev_filter **) f->private; *filters; ++filters)
|
|
if (!(*filters)->passes_filter(*filters, dev))
|
|
return 0; /* No 'stack': a filter, not an error. */
|
|
|
|
return 1;
|
|
}
|
|
|
|
static void _composite_destroy(struct dev_filter *f)
|
|
{
|
|
struct dev_filter **filters;
|
|
|
|
if (f->use_count)
|
|
log_error(INTERNAL_ERROR "Destroying composite filter while in use %u times.", f->use_count);
|
|
|
|
for (filters = (struct dev_filter **) f->private; *filters; ++filters)
|
|
(*filters)->destroy(*filters);
|
|
|
|
dm_free(f->private);
|
|
dm_free(f);
|
|
}
|
|
|
|
static int _dump(struct dev_filter *f, int merge_existing)
|
|
{
|
|
struct dev_filter **filters;
|
|
|
|
for (filters = (struct dev_filter **) f->private; *filters; ++filters)
|
|
if ((*filters)->dump &&
|
|
!(*filters)->dump(*filters, merge_existing))
|
|
return_0;
|
|
|
|
return 1;
|
|
}
|
|
|
|
static void _wipe(struct dev_filter *f)
|
|
{
|
|
struct dev_filter **filters;
|
|
|
|
for (filters = (struct dev_filter **) f->private; *filters; ++filters)
|
|
if ((*filters)->wipe)
|
|
(*filters)->wipe(*filters);
|
|
}
|
|
|
|
struct dev_filter *composite_filter_create(int n, struct dev_filter **filters)
|
|
{
|
|
struct dev_filter **filters_copy, *cft;
|
|
|
|
if (!filters)
|
|
return_NULL;
|
|
|
|
if (!(filters_copy = dm_malloc(sizeof(*filters) * (n + 1)))) {
|
|
log_error("Composite filters allocation failed.");
|
|
return NULL;
|
|
}
|
|
|
|
memcpy(filters_copy, filters, sizeof(*filters) * n);
|
|
filters_copy[n] = NULL;
|
|
|
|
if (!(cft = dm_zalloc(sizeof(*cft)))) {
|
|
log_error("Composite filters allocation failed.");
|
|
dm_free(filters_copy);
|
|
return NULL;
|
|
}
|
|
|
|
cft->passes_filter = _and_p;
|
|
cft->destroy = _composite_destroy;
|
|
cft->dump = _dump;
|
|
cft->wipe = _wipe;
|
|
cft->use_count = 0;
|
|
cft->private = filters_copy;
|
|
|
|
log_debug_devs("Composite filter initialised.");
|
|
|
|
return cft;
|
|
}
|