mirror of
git://sourceware.org/git/lvm2.git
synced 2024-12-22 17:35:59 +03:00
ba7ff96faf
The fact that vg repair is implemented as a part of vg read has led to a messy and complicated implementation of vg_read, and limited and uncontrolled repair capability. This splits read and repair apart. Summary ------- - take all kinds of various repairs out of vg_read - vg_read no longer writes anything - vg_read now simply reads and returns vg metadata - vg_read ignores bad or old copies of metadata - vg_read proceeds with a single good copy of metadata - improve error checks and handling when reading - keep track of bad (corrupt) copies of metadata in lvmcache - keep track of old (seqno) copies of metadata in lvmcache - keep track of outdated PVs in lvmcache - vg_write will do basic repairs - new command vgck --updatemetdata will do all repairs Details ------- - In scan, do not delete dev from lvmcache if reading/processing fails; the dev is still present, and removing it makes it look like the dev is not there. Records are now kept about the problems with each PV so they be fixed/repaired in the appropriate places. - In scan, record a bad mda on failure, and delete the mda from mda in use list so it will not be used by vg_read or vg_write, only by repair. - In scan, succeed if any good mda on a device is found, instead of failing if any is bad. The bad/old copies of metadata should not interfere with normal usage while good copies can be used. - In scan, add a record of old mdas in lvmcache for later, do not repair them while reading, and do not let them prevent us from finding and using a good copy of metadata from elsewhere. One result is that "inconsistent metadata" is no longer a read error, but instead a record in lvmcache that can be addressed separate from the read. - Treat a dev with no good mdas like a dev with no mdas, which is an existing case we already handle. - Don't use a fake vg "handle" for returning an error from vg_read, or the vg_read_error function for getting that error number; just return null if the vg cannot be read or used, and an error_flags arg with flags set for the specific kind of error (which can be used later for determining the kind of repair.) - Saving an original copy of the vg metadata, for purposes of reverting a write, is now done explicitly in vg_read instead of being hidden in the vg_make_handle function. - When a vg is not accessible due to "access restrictions" but is otherwise fine, return the vg through the new error_vg arg so that process_each_pv can skip the PVs in the VG while processing. (This is a temporary accomodation for the way process_each_pv tracks which devs have been looked at, and can be dropped later when process_each_pv implementation dev tracking is changed.) - vg_read does not try to fix or recover a vg, but now just reads the metadata, checks access restrictions and returns it. (Checking access restrictions might be better done outside of vg_read, but this is a later improvement.) - _vg_read now simply makes one attempt to read metadata from each mda, and uses the most recent copy to return to the caller in the form of a 'vg' struct. (bad mdas were excluded during the scan and are not retried) (old mdas were not excluded during scan and are retried here) - vg_read uses _vg_read to get the latest copy of metadata from mdas, and then makes various checks against it to produce warnings, and to check if VG access is allowed (access restrictions include: writable, foreign, shared, clustered, missing pvs). - Things that were previously silently/automatically written by vg_read that are now done by vg_write, based on the records made in lvmcache during the scan and read: . clearing the missing flag . updating old copies of metadata . clearing outdated pvs . updating pv header flags - Bad/corrupt metadata are now repaired; they were not before. Test changes ------------ - A read command no longer writes the VG to repair it, so add a write command to do a repair. (inconsistent-metadata, unlost-pv) - When a missing PV is removed from a VG, and then the device is enabled again, vgck --updatemetadata is needed to clear the outdated PV before it can be used again, where it wasn't before. (lvconvert-repair-policy, lvconvert-repair-raid, lvconvert-repair, mirror-vgreduce-removemissing, pv-ext-flags, unlost-pv) Reading bad/old metadata ------------------------ - "bad metadata": the mda_header or metadata text has invalid fields or can't be parsed by lvm. This is a form of corruption that would not be caused by known failure scenarios. A checksum error is typically included among the errors reported. - "old metadata": a valid copy of the metadata that has a smaller seqno than other copies of the metadata. This can happen if the device failed, or io failed, or lvm failed while commiting new metadata to all the metadata areas. Old metadata on a PV that has been removed from the VG is the "outdated" case below. When a VG has some PVs with bad/old metadata, lvm can simply ignore the bad/old copies, and use a good copy. This is why there are multiple copies of the metadata -- so it's available even when some of the copies cannot be used. The bad/old copies do not have to be repaired before the VG can be used (the repair can happen later.) A PV with no good copies of the metadata simply falls back to being treated like a PV with no mdas; a common and harmless configuration. When bad/old metadata exists, lvm warns the user about it, and suggests repairing it using a new metadata repair command. Bad metadata in particular is something that users will want to investigate and repair themselves, since it should not happen and may indicate some other problem that needs to be fixed. PVs with bad/old metadata are not the same as missing devices. Missing devices will block various kinds of VG modification or activation, but bad/old metadata will not. Previously, lvm would attempt to repair bad/old metadata whenever it was read. This was unnecessary since lvm does not require every copy of the metadata to be used. It would also hide potential problems that should be investigated by the user. It was also dangerous in cases where the VG was on shared storage. The user is now allowed to investigate potential problems and decide how and when to repair them. Repairing bad/old metadata -------------------------- When label scan sees bad metadata in an mda, that mda is removed from the lvmcache info->mdas list. This means that vg_read will skip it, and not attempt to read/process it again. If it was the only in-use mda on a PV, that PV is treated like a PV with no mdas. It also means that vg_write will also skip the bad mda, and not attempt to write new metadata to it. The only way to repair bad metadata is with the metadata repair command. When label scan sees old metadata in an mda, that mda is kept in the lvmcache info->mdas list. This means that vg_read will read/process it again, and likely see the same mismatch with the other copies of the metadata. Like the label_scan, the vg_read will simply ignore the old copy of the metadata and use the latest copy. If the command is modifying the vg (e.g. lvcreate), then vg_write, which writes new metadata to every mda on info->mdas, will write the new metadata to the mda that had the old version. If successful, this will resolve the old metadata problem (without needing to run a metadata repair command.) Outdated PVs ------------ An outdated PV is a PV that has an old copy of VG metadata that shows it is a member of the VG, but the latest copy of the VG metadata does not include this PV. This happens if the PV is disconnected, vgreduce --removemissing is run to remove the PV from the VG, then the PV is reconnected. In this case, the outdated PV needs have its outdated metadata removed and the PV used flag needs to be cleared. This repair will be done by the subsequent repair command. It is also done if vgremove is run on the VG. MISSING PVs ----------- When a device is missing, most commands will refuse to modify the VG. This is the simple case. More complicated is when a command is allowed to modify the VG while it is missing a device. When a VG is written while a device is missing for one of it's PVs, the VG metadata is written to disk with the MISSING flag on the PV with the missing device. When the VG is next used, it is treated as if the PV with the MISSING flag still has a missing device, even if that device has reappeared. If all LVs that were using a PV with the MISSING flag are removed or repaired so that the MISSING PV is no longer used, then the next time the VG metadata is written, the MISSING flag will be dropped. Alternative methods of clearing the MISSING flag are: vgreduce --removemissing will remove PVs with missing devices, or PVs with the MISSING flag where the device has reappeared. vgextend --restoremissing will clear the MISSING flag on PVs where the device has reappeared, allowing the VG to be used normally. This must be done with caution since the reappeared device may have old data that is inconsistent with data on other PVs. Bad mda repair -------------- The new command: vgck --updatemetadata VG first uses vg_write to repair old metadata, and other basic issues mentioned above (old metadata, outdated PVs, pv_header flags, MISSING_PV flags). It will also go further and repair bad metadata: . text metadata that has a bad checksum . text metadata that is not parsable . corrupt mda_header checksum and version fields (To keep a clean diff, #if 0 is added around functions that are replaced by new code. These commented functions are removed by the following commit.)
105 lines
3.6 KiB
C
105 lines
3.6 KiB
C
/*
|
|
* Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved.
|
|
* Copyright (C) 2004-2010 Red Hat, Inc. All rights reserved.
|
|
*
|
|
* This file is part of LVM2.
|
|
*
|
|
* This copyrighted material is made available to anyone wishing to use,
|
|
* modify, copy, or redistribute it subject to the terms and conditions
|
|
* of the GNU Lesser General Public License v.2.1.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
#ifndef _LVM_PV_H
|
|
#define _LVM_PV_H
|
|
|
|
#include "lib/uuid/uuid.h"
|
|
#include "device_mapper/all.h"
|
|
|
|
struct device;
|
|
struct format_type;
|
|
struct volume_group;
|
|
|
|
struct physical_volume {
|
|
struct id id;
|
|
struct id old_id; /* Set during pvchange -u. */
|
|
struct device *dev;
|
|
const struct format_type *fmt;
|
|
struct format_instance *fid;
|
|
|
|
/*
|
|
* vg_name and vgid are used before the parent VG struct exists.
|
|
* FIXME: Investigate removal/substitution with 'vg' fields.
|
|
*/
|
|
const char *vg_name;
|
|
struct id vgid;
|
|
|
|
/*
|
|
* 'vg' is set and maintained when the PV belongs to a 'pvs'
|
|
* list in a parent VG struct.
|
|
*/
|
|
struct volume_group *vg;
|
|
|
|
uint64_t status;
|
|
uint64_t size;
|
|
|
|
/* bootloader area */
|
|
uint64_t ba_start;
|
|
uint64_t ba_size;
|
|
|
|
/* physical extents */
|
|
uint32_t pe_size;
|
|
uint64_t pe_start;
|
|
uint32_t pe_count;
|
|
uint32_t pe_alloc_count;
|
|
uint64_t pe_align;
|
|
uint64_t pe_align_offset;
|
|
|
|
/* This is true whenever the represented PV has a label associated. */
|
|
uint64_t is_labelled:1;
|
|
uint64_t unused_missing_cleared:1;
|
|
|
|
/* NB. label_sector is valid whenever is_labelled is true */
|
|
uint64_t label_sector;
|
|
|
|
struct dm_list segments; /* Ordered pv_segments covering complete PV */
|
|
struct dm_list tags;
|
|
};
|
|
|
|
char *pv_fmt_dup(const struct physical_volume *pv);
|
|
char *pv_name_dup(struct dm_pool *mem, const struct physical_volume *pv);
|
|
struct device *pv_dev(const struct physical_volume *pv);
|
|
const char *pv_vg_name(const struct physical_volume *pv);
|
|
char *pv_attr_dup(struct dm_pool *mem, const struct physical_volume *pv);
|
|
const char *pv_dev_name(const struct physical_volume *pv);
|
|
char *pv_uuid_dup(struct dm_pool *mem, const struct physical_volume *pv);
|
|
char *pv_tags_dup(const struct physical_volume *pv);
|
|
uint64_t pv_size(const struct physical_volume *pv);
|
|
uint64_t pv_size_field(const struct physical_volume *pv);
|
|
uint64_t pv_dev_size(const struct physical_volume *pv);
|
|
uint64_t pv_free(const struct physical_volume *pv);
|
|
uint64_t pv_status(const struct physical_volume *pv);
|
|
uint32_t pv_pe_size(const struct physical_volume *pv);
|
|
uint64_t pv_pe_start(const struct physical_volume *pv);
|
|
uint64_t pv_ba_start(const struct physical_volume *pv);
|
|
uint64_t pv_ba_size(const struct physical_volume *pv);
|
|
uint32_t pv_pe_count(const struct physical_volume *pv);
|
|
uint32_t pv_pe_alloc_count(const struct physical_volume *pv);
|
|
uint64_t pv_mda_size(const struct physical_volume *pv);
|
|
struct lvmcache_info;
|
|
uint64_t lvmcache_info_mda_free(struct lvmcache_info *info);
|
|
uint64_t pv_mda_free(const struct physical_volume *pv);
|
|
uint64_t pv_used(const struct physical_volume *pv);
|
|
uint32_t pv_mda_count(const struct physical_volume *pv);
|
|
uint32_t pv_mda_used_count(const struct physical_volume *pv);
|
|
unsigned pv_mda_set_ignored(const struct physical_volume *pv, unsigned mda_ignored);
|
|
int is_orphan(const struct physical_volume *pv);
|
|
int is_missing_pv(const struct physical_volume *pv);
|
|
int is_used_pv(const struct physical_volume *pv);
|
|
int is_pv(const struct physical_volume *pv);
|
|
struct label *pv_label(const struct physical_volume *pv);
|
|
|
|
#endif /* _LVM_PV_H */
|