mirror of
git://sourceware.org/git/lvm2.git
synced 2024-12-21 13:34:40 +03:00
0ddb66efba
Going forward, we would like to allow users to specify the total number of metadatacopies in a VG rather than on a per-PV basis. In order to facilitate that, introduce --pvmetadatacopes to replace --metadatacopies everywhere. We still allow --metadatacopies for pv commands, but require --pvmetadatacopies for vg commands. Eventually we will introduce --vgmetadatacopies. Once we do that, we should either deprecate --metadatacopies or make it a synonym based on the command (pvmetadatacopies for pv commands, and vgmetadatacopies for vg commands). The latter option would likely just require a simple 'strncpy' check against cmd->command->name to qualify the merge_synonym call. Update nightly tests to cover the pvmetadatacopies synonym. Note that this patch is the result of an eariler review comment for the implicit pvcreate patches. Should apply cleanly on top of the implicit pvcreate patches (I applied after patch 10/10 in that series). NOTE: This patch will require --pvmetadatacopies for vgconvert as --metadatacopies is no longer accepted.
235 lines
6.7 KiB
C
235 lines
6.7 KiB
C
/*
|
|
* Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved.
|
|
* Copyright (C) 2004-2007 Red Hat, Inc. All rights reserved.
|
|
*
|
|
* This file is part of LVM2.
|
|
*
|
|
* This copyrighted material is made available to anyone wishing to use,
|
|
* modify, copy, or redistribute it subject to the terms and conditions
|
|
* of the GNU Lesser General Public License v.2.1.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include "tools.h"
|
|
|
|
static int vgconvert_single(struct cmd_context *cmd, const char *vg_name,
|
|
struct volume_group *vg,
|
|
void *handle __attribute((unused)))
|
|
{
|
|
struct physical_volume *pv, *existing_pv;
|
|
struct logical_volume *lv;
|
|
struct lv_list *lvl;
|
|
uint64_t size = 0;
|
|
struct dm_list mdas;
|
|
int pvmetadatacopies = 0;
|
|
uint64_t pvmetadatasize = 0;
|
|
uint64_t pe_end = 0, pe_start = 0;
|
|
struct pv_list *pvl;
|
|
int change_made = 0;
|
|
struct lvinfo info;
|
|
int active = 0;
|
|
|
|
if (!vg_check_status(vg, LVM_WRITE | EXPORTED_VG)) {
|
|
stack;
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (vg->fid->fmt == cmd->fmt) {
|
|
log_error("Volume group \"%s\" already uses format %s",
|
|
vg_name, cmd->fmt->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (cmd->fmt->features & FMT_MDAS) {
|
|
if (arg_sign_value(cmd, metadatasize_ARG, 0) == SIGN_MINUS) {
|
|
log_error("Metadata size may not be negative");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
pvmetadatasize = arg_uint64_value(cmd, metadatasize_ARG,
|
|
UINT64_C(0));
|
|
if (!pvmetadatasize)
|
|
pvmetadatasize =
|
|
find_config_tree_int(cmd,
|
|
"metadata/pvmetadatasize",
|
|
DEFAULT_PVMETADATASIZE);
|
|
|
|
pvmetadatacopies = arg_int_value(cmd, pvmetadatacopies_ARG, -1);
|
|
if (pvmetadatacopies < 0)
|
|
pvmetadatacopies =
|
|
find_config_tree_int(cmd,
|
|
"metadata/pvmetadatacopies",
|
|
DEFAULT_PVMETADATACOPIES);
|
|
}
|
|
|
|
if (!archive(vg)) {
|
|
log_error("Archive of \"%s\" metadata failed.", vg_name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
/* Set PV/LV limit if converting from unlimited metadata format */
|
|
if (vg->fid->fmt->features & FMT_UNLIMITED_VOLS &&
|
|
!(cmd->fmt->features & FMT_UNLIMITED_VOLS)) {
|
|
if (!vg->max_lv)
|
|
vg->max_lv = 255;
|
|
if (!vg->max_pv)
|
|
vg->max_pv = 255;
|
|
}
|
|
|
|
/* If converting to restricted lvid, check if lvid is compatible */
|
|
if (!(vg->fid->fmt->features & FMT_RESTRICTED_LVIDS) &&
|
|
cmd->fmt->features & FMT_RESTRICTED_LVIDS)
|
|
dm_list_iterate_items(lvl, &vg->lvs)
|
|
if (!lvid_in_restricted_range(&lvl->lv->lvid)) {
|
|
log_error("Logical volume %s lvid format is"
|
|
" incompatible with requested"
|
|
" metadata format.", lvl->lv->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
/* Attempt to change any LVIDs that are too big */
|
|
if (cmd->fmt->features & FMT_RESTRICTED_LVIDS) {
|
|
dm_list_iterate_items(lvl, &vg->lvs) {
|
|
lv = lvl->lv;
|
|
if (lv->status & SNAPSHOT)
|
|
continue;
|
|
if (lvnum_from_lvid(&lv->lvid) < MAX_RESTRICTED_LVS)
|
|
continue;
|
|
if (lv_info(cmd, lv, &info, 0, 0) && info.exists) {
|
|
log_error("Logical volume %s must be "
|
|
"deactivated before conversion.",
|
|
lv->name);
|
|
active++;
|
|
continue;
|
|
}
|
|
lvid_from_lvnum(&lv->lvid, &lv->vg->id, find_free_lvnum(lv));
|
|
|
|
}
|
|
}
|
|
|
|
if (active) {
|
|
stack;
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
dm_list_iterate_items(pvl, &vg->pvs) {
|
|
existing_pv = pvl->pv;
|
|
|
|
pe_start = pv_pe_start(existing_pv);
|
|
pe_end = pv_pe_count(existing_pv) * pv_pe_size(existing_pv)
|
|
+ pe_start - 1;
|
|
|
|
dm_list_init(&mdas);
|
|
if (!(pv = pv_create(cmd, pv_dev(existing_pv),
|
|
&existing_pv->id, size, 0, 0,
|
|
pe_start, pv_pe_count(existing_pv),
|
|
pv_pe_size(existing_pv), pvmetadatacopies,
|
|
pvmetadatasize, &mdas))) {
|
|
log_error("Failed to setup physical volume \"%s\"",
|
|
pv_dev_name(existing_pv));
|
|
if (change_made)
|
|
log_error("Use pvcreate and vgcfgrestore to "
|
|
"repair from archived metadata.");
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
/* Need to revert manually if it fails after this point */
|
|
change_made = 1;
|
|
|
|
log_verbose("Set up physical volume for \"%s\" with %" PRIu64
|
|
" available sectors", pv_dev_name(pv), pv_size(pv));
|
|
|
|
/* Wipe existing label first */
|
|
if (!label_remove(pv_dev(pv))) {
|
|
log_error("Failed to wipe existing label on %s",
|
|
pv_dev_name(pv));
|
|
log_error("Use pvcreate and vgcfgrestore to repair "
|
|
"from archived metadata.");
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
log_very_verbose("Writing physical volume data to disk \"%s\"",
|
|
pv_dev_name(pv));
|
|
if (!(pv_write(cmd, pv, &mdas,
|
|
arg_int64_value(cmd, labelsector_ARG,
|
|
DEFAULT_LABELSECTOR)))) {
|
|
log_error("Failed to write physical volume \"%s\"",
|
|
pv_dev_name(pv));
|
|
log_error("Use pvcreate and vgcfgrestore to repair "
|
|
"from archived metadata.");
|
|
return ECMD_FAILED;
|
|
}
|
|
log_verbose("Physical volume \"%s\" successfully created",
|
|
pv_dev_name(pv));
|
|
|
|
}
|
|
|
|
log_verbose("Deleting existing metadata for VG %s", vg_name);
|
|
if (!vg_remove_mdas(vg)) {
|
|
log_error("Removal of existing metadata for %s failed.",
|
|
vg_name);
|
|
log_error("Use pvcreate and vgcfgrestore to repair "
|
|
"from archived metadata.");
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
/* FIXME Cache the label format change so we don't have to skip this */
|
|
if (test_mode()) {
|
|
log_verbose("Test mode: Skipping metadata writing for VG %s in"
|
|
" format %s", vg_name, cmd->fmt->name);
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
log_verbose("Writing metadata for VG %s using format %s", vg_name,
|
|
cmd->fmt->name);
|
|
if (!backup_restore_vg(cmd, vg)) {
|
|
log_error("Conversion failed for volume group %s.", vg_name);
|
|
log_error("Use pvcreate and vgcfgrestore to repair from "
|
|
"archived metadata.");
|
|
return ECMD_FAILED;
|
|
}
|
|
log_print("Volume group %s successfully converted", vg_name);
|
|
|
|
backup(vg);
|
|
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
int vgconvert(struct cmd_context *cmd, int argc, char **argv)
|
|
{
|
|
if (!argc) {
|
|
log_error("Please enter volume group(s)");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (arg_int_value(cmd, labelsector_ARG, 0) >= LABEL_SCAN_SECTORS) {
|
|
log_error("labelsector must be less than %lu",
|
|
LABEL_SCAN_SECTORS);
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (arg_count(cmd, metadatacopies_ARG)) {
|
|
log_error("Invalid option --metadatacopies, "
|
|
"use --pvmetadatacopies instead.");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
if (!(cmd->fmt->features & FMT_MDAS) &&
|
|
(arg_count(cmd, pvmetadatacopies_ARG) ||
|
|
arg_count(cmd, metadatasize_ARG))) {
|
|
log_error("Metadata parameters only apply to text format");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (arg_count(cmd, pvmetadatacopies_ARG) &&
|
|
arg_int_value(cmd, pvmetadatacopies_ARG, -1) > 2) {
|
|
log_error("Metadatacopies may only be 0, 1 or 2");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
return process_each_vg(cmd, argc, argv, READ_FOR_UPDATE, NULL,
|
|
&vgconvert_single);
|
|
}
|