mirror of
git://sourceware.org/git/lvm2.git
synced 2024-10-27 18:55:19 +03:00
80bcdb93ff
Split out the partitioned device filter that needs to open the device and move the multipath filter in front of it. When a device is multipathed, sending I/O to the underlying paths may cause problems, the most obvious being I/O errors visible to lvm if a path is down. Revert the incorrect <backtrace> messages added when a device doesn't pass a filter. Log each filter initialisation to show sequence. Avoid duplicate 'Using $device' debug messages.
84 lines
2.0 KiB
C
84 lines
2.0 KiB
C
/*
|
|
* Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved.
|
|
* Copyright (C) 2004-2012 Red Hat, Inc. All rights reserved.
|
|
*
|
|
* This file is part of LVM2.
|
|
*
|
|
* This copyrighted material is made available to anyone wishing to use,
|
|
* modify, copy, or redistribute it subject to the terms and conditions
|
|
* of the GNU Lesser General Public License v.2.1.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include "lib.h"
|
|
#include "filter.h"
|
|
|
|
static int _passes_partitioned_filter(struct dev_filter *f, struct device *dev)
|
|
{
|
|
struct dev_types *dt = (struct dev_types *) f->private;
|
|
const char *name = dev_name(dev);
|
|
int ret = 0;
|
|
uint64_t size;
|
|
|
|
/* Check it's accessible */
|
|
if (!dev_open_readonly_quiet(dev)) {
|
|
log_debug_devs("%s: Skipping: open failed", name);
|
|
return 0;
|
|
}
|
|
|
|
/* Check it's not too small */
|
|
if (!dev_get_size(dev, &size)) {
|
|
log_debug_devs("%s: Skipping: dev_get_size failed", name);
|
|
goto out;
|
|
}
|
|
|
|
if (size < pv_min_size()) {
|
|
log_debug_devs("%s: Skipping: Too small to hold a PV", name);
|
|
goto out;
|
|
}
|
|
|
|
if (dev_is_partitioned(dt, dev)) {
|
|
log_debug_devs("%s: Skipping: Partition table signature found",
|
|
name);
|
|
goto out;
|
|
}
|
|
|
|
ret = 1;
|
|
|
|
out:
|
|
if (!dev_close(dev))
|
|
stack;
|
|
|
|
return ret;
|
|
}
|
|
|
|
static void _partitioned_filter_destroy(struct dev_filter *f)
|
|
{
|
|
if (f->use_count)
|
|
log_error(INTERNAL_ERROR "Destroying partitioned filter while in use %u times.", f->use_count);
|
|
|
|
dm_free(f);
|
|
}
|
|
|
|
struct dev_filter *partitioned_filter_create(struct dev_types *dt)
|
|
{
|
|
struct dev_filter *f;
|
|
|
|
if (!(f = dm_zalloc(sizeof(struct dev_filter)))) {
|
|
log_error("Partitioned filter allocation failed");
|
|
return NULL;
|
|
}
|
|
|
|
f->passes_filter = _passes_partitioned_filter;
|
|
f->destroy = _partitioned_filter_destroy;
|
|
f->use_count = 0;
|
|
f->private = dt;
|
|
|
|
log_debug_devs("Partitioned filter initialised.");
|
|
|
|
return f;
|
|
}
|