mirror of
git://sourceware.org/git/lvm2.git
synced 2024-10-27 18:55:19 +03:00
72b2cb613a
Fix some memory leaks in error paths found by coverity. Use C99 struct initialisers. Move DEFS into configure.h. Clean-ups to remove miscellaneous compiler warnings.
503 lines
12 KiB
C
503 lines
12 KiB
C
/*
|
|
* Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved.
|
|
* Copyright (C) 2004 Red Hat, Inc. All rights reserved.
|
|
*
|
|
* This file is part of LVM2.
|
|
*
|
|
* This copyrighted material is made available to anyone wishing to use,
|
|
* modify, copy, or redistribute it subject to the terms and conditions
|
|
* of the GNU General Public License v.2.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include "tools.h"
|
|
|
|
static int _activate_lvs_in_vg(struct cmd_context *cmd,
|
|
struct volume_group *vg, int activate)
|
|
{
|
|
struct lv_list *lvl;
|
|
struct logical_volume *lv;
|
|
const char *pvname;
|
|
int count = 0;
|
|
|
|
list_iterate_items(lvl, &vg->lvs) {
|
|
lv = lvl->lv;
|
|
|
|
/* Only request activation of snapshot origin devices */
|
|
if ((lv->status & SNAPSHOT) || lv_is_cow(lv))
|
|
continue;
|
|
|
|
/* Can't deactive a pvmove or log LV */
|
|
/* FIXME There needs to be a controlled way of doing this */
|
|
if (((activate == CHANGE_AN) || (activate == CHANGE_ALN)) &&
|
|
((lv->status & PVMOVE) || (lv->status & MIRROR_LOG)))
|
|
continue;
|
|
|
|
if (activate == CHANGE_AN) {
|
|
if (!deactivate_lv(cmd, lv))
|
|
continue;
|
|
} else if (activate == CHANGE_ALN) {
|
|
if (!deactivate_lv_local(cmd, lv))
|
|
continue;
|
|
} else if (lv_is_origin(lv) || (activate == CHANGE_AE)) {
|
|
if (!activate_lv_excl(cmd, lv))
|
|
continue;
|
|
} else if (activate == CHANGE_ALY) {
|
|
if (!activate_lv_local(cmd, lv))
|
|
continue;
|
|
} else if (!activate_lv(cmd, lv))
|
|
continue;
|
|
|
|
if ((lv->status & PVMOVE) &&
|
|
(pvname = get_pvmove_pvname_from_lv_mirr(lv))) {
|
|
log_verbose("Spawning background process for %s %s",
|
|
lv->name, pvname);
|
|
pvmove_poll(cmd, pvname, 1);
|
|
continue;
|
|
}
|
|
|
|
count++;
|
|
}
|
|
|
|
return count;
|
|
}
|
|
|
|
static int _vgchange_available(struct cmd_context *cmd, struct volume_group *vg)
|
|
{
|
|
int lv_open, active;
|
|
int available;
|
|
int activate = 1;
|
|
|
|
available = arg_uint_value(cmd, available_ARG, 0);
|
|
|
|
if ((available == CHANGE_AN) || (available == CHANGE_ALN))
|
|
activate = 0;
|
|
|
|
/* FIXME: Force argument to deactivate them? */
|
|
if (!activate && (lv_open = lvs_in_vg_opened(vg))) {
|
|
log_error("Can't deactivate volume group \"%s\" with %d open "
|
|
"logical volume(s)", vg->name, lv_open);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (activate && lockingfailed() && (vg->status & CLUSTERED)) {
|
|
log_error("Locking inactive: ignoring clustered "
|
|
"volume group %s", vg->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
/* FIXME Move into library where clvmd can use it */
|
|
if (activate && !lockingfailed())
|
|
check_current_backup(vg);
|
|
|
|
if (activate && (active = lvs_in_vg_activated(vg)))
|
|
log_verbose("%d logical volume(s) in volume group \"%s\" "
|
|
"already active", active, vg->name);
|
|
|
|
if (activate && _activate_lvs_in_vg(cmd, vg, available))
|
|
log_verbose("Activated logical volumes in "
|
|
"volume group \"%s\"", vg->name);
|
|
|
|
if (!activate && _activate_lvs_in_vg(cmd, vg, available))
|
|
log_verbose("Deactivated logical volumes in "
|
|
"volume group \"%s\"", vg->name);
|
|
|
|
log_print("%d logical volume(s) in volume group \"%s\" now active",
|
|
lvs_in_vg_activated(vg), vg->name);
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
static int _vgchange_alloc(struct cmd_context *cmd, struct volume_group *vg)
|
|
{
|
|
alloc_policy_t alloc;
|
|
|
|
alloc = arg_uint_value(cmd, alloc_ARG, ALLOC_NORMAL);
|
|
|
|
if (alloc == ALLOC_INHERIT) {
|
|
log_error("Volume Group allocation policy cannot inherit "
|
|
"from anything");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (alloc == vg->alloc) {
|
|
log_error("Volume group allocation policy is already %s",
|
|
get_alloc_string(vg->alloc));
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!archive(vg))
|
|
return ECMD_FAILED;
|
|
|
|
vg->alloc = alloc;
|
|
|
|
if (!vg_write(vg) || !vg_commit(vg))
|
|
return ECMD_FAILED;
|
|
|
|
backup(vg);
|
|
|
|
log_print("Volume group \"%s\" successfully changed", vg->name);
|
|
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
static int _vgchange_resizeable(struct cmd_context *cmd,
|
|
struct volume_group *vg)
|
|
{
|
|
int resizeable = !strcmp(arg_str_value(cmd, resizeable_ARG, "n"), "y");
|
|
|
|
if (resizeable && (vg->status & RESIZEABLE_VG)) {
|
|
log_error("Volume group \"%s\" is already resizeable",
|
|
vg->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!resizeable && !(vg->status & RESIZEABLE_VG)) {
|
|
log_error("Volume group \"%s\" is already not resizeable",
|
|
vg->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!archive(vg))
|
|
return ECMD_FAILED;
|
|
|
|
if (resizeable)
|
|
vg->status |= RESIZEABLE_VG;
|
|
else
|
|
vg->status &= ~RESIZEABLE_VG;
|
|
|
|
if (!vg_write(vg) || !vg_commit(vg))
|
|
return ECMD_FAILED;
|
|
|
|
backup(vg);
|
|
|
|
log_print("Volume group \"%s\" successfully changed", vg->name);
|
|
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
static int _vgchange_clustered(struct cmd_context *cmd,
|
|
struct volume_group *vg)
|
|
{
|
|
int clustered = !strcmp(arg_str_value(cmd, clustered_ARG, "n"), "y");
|
|
struct lv_list *lvl;
|
|
|
|
if (clustered && (vg->status & CLUSTERED)) {
|
|
log_error("Volume group \"%s\" is already clustered",
|
|
vg->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!clustered && !(vg->status & CLUSTERED)) {
|
|
log_error("Volume group \"%s\" is already not clustered",
|
|
vg->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (clustered) {
|
|
list_iterate_items(lvl, &vg->lvs) {
|
|
if (lv_is_origin(lvl->lv) || lv_is_cow(lvl->lv)) {
|
|
log_error("Volume group %s contains snapshots "
|
|
"that are not yet supported.",
|
|
vg->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
}
|
|
}
|
|
|
|
if (!archive(vg))
|
|
return ECMD_FAILED;
|
|
|
|
if (clustered)
|
|
vg->status |= CLUSTERED;
|
|
else
|
|
vg->status &= ~CLUSTERED;
|
|
|
|
if (!vg_write(vg) || !vg_commit(vg))
|
|
return ECMD_FAILED;
|
|
|
|
backup(vg);
|
|
|
|
log_print("Volume group \"%s\" successfully changed", vg->name);
|
|
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
static int _vgchange_logicalvolume(struct cmd_context *cmd,
|
|
struct volume_group *vg)
|
|
{
|
|
uint32_t max_lv = arg_uint_value(cmd, logicalvolume_ARG, 0);
|
|
|
|
if (!(vg->status & RESIZEABLE_VG)) {
|
|
log_error("Volume group \"%s\" must be resizeable "
|
|
"to change MaxLogicalVolume", vg->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!(vg->fid->fmt->features & FMT_UNLIMITED_VOLS)) {
|
|
if (!max_lv)
|
|
max_lv = 255;
|
|
else if (max_lv > 255) {
|
|
log_error("MaxLogicalVolume limit is 255");
|
|
return ECMD_FAILED;
|
|
}
|
|
}
|
|
|
|
if (max_lv && max_lv < vg->lv_count) {
|
|
log_error("MaxLogicalVolume is less than the current number "
|
|
"%d of logical volume(s) for \"%s\"", vg->lv_count,
|
|
vg->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!archive(vg))
|
|
return ECMD_FAILED;
|
|
|
|
vg->max_lv = max_lv;
|
|
|
|
if (!vg_write(vg) || !vg_commit(vg))
|
|
return ECMD_FAILED;
|
|
|
|
backup(vg);
|
|
|
|
log_print("Volume group \"%s\" successfully changed", vg->name);
|
|
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
static int _vgchange_pesize(struct cmd_context *cmd, struct volume_group *vg)
|
|
{
|
|
uint32_t extent_size;
|
|
|
|
if (!(vg->status & RESIZEABLE_VG)) {
|
|
log_error("Volume group \"%s\" must be resizeable "
|
|
"to change PE size", vg->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (arg_sign_value(cmd, physicalextentsize_ARG, 0) == SIGN_MINUS) {
|
|
log_error("Physical extent size may not be negative");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
extent_size = arg_uint_value(cmd, physicalextentsize_ARG, 0) * 2;
|
|
if (!extent_size) {
|
|
log_error("Physical extent size may not be zero");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (extent_size == vg->extent_size) {
|
|
log_error("Physical extent size of VG %s is already %s",
|
|
vg->name, display_size(cmd, (uint64_t) extent_size));
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
if (extent_size & (extent_size - 1)) {
|
|
log_error("Physical extent size must be a power of 2.");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (extent_size > vg->extent_size) {
|
|
if ((uint64_t) vg->extent_size * vg->extent_count % extent_size) {
|
|
/* FIXME Adjust used PV sizes instead */
|
|
log_error("New extent size is not a perfect fit");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
}
|
|
|
|
if (!archive(vg))
|
|
return ECMD_FAILED;
|
|
|
|
if (!vg_change_pesize(cmd, vg, extent_size)) {
|
|
stack;
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!vg_write(vg) || !vg_commit(vg))
|
|
return ECMD_FAILED;
|
|
|
|
backup(vg);
|
|
|
|
log_print("Volume group \"%s\" successfully changed", vg->name);
|
|
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
static int _vgchange_tag(struct cmd_context *cmd, struct volume_group *vg,
|
|
int arg)
|
|
{
|
|
const char *tag;
|
|
|
|
if (!(tag = arg_str_value(cmd, arg, NULL))) {
|
|
log_error("Failed to get tag");
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!(vg->fid->fmt->features & FMT_TAGS)) {
|
|
log_error("Volume group %s does not support tags", vg->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!archive(vg))
|
|
return ECMD_FAILED;
|
|
|
|
if ((arg == addtag_ARG)) {
|
|
if (!str_list_add(cmd->mem, &vg->tags, tag)) {
|
|
log_error("Failed to add tag %s to volume group %s",
|
|
tag, vg->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
} else {
|
|
if (!str_list_del(&vg->tags, tag)) {
|
|
log_error("Failed to remove tag %s from volume group "
|
|
"%s", tag, vg->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
}
|
|
|
|
if (!vg_write(vg) || !vg_commit(vg))
|
|
return ECMD_FAILED;
|
|
|
|
backup(vg);
|
|
|
|
log_print("Volume group \"%s\" successfully changed", vg->name);
|
|
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
static int _vgchange_uuid(struct cmd_context *cmd __attribute((unused)),
|
|
struct volume_group *vg)
|
|
{
|
|
struct lv_list *lvl;
|
|
|
|
if (lvs_in_vg_activated(vg)) {
|
|
log_error("Volume group has active logical volumes");
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!archive(vg))
|
|
return ECMD_FAILED;
|
|
|
|
if (!id_create(&vg->id)) {
|
|
log_error("Failed to generate new random UUID for VG %s.",
|
|
vg->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
list_iterate_items(lvl, &vg->lvs) {
|
|
memcpy(&lvl->lv->lvid, &vg->id, sizeof(vg->id));
|
|
}
|
|
|
|
if (!vg_write(vg) || !vg_commit(vg))
|
|
return ECMD_FAILED;
|
|
|
|
backup(vg);
|
|
|
|
log_print("Volume group \"%s\" successfully changed", vg->name);
|
|
|
|
return ECMD_PROCESSED;
|
|
}
|
|
|
|
static int vgchange_single(struct cmd_context *cmd, const char *vg_name,
|
|
struct volume_group *vg, int consistent,
|
|
void *handle __attribute((unused)))
|
|
{
|
|
int r = ECMD_FAILED;
|
|
|
|
if (!vg) {
|
|
log_error("Unable to find volume group \"%s\"", vg_name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!consistent) {
|
|
unlock_vg(cmd, vg_name);
|
|
dev_close_all();
|
|
log_error("Volume group \"%s\" inconsistent", vg_name);
|
|
if (!(vg = recover_vg(cmd, vg_name, LCK_VG_WRITE)))
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (!(vg->status & LVM_WRITE) && !arg_count(cmd, available_ARG)) {
|
|
log_error("Volume group \"%s\" is read-only", vg->name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (vg->status & EXPORTED_VG) {
|
|
log_error("Volume group \"%s\" is exported", vg_name);
|
|
return ECMD_FAILED;
|
|
}
|
|
|
|
if (arg_count(cmd, available_ARG))
|
|
r = _vgchange_available(cmd, vg);
|
|
|
|
else if (arg_count(cmd, resizeable_ARG))
|
|
r = _vgchange_resizeable(cmd, vg);
|
|
|
|
else if (arg_count(cmd, logicalvolume_ARG))
|
|
r = _vgchange_logicalvolume(cmd, vg);
|
|
|
|
else if (arg_count(cmd, addtag_ARG))
|
|
r = _vgchange_tag(cmd, vg, addtag_ARG);
|
|
|
|
else if (arg_count(cmd, deltag_ARG))
|
|
r = _vgchange_tag(cmd, vg, deltag_ARG);
|
|
|
|
else if (arg_count(cmd, physicalextentsize_ARG))
|
|
r = _vgchange_pesize(cmd, vg);
|
|
|
|
else if (arg_count(cmd, uuid_ARG))
|
|
r = _vgchange_uuid(cmd, vg);
|
|
|
|
else if (arg_count(cmd, alloc_ARG))
|
|
r = _vgchange_alloc(cmd, vg);
|
|
|
|
else if (arg_count(cmd, clustered_ARG))
|
|
r = _vgchange_clustered(cmd, vg);
|
|
|
|
return r;
|
|
}
|
|
|
|
int vgchange(struct cmd_context *cmd, int argc, char **argv)
|
|
{
|
|
if (!
|
|
(arg_count(cmd, available_ARG) + arg_count(cmd, logicalvolume_ARG) +
|
|
arg_count(cmd, resizeable_ARG) + arg_count(cmd, deltag_ARG) +
|
|
arg_count(cmd, addtag_ARG) + arg_count(cmd, uuid_ARG) +
|
|
arg_count(cmd, physicalextentsize_ARG) +
|
|
arg_count(cmd, clustered_ARG) + arg_count(cmd, alloc_ARG))) {
|
|
log_error("One of -a, -c, -l, -s, -x, --uuid, --alloc, --addtag or "
|
|
"--deltag required");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
/* FIXME Cope with several changes at once! */
|
|
if (arg_count(cmd, available_ARG) + arg_count(cmd, logicalvolume_ARG) +
|
|
arg_count(cmd, resizeable_ARG) + arg_count(cmd, deltag_ARG) +
|
|
arg_count(cmd, addtag_ARG) + arg_count(cmd, alloc_ARG) +
|
|
arg_count(cmd, uuid_ARG) + arg_count(cmd, clustered_ARG) +
|
|
arg_count(cmd, physicalextentsize_ARG) > 1) {
|
|
log_error("Only one of -a, -c, -l, -s, -x, --uuid, --alloc, "
|
|
"--addtag or --deltag allowed");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (arg_count(cmd, ignorelockingfailure_ARG) &&
|
|
!arg_count(cmd, available_ARG)) {
|
|
log_error("--ignorelockingfailure only available with -a");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
if (arg_count(cmd, available_ARG) == 1
|
|
&& arg_count(cmd, autobackup_ARG)) {
|
|
log_error("-A option not necessary with -a option");
|
|
return EINVALID_CMD_LINE;
|
|
}
|
|
|
|
return process_each_vg(cmd, argc, argv,
|
|
(arg_count(cmd, available_ARG)) ?
|
|
LCK_VG_READ : LCK_VG_WRITE, 0, NULL,
|
|
&vgchange_single);
|
|
}
|