Peter Rajnoha cf700151eb cache: fix regression causing some PVs to bypass filters ... This is a regression introduced by commit 6c0e44d5a2 which changed the way dev_cache_get fn works - before this patch, when a device was not found, it fired a full rescan to correct the cache. However, the change coming with that commit missed this full_rescan call, causing the lvmcache to still contain info about PVs which should be filtered now. Such situation may have happened by coincidence of using old persistent cache (/etc/lvm/cache/.cache) which does not reflect the actual state anymore, a device name/symlink which now points to a device which should be filtered and a fact we keep info about usable DM devices in .cache no matter what the filter setting is. This bug could be hidden though by changes introduced in commit f1a000a477 as it calls full_rescan earlier before this problem is hit. But we need to fix this anyway for the dev_cache_get to be correct if we happen to use the same code path again somewhere sometime. For example, simple reproducer was (before commit 1a000a477558e157532d5f2cd2f9c9139d4f87c): - /dev/sda contains a PV header with UUID y5PzRD-RBAv-7sBx-V3SP-vDmy-DeSq-GUh65M - lvm.conf: filter = [ "r|.*|" ] - rm -f .cache (to start with clean state) - dmsetup create test --table "0 8388608 linear /dev/sda 0" (8388608 is just the size of the /dev/sda device I use in the reproducer) - pvs (this will create .cache file which contains "/dev/disk/by-id/lvm-pv-uuid-y5PzRD-RBAv-7sBx-V3SP-vDmy-DeSq-GUh65M" as well as "/dev/mapper/test" and the target node "/dev/dm-1" - all the usable DM mappings (and their symlinks) get into the .cache file even though the filter "is set to "ignore all" - we do this - so far it's OK) - dmsetup remove test (so we end up with /dev/disk/by-id/lvm-pv-uuid-... pointing to the /dev/sda now since it's the underlying device containing the actual PV header) - now calling "pvs" with such .cache file and we get: $ pvs PV VG Fmt Attr PSize PFree /dev/disk/by-id/lvm-pv-uuid-y5PzRD-RBAv-7sBx-V3SP-vDmy-DeSq-GUh65M vg lvm2 a-- 4.00g 0 Even though we have set filter = [ "r|.*|" ] in the lvm.conf file!		2015-07-29 10:19:12 +02:00
..
dev-cache.c	cache: fix regression causing some PVs to bypass filters	2015-07-29 10:19:12 +02:00
dev-cache.h	report: select: refactor: move str_list to libdm	2014-06-17 16:27:20 +02:00
dev-ext-udev-constants.h	cleanup: add dev-ext-udev-constants.h with constants/names of the properties/values used from udev db	2015-01-30 13:17:12 +01:00
dev-ext.c	device: add infrastructure to support external device info	2015-01-30 13:01:12 +01:00
dev-io.c	devices: avoid extra open() syscall	2015-03-06 13:17:39 +01:00
dev-luks.c	device: cleanup signature wiping functions	2013-11-27 12:56:58 +01:00
dev-md.c	cleanup: add dev-ext-udev-constants.h with constants/names of the properties/values used from udev db	2015-01-30 13:17:12 +01:00
dev-swap.c	dev-swap: use SECTOR_SHIFT	2014-03-22 20:43:05 +01:00
dev-type.c	wiping: add "Wiping skipped." for the message context to be complete	2015-07-21 11:00:43 +02:00
dev-type.h	filters: no need to refresh filters/rescan if no signature is wiped during pvcreate at all	2015-02-17 09:46:34 +01:00
device-types.h	cleanup: reorder commonly available devs in system to the front	2014-02-24 21:13:35 +01:00
device.h	devices: avoid extra open() syscall	2015-03-06 13:17:39 +01:00