Dave Wysochanski fddc256a02 Check for duplicate paths (pvids) on the commandline of vgcreate. ... A user specifying duplicate paths on the cmdline of vgcreate will get a message similar to the following: vgcreate vgtest2 /dev/loop3 /dev/loop5 Found duplicate PV jk1lXsKzwyOKlXq6bhaFFKMQQ06oPgu8: using /dev/loop5 not /dev/loop3 Found duplicate PV jk1lXsKzwyOKlXq6bhaFFKMQQ06oPgu8: using /dev/loop3 not /dev/loop5 Internal error: Duplicate PV id jk1lXs-Kzwy-OKlX-q6bh-aFFK-MQQ0-6oPgu8 detected for /dev/loop3 in vgtest2. This is caught by vg_validate(), but it would be good to find this condition earlier in the vgcreate code. add_pv_to_vg() currently checks by pvname, but does not look for duplcate pvids. This patch adds the check for duplicate pvids and results in new error output as follows: vgcreate vgtest2 /dev/loop3 /dev/loop5 Found duplicate PV jk1lXsKzwyOKlXq6bhaFFKMQQ06oPgu8: using /dev/loop5 not /dev/loop3 Found duplicate PV jk1lXsKzwyOKlXq6bhaFFKMQQ06oPgu8: using /dev/loop3 not /dev/loop5 Physical volume '/dev/loop5 (jk1lXs-Kzwy-OKlX-q6bh-aFFK-MQQ0-6oPgu8)' listed more than once. Unable to add physical volume '/dev/loop5' to volume group 'vgtest2'. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>		2010-04-08 15:18:35 +00:00
..
activate	Fix incorrect removal of symlinks after LV deactivation fails.	2010-04-07 20:04:41 +00:00
cache	Change most remaining log_error WARNING messages to log_warn.	2010-04-01 10:34:09 +00:00
commands	Change most remaining log_error WARNING messages to log_warn.	2010-04-01 10:34:09 +00:00
config	Change most remaining log_error WARNING messages to log_warn.	2010-04-01 10:34:09 +00:00
datastruct	Remove unnecessary / duplicate dm_list macros and functions.	2009-11-25 20:44:07 +00:00
device	Fix is_partitioned_dev not to attempt to reopen device.	2010-04-06 17:36:41 +00:00
display	Cleanup returns for void functions.	2009-12-11 13:16:37 +00:00
error	Fix last check-ins: seg can be NULL.	2009-02-28 20:04:24 +00:00
filters	Use fixed buffer to prevent stack overflow in persistent filter dump.	2010-01-06 13:25:36 +00:00
format1	Fix pvmove allocation to take existing parallel stripes into account.	2010-04-08 00:28:57 +00:00
format_pool	Fix pvmove allocation to take existing parallel stripes into account.	2010-04-08 00:28:57 +00:00
format_text	Fix pvmove allocation to take existing parallel stripes into account.	2010-04-08 00:28:57 +00:00
freeseg	Fix reporting of LV fields alongside unallocated PV segments.	2008-06-25 16:52:27 +00:00
label	Use log_error macro consistently throughout in place of log_err.	2009-07-15 20:02:46 +00:00
locking	Change most remaining log_error WARNING messages to log_warn.	2010-04-01 10:34:09 +00:00
log	Also honour abort_on_internal_errors when log_fn is set.	2010-03-23 18:18:49 +00:00
metadata	Check for duplicate paths (pvids) on the commandline of vgcreate.	2010-04-08 15:18:35 +00:00
mirror	Use $(top_builddir) for inclusion of make.tmpl in Makefiles.	2010-03-04 09:51:37 +00:00
misc	Autoreconf.	2010-03-23 14:44:42 +00:00
mm	Better debug message for Un/Locked memory size.	2010-04-01 14:53:47 +00:00
report	Use dm_report_field_int32 instead of dm_report_field_uint64 for printing '-1'	2010-02-15 20:27:33 +00:00
snapshot	Use $(top_builddir) for inclusion of make.tmpl in Makefiles.	2010-03-04 09:51:37 +00:00
striped	Use macro outsize() with check for error return value.	2010-01-07 14:46:51 +00:00
unknown	Fix the "const discarded" warnings introduced in the unknown segment patch.	2009-10-22 10:38:07 +00:00
uuid	Use log_error macro consistently throughout in place of log_err.	2009-07-15 20:02:46 +00:00
zero	Attempt to load dm-zero module if zero target needed but not present. (mbroz)	2009-05-27 13:05:53 +00:00
Makefile.in	Fixing another set of distclean problems where we left some generated files	2010-03-29 14:17:59 +00:00