From a59c899ed4369b1836bb1630266cb85d0363c83e Mon Sep 17 00:00:00 2001
From: Jaime Melis <jmelis@opennebula.org>
Date: Fri, 15 Feb 2013 15:58:21 +0100
Subject: [PATCH 1/2] Bug #1521: LVM transfer driver remove persistent LV when
 onevm shutdown

The code in this commit is based on Milos Kozak's patch
---
 src/tm_mad/lvm/delete | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/src/tm_mad/lvm/delete b/src/tm_mad/lvm/delete
index 003cda3d11..f0967d4853 100755
--- a/src/tm_mad/lvm/delete
+++ b/src/tm_mad/lvm/delete
@@ -42,10 +42,22 @@ DST_HOST=`arg_host $DST`
 # Delete the device if it's a clone (LVM snapshot)
 DELETE_CMD=$(cat <<EOF
     DEV=\$(readlink $DST_PATH)
-    $SUDO $LVREMOVE -f \$DEV
+    LV_NAME=\$(basename \$DEV)
 
     # remove link
     rm -f $DST_PATH
+
+    # The following attrs will only be there if the image is non-persistent
+    # lv-one-<image>                 ==> persistent
+    # lv-one-<image>-<vmid>-<diskid> ==> non-persistent (clone)
+
+    VMID=\$(echo \$LV_NAME|cut -d- -f4)
+    DISKID=\$(echo \$LV_NAME|cut -d- -f5)
+
+    if [ -n "\$VMID" -a -n "\$DISKID" ]; then
+        # this is a cloned image
+        $SUDO $LVREMOVE -f \$DEV
+    fi
 EOF
 )
 

From eb612e6c8b47a213ed5581b84c0990b9d56c452f Mon Sep 17 00:00:00 2001
From: Jaime Melis <jmelis@opennebula.org>
Date: Tue, 19 Feb 2013 14:39:05 +0100
Subject: [PATCH 2/2] Bug #1521: Clone LVM instead of doing snapshot

---
 src/mad/sh/scripts_common.sh |  1 +
 src/tm_mad/lvm/clone         | 11 ++++++-----
 src/tm_mad/lvm/mvds          | 13 +++++--------
 3 files changed, 12 insertions(+), 13 deletions(-)

diff --git a/src/mad/sh/scripts_common.sh b/src/mad/sh/scripts_common.sh
index f2dbdc3022..86efa9a7e8 100644
--- a/src/mad/sh/scripts_common.sh
+++ b/src/mad/sh/scripts_common.sh
@@ -28,6 +28,7 @@ GREP=grep
 ISCSIADM=iscsiadm
 LVCREATE=lvcreate
 LVREMOVE=lvremove
+LVRENAME=lvrename
 LVS=lvs
 LN=ln
 MD5SUM=md5sum
diff --git a/src/tm_mad/lvm/clone b/src/tm_mad/lvm/clone
index cf9ef9f9ba..7e30e0d778 100755
--- a/src/tm_mad/lvm/clone
+++ b/src/tm_mad/lvm/clone
@@ -69,8 +69,8 @@ LV_NAME=`echo $SRC_PATH|cut -d. -f2`
 VG_NAME=`echo $SRC_PATH|cut -d. -f1`
 
 TARGET_DEV="/dev/$VG_NAME/$LV_NAME"
-LV_SNAPSHOT="$LV_NAME-$VM_ID-$DISK_ID"
-LV_SNAPSHOT_DEV="/dev/$VG_NAME/$LV_SNAPSHOT"
+LV_CLONE="$LV_NAME-$VM_ID-$DISK_ID"
+LV_CLONE_DEV="/dev/$VG_NAME/$LV_CLONE"
 
 #-------------------------------------------------------------------------------
 # Create the snapshot and link it
@@ -79,11 +79,12 @@ LV_SNAPSHOT_DEV="/dev/$VG_NAME/$LV_SNAPSHOT"
 CLONE_CMD=$(cat <<EOF
     set -e
     mkdir -p $DST_DIR
-    $SUDO $LVCREATE -s -L$SIZE -n $LV_SNAPSHOT $TARGET_DEV
-    ln -s "$LV_SNAPSHOT_DEV" "$DST_PATH"
+    $SUDO $LVCREATE -L$SIZE -n $LV_CLONE $VG_NAME
+    $SUDO $DD if=$TARGET_DEV of=$LV_CLONE_DEV bs=64k
+    ln -s "$LV_CLONE_DEV" "$DST_PATH"
 EOF
 )
 
 ssh_exec_and_log "$DST_HOST" "$CLONE_CMD" \
-        "Error cloning $TARGET_DEV to $LV_SNAPSHOT_DEV"
+        "Error cloning $TARGET_DEV to $LV_CLONE_DEV"
 exit 0
diff --git a/src/tm_mad/lvm/mvds b/src/tm_mad/lvm/mvds
index 0bb018b343..6a7746e78f 100755
--- a/src/tm_mad/lvm/mvds
+++ b/src/tm_mad/lvm/mvds
@@ -33,7 +33,10 @@ else
     TMCOMMON=$ONE_LOCATION/var/remotes/tm/tm_common.sh
 fi
 
-. $TMCOMMON
+DRIVER_PATH=$(dirname $0)
+
+source $TMCOMMON
+source ${DRIVER_PATH}/../../datastore/lvm/lvm.conf
 
 #-------------------------------------------------------------------------------
 # Set dst path and dir
@@ -55,14 +58,8 @@ DUMP_CMD=$(cat <<EOF
     VM=\$(echo \$LV|cut -d- -f4)
     DISK_ID=\$(echo \$LV|cut -d- -f5)
 
-    SOURCE_DEV=\$(echo \$DEV|sed 's/-[0-9]*-[0-9]*$//')
-    SIZE=\$($SUDO $LVS \$SOURCE_DEV --noheadings|awk '{print \$4}'|tr -d m)
-
-    $SUDO $LVCREATE -L\${SIZE}M ${VG_NAME} -n ${LV_NAME}
-    $SUDO $DD if=$SRC_PATH of=$TARGET_DEV bs=64k
-
     if [ -n "\$VM" -a -n "\$DISK_ID" ]; then
-        $SUDO $LVREMOVE -f \$DEV
+        $SUDO $LVRENAME ${VG_NAME} \${LV} ${LV_NAME}
     fi
 EOF
 )