F #5564: Manage Libvirtd failure at VM monitoring (#1628)

src/im_mad/remotes/kvm-probes.d/host/system/wild_vm.rb

@@ -4,4 +4,9 @@ require_relative '../../../lib/kvm'
 
 KVM.load_conf
 
-puts DomainList.wilds_info
+begin
+    puts DomainList.info
+rescue StandardError => e
+    STDERR.puts e.message
+    exit(-1)
+end

src/im_mad/remotes/kvm-probes.d/vm/monitor/poll.rb

@@ -4,4 +4,9 @@ require_relative '../../../lib/kvm'
 
 KVM.load_conf
 
-puts DomainList.info
+begin
+    puts DomainList.info
+rescue StandardError => e
+    STDERR.puts e.message
+    exit(-1)
+end

src/im_mad/remotes/kvm-probes.d/vm/status/state.rb

@@ -26,5 +26,6 @@ begin
 
     puts vmdb.to_status
 rescue StandardError => e
-    puts e
+    STDERR.puts e.message
+    exit(-1)
 end

src/im_mad/remotes/lib/kvm.rb

@@ -89,15 +89,18 @@ module ProcessList
 
     def self.retrieve_names
         text, _e, s = KVM.virsh(:list, '')
-        names = []
 
-        return names if s.exitstatus != 0
+        if s.exitstatus != 0
+            raise 'Error retrieving names. Check Libvirtd service is up.'
+        end
 
         lines = text.split(/\n/)[2..-1]
 
+        # rubocop:disable Style/RedundantAssignment
         names = lines.map do |line|
             line.split(/\s+/).delete_if {|d| d.empty? }[1]
         end
+        # rubocop:enable Style/RedundantAssignment
 
         names
     end

src/monitor/src/monitor/MonitorDriverProtocol.cc

@@ -69,7 +69,6 @@ void MonitorDriverProtocol::_monitor_vm(unique_ptr<monitor_msg_t> msg)
         NebulaLog::warn("MDP", "Failed to monitor VM for host " +
             to_string(msg->oid()) + ": " + msg->payload());
 
-        hm->error_monitor(msg->oid(), msg->payload());
         return;
     }
 
@@ -269,7 +268,6 @@ void MonitorDriverProtocol::_state_vm(unique_ptr<monitor_msg_t> msg)
         NebulaLog::warn("MDP", "Failed to monitor VM state for host " +
             to_string(msg->oid()) + ": " + msg->payload());
 
-        hm->error_monitor(msg->oid(), msg->payload());
         return;
     }