From 163d900e63324a371708dc2854f237758a08d204 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christian=20Gonz=C3=A1lez?= <cgonzalez@opennebula.io>
Date: Tue, 12 Apr 2022 17:33:21 +0200
Subject: [PATCH] B #5765: Fix local monitoring (.monitor) (#1937)

---
 src/mad/sh/scripts_common.sh | 69 +++++++++++++++++++++++++++---------
 src/tm_mad/ceph/clone        |  2 ++
 src/tm_mad/ceph/clone.ssh    |  3 +-
 src/tm_mad/ceph/ln.ssh       |  3 +-
 src/tm_mad/fs_lvm/clone      |  2 ++
 src/tm_mad/fs_lvm_ssh/clone  |  2 ++
 src/tm_mad/qcow2/clone       |  1 +
 src/tm_mad/qcow2/clone.ssh   |  3 +-
 src/tm_mad/qcow2/ln.ssh      |  3 +-
 src/tm_mad/ssh/clone         |  3 +-
 src/tm_mad/ssh/clone.replica |  5 +--
 src/tm_mad/ssh/mv            |  3 +-
 12 files changed, 74 insertions(+), 25 deletions(-)

diff --git a/src/mad/sh/scripts_common.sh b/src/mad/sh/scripts_common.sh
index a13f160c6f..43039be15c 100644
--- a/src/mad/sh/scripts_common.sh
+++ b/src/mad/sh/scripts_common.sh
@@ -577,23 +577,6 @@ set -e -o pipefail
 if [ ! -d $2 ]; then
     mkdir -p $2
 fi
-
-MONITOR_FN="\$(dirname $2)/.monitor"
-
-# create or update .monitor content
-if [ -n "$3" ]; then
-    MONITOR=''
-    if [ -f "\\${MONITOR_FN}" ]; then
-        MONITOR="\\$(cat "\\${MONITOR_FN}" 2>/dev/null)"
-    fi
-
-    if [ "x\\${MONITOR}" != "x$3" ]; then
-        echo "$3" > "\\${MONITOR_FN}"
-    fi
-else
-    # remove .monitor file (to avoid errors on driver change)
-    rm -f "\\${MONITOR_FN}"
-fi
 EOF`
     SSH_EXEC_RC=$?
 
@@ -604,6 +587,58 @@ EOF`
     fi
 }
 
+# Enables local monitoring for host $2 and DS $1, by creating the corresponding
+# .monitor file containing the $3 ( the driver name) (e.g ssh)
+function enable_local_monitoring
+{
+    SSH_EXEC_ERR=`$SSH $1 bash -s 2>&1 1>/dev/null <<EOF
+set -e -o pipefail
+
+MONITOR_FN="\$(dirname $2)/.monitor"
+
+# create or update .monitor content
+MONITOR=''
+if [ -f "\\${MONITOR_FN}" ]; then
+    MONITOR="\\$(cat "\\${MONITOR_FN}" 2>/dev/null)"
+fi
+
+if [ "x\\${MONITOR}" != "x$3" ]; then
+    echo "$3" > "\\${MONITOR_FN}"
+fi
+EOF`
+
+    SSH_EXEC_RC=$?
+
+    if [ $SSH_EXEC_RC -ne 0 ]; then
+        error_message "Error creating $2/.monitor at $1: $SSH_EXEC_ERR"
+
+        exit $SSH_EXEC_RC
+    fi
+}
+
+# Disables local monitoring for host $2 and DS $1, by removing the corresponding
+# .monitor file
+function disable_local_monitoring
+{
+    SSH_EXEC_ERR=`$SSH $1 bash -s 2>&1 1>/dev/null <<EOF
+set -e -o pipefail
+
+MONITOR_FN="\$(dirname $2)/.monitor"
+
+# remove .monitor file
+rm -f "\\${MONITOR_FN}"
+
+EOF`
+
+    SSH_EXEC_RC=$?
+
+    if [ $SSH_EXEC_RC -ne 0 ]; then
+        error_message "Error creating $2/.monitor at $1: $SSH_EXEC_ERR"
+
+        exit $SSH_EXEC_RC
+    fi
+}
+
 # Escape characters which could be interpreted as XML markup
 function xml_esc
 {
diff --git a/src/tm_mad/ceph/clone b/src/tm_mad/ceph/clone
index 18394231ab..0f10416c75 100755
--- a/src/tm_mad/ceph/clone
+++ b/src/tm_mad/ceph/clone
@@ -95,6 +95,8 @@ done < <(onedatastore show -x $DST_DS_ID | $XPATH \
 
 EC_POOL_NAME="${XPATH_ELEMENTS[j++]}"
 
+disable_local_monitoring $DST_HOST $DST_DIR
+
 #-------------------------------------------------------------------------------
 # Clone the image and create @snap if it does not exists
 #-------------------------------------------------------------------------------
diff --git a/src/tm_mad/ceph/clone.ssh b/src/tm_mad/ceph/clone.ssh
index efb65cc434..34709095bf 100755
--- a/src/tm_mad/ceph/clone.ssh
+++ b/src/tm_mad/ceph/clone.ssh
@@ -98,7 +98,8 @@ if [ -n "$CEPH_CONF" ]; then
 fi
 
 
-ssh_make_path $DST_HOST $DST_DIR 'ssh'
+ssh_make_path $DST_HOST $DST_DIR
+enable_local_monitoring $DST_HOST $DST_DIR 'ssh'
 
 CLONE_CMD=$(cat <<EOF
     RBD="${RBD}"
diff --git a/src/tm_mad/ceph/ln.ssh b/src/tm_mad/ceph/ln.ssh
index 84aca46373..a0c7868046 100755
--- a/src/tm_mad/ceph/ln.ssh
+++ b/src/tm_mad/ceph/ln.ssh
@@ -91,7 +91,8 @@ if [ -n "$CEPH_CONF" ]; then
     RBD="$RBD --conf ${CEPH_CONF}"
 fi
 
-ssh_make_path $DST_HOST $DST_DIR 'ssh'
+ssh_make_path $DST_HOST $DST_DIR
+enable_local_monitoring $DST_HOST $DST_DIR 'ssh'
 
 LN_CMD=$(cat <<EOF
     RBD="${RBD}"
diff --git a/src/tm_mad/fs_lvm/clone b/src/tm_mad/fs_lvm/clone
index cb97aae289..f10010152e 100755
--- a/src/tm_mad/fs_lvm/clone
+++ b/src/tm_mad/fs_lvm/clone
@@ -56,6 +56,8 @@ SRC_PATH="${DST_DS_PATH}${SRC_ARG_PATH##$SRC_DS_PATH}"
 
 DS_SYS_ID=$(echo $DST_DIR | $AWK -F '/' '{print $(NF-1)}')
 
+disable_local_monitoring $DST_HOST $DST_DIR
+
 #-------------------------------------------------------------------------------
 # Get Image information
 #-------------------------------------------------------------------------------
diff --git a/src/tm_mad/fs_lvm_ssh/clone b/src/tm_mad/fs_lvm_ssh/clone
index f286504f02..20dc0a98ca 100755
--- a/src/tm_mad/fs_lvm_ssh/clone
+++ b/src/tm_mad/fs_lvm_ssh/clone
@@ -58,6 +58,8 @@ SRC_HOST=`arg_host $SRC`
 
 DS_SYS_ID=$(echo $DST_DIR | $AWK -F '/' '{print $(NF-1)}')
 
+disable_local_monitoring $DST_HOST $DST_DIR
+
 #-------------------------------------------------------------------------------
 # Get Image information
 #-------------------------------------------------------------------------------
diff --git a/src/tm_mad/qcow2/clone b/src/tm_mad/qcow2/clone
index 300369003b..19a5bbbb1d 100755
--- a/src/tm_mad/qcow2/clone
+++ b/src/tm_mad/qcow2/clone
@@ -74,6 +74,7 @@ FORMAT="${XPATH_ELEMENTS[j++]}"
 ORIGINAL_SIZE="${XPATH_ELEMENTS[j++]}"
 
 ssh_make_path $DST_HOST $DST_DIR
+disable_local_monitoring $DST_HOST $DST_DIR
 
 #-------------------------------------------------------------------------------
 # Clone (cp) SRC into DST
diff --git a/src/tm_mad/qcow2/clone.ssh b/src/tm_mad/qcow2/clone.ssh
index 98a7c4c7a3..39816140b9 100755
--- a/src/tm_mad/qcow2/clone.ssh
+++ b/src/tm_mad/qcow2/clone.ssh
@@ -48,7 +48,8 @@ DST_PATH=$(arg_path $DST)
 DST_HOST=$(arg_host $DST)
 DST_DIR=$(dirname $DST_PATH)
 
-ssh_make_path $DST_HOST $DST_DIR "ssh"
+ssh_make_path $DST_HOST $DST_DIR
+enable_local_monitoring $DST_HOST $DST_DIR "ssh"
 
 #-------------------------------------------------------------------------------
 # Get Image information
diff --git a/src/tm_mad/qcow2/ln.ssh b/src/tm_mad/qcow2/ln.ssh
index 4ba000eb4a..639b6f0281 100755
--- a/src/tm_mad/qcow2/ln.ssh
+++ b/src/tm_mad/qcow2/ln.ssh
@@ -56,7 +56,8 @@ SRC_FORMAT=$(image_format "$SRC_PATH")
 # Create DST path
 #-------------------------------------------------------------------------------
 
-ssh_make_path $DST_HOST $DST_DIR 'ssh'
+ssh_make_path $DST_HOST $DST_DIR
+enable_local_monitoring $DST_HOST $DST_DIR "ssh"
 
 #-------------------------------------------------------------------------------
 # Copy SRC into DST
diff --git a/src/tm_mad/ssh/clone b/src/tm_mad/ssh/clone
index 37b46d3f59..9b9ffde590 100755
--- a/src/tm_mad/ssh/clone
+++ b/src/tm_mad/ssh/clone
@@ -63,7 +63,8 @@ DST_FILE="$(basename $DST_PATH)"
 SRC_DIR="$(dirname $SRC_PATH)"
 DST_DIR="$(dirname $DST_PATH)"
 
-ssh_make_path $DST_HOST $DST_DIR "ssh"
+ssh_make_path $DST_HOST $DST_DIR
+enable_local_monitoring $DST_HOST $DST_DIR "ssh"
 
 #-------------------------------------------------------------------------------
 # Get Image information
diff --git a/src/tm_mad/ssh/clone.replica b/src/tm_mad/ssh/clone.replica
index 091cb6223c..da9d53835c 100755
--- a/src/tm_mad/ssh/clone.replica
+++ b/src/tm_mad/ssh/clone.replica
@@ -97,9 +97,10 @@ if [ -z "$REPLICA_HOST" ]; then
 fi
 
 #-------------------------------------------------------------------------------
-# Create DST path
+# Create DST path and enable local monitoring
 #-------------------------------------------------------------------------------
-ssh_make_path $DST_HOST $DST_DIR "ssh"
+ssh_make_path $DST_HOST $DST_DIR
+enable_local_monitoring $DST_HOST $DST_DIR "ssh"
 
 # ------------------------------------------------------------------------------
 # Get REPLICA_STORAGE_IP from host template
diff --git a/src/tm_mad/ssh/mv b/src/tm_mad/ssh/mv
index 0d0d57a837..dff90a43c1 100755
--- a/src/tm_mad/ssh/mv
+++ b/src/tm_mad/ssh/mv
@@ -79,7 +79,8 @@ EOF
 
 MONITOR=$(ssh_monitor_and_log "$SRC_HOST" "$MONITOR_CMD" 'Get .monitor')
 
-ssh_make_path "$DST_HOST" "$DST_PATH" "$MONITOR"
+ssh_make_path $DST_HOST $DST_DIR
+enable_local_monitoring $DST_HOST $DST_DIR "$MONITOR"
 
 RANDOM_FILE=$(ssh "$DST_HOST" "mktemp -p \"$DST_DIR\"")
 trap "ssh $DST_HOST \"rm -f $RANDOM_FILE\"" EXIT