From 17d20ec6c26c0ecb4676ad269ba3d491fef228fe Mon Sep 17 00:00:00 2001 From: Jaime Melis Date: Tue, 9 Dec 2014 11:01:08 +0100 Subject: [PATCH] Feature #3175: Rewrite the security_groups post script to handle the errors better. --- src/vnm_mad/remotes/security_groups/post | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/vnm_mad/remotes/security_groups/post b/src/vnm_mad/remotes/security_groups/post index 1dd12016e5..1186b997ef 100755 --- a/src/vnm_mad/remotes/security_groups/post +++ b/src/vnm_mad/remotes/security_groups/post @@ -26,21 +26,27 @@ template64 = ARGV[0] deploy_id = ARGV[1] sg = OpenNebulaSG.from_base64(template64, deploy_id) - begin sg.activate rescue OpenNebulaSGError => e - OpenNebula.log_error(e.error.message) + error = e.error + stage = e.stage - case e.stage + OpenNebula.log_error(error.message) + OpenNebula.log_error(error.backtrace) + + case stage when :bootstrap, :security_groups OpenNebula.log_info("Deactivating security groups for #{deploy_id}.") + sg.deactivate when :deactivate OpenNebula.log_error("Error deactivating security group rules for #{deploy_id}. Please verify manually.") end exit 1 -rescue Exception => e - OpenNebula.log_error(e.message) + +rescue Exception => error + OpenNebula.log_error(error.message) + OpenNebula.log_error(error.backtrace) exit 1 end