From 1e237cb3a1e9d91f2f28307fc0cf71d24b0730a2 Mon Sep 17 00:00:00 2001 From: Sergio Betanzos Date: Fri, 3 Jul 2020 15:10:00 +0200 Subject: [PATCH] M #~: Fix lgtm alerts (#76) --- src/sunstone/public/app/login.js | 2 +- src/sunstone/public/app/sunstone-config.js | 4 ---- src/sunstone/public/app/tabs/hosts-tab/panels/monitor.js | 1 - src/sunstone/public/app/utils/browser-info.js | 2 +- 4 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/sunstone/public/app/login.js b/src/sunstone/public/app/login.js index 7104778500..3a22aaefbc 100644 --- a/src/sunstone/public/app/login.js +++ b/src/sunstone/public/app/login.js @@ -146,7 +146,7 @@ define(function(require) { var rv = -1; // Return value assumes failure. if (navigator.appName == 'Microsoft Internet Explorer') { var ua = navigator.userAgent; - var re = new RegExp("MSIE ([0-9]{1,}[\.0-9]{0,})"); + var re = new RegExp("MSIE ([0-9]{1,}[.0-9]{0,})"); if (re.exec(ua) != null) rv = parseFloat(RegExp.$1); } diff --git a/src/sunstone/public/app/sunstone-config.js b/src/sunstone/public/app/sunstone-config.js index 73960b8653..e33c59cc62 100644 --- a/src/sunstone/public/app/sunstone-config.js +++ b/src/sunstone/public/app/sunstone-config.js @@ -132,10 +132,6 @@ define(function(require) { } }, - "tableOrder": function() { - return _config["user_config"]["table_order"]; - }, - "provision": { "dashboard": { "isEnabled": function(widget) { diff --git a/src/sunstone/public/app/tabs/hosts-tab/panels/monitor.js b/src/sunstone/public/app/tabs/hosts-tab/panels/monitor.js index e348015292..edc4e65e3d 100644 --- a/src/sunstone/public/app/tabs/hosts-tab/panels/monitor.js +++ b/src/sunstone/public/app/tabs/hosts-tab/panels/monitor.js @@ -91,7 +91,6 @@ define(function(require) { { monitor_resources : "CAPACITY/USED_MEMORY,CAPACITY/FREE_MEMORY", labels : Locale.tr("Used MEMORY") + "," + Locale.tr("Free MEMORY"), - humanize_figures : false, humanize_figures : true, div_graph : $("#host_mem_graph"), div_legend : $("#host_mem_legend") diff --git a/src/sunstone/public/app/utils/browser-info.js b/src/sunstone/public/app/utils/browser-info.js index 0b80cc1c7a..c32dc653dd 100644 --- a/src/sunstone/public/app/utils/browser-info.js +++ b/src/sunstone/public/app/utils/browser-info.js @@ -25,7 +25,7 @@ define(function(require) { var rv = -1; // Return value assumes failure. if (navigator.appName == 'Microsoft Internet Explorer') { var ua = navigator.userAgent; - var re = new RegExp("MSIE ([0-9]{1,}[\.0-9]{0,})"); + var re = new RegExp("MSIE ([0-9]{1,}[.0-9]{0,})"); if (re.exec(ua) != null) rv = parseFloat(RegExp.$1); }