From 3297dd48fc441985fe502b214cbbc30c2c4a5f64 Mon Sep 17 00:00:00 2001 From: Alejandro Huertas Herrero Date: Wed, 27 Feb 2019 17:32:33 +0100 Subject: [PATCH] B #2964: Fix bug and add rescue to control exceptions (#2996) --- src/oneprovision/lib/ansible.rb | 2 ++ src/oneprovision/lib/oneprovision.rb | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/oneprovision/lib/ansible.rb b/src/oneprovision/lib/ansible.rb index 7efc6affe5..a76cd331fd 100644 --- a/src/oneprovision/lib/ansible.rb +++ b/src/oneprovision/lib/ansible.rb @@ -149,6 +149,8 @@ module OneProvision raise OneProvisionLoopException, errors end + rescue StandardError + raise OneProvisionLoopException end # Retries ssh connection diff --git a/src/oneprovision/lib/oneprovision.rb b/src/oneprovision/lib/oneprovision.rb index 4cc7b72291..9f04bf9db1 100644 --- a/src/oneprovision/lib/oneprovision.rb +++ b/src/oneprovision/lib/oneprovision.rb @@ -115,13 +115,17 @@ module OneProvision instance.run_mode[:fail_choice] = :cleanup elsif options.key? :fail_retry instance.run_mode[:fail_choice] = :retry - instance.run_mode[:max_retries] = options[:fail_retry].to_i elsif options.key? :fail_skip instance.run_mode[:fail_choice] = :skip elsif options.key? :fail_quit instance.run_mode[:fail_choice] = :quit else instance.run_mode[:fail_choice] = FAIL_CHOICE_DEFAULT + end + + if options[:fail_retry] + instance.run_mode[:max_retries] = options[:fail_retry].to_i + else instance.run_mode[:max_retries] = MAX_RETRIES_DEFAULT end