Bug #4198: oneflow tabs use an inconsistent tab-id

src/sunstone/etc/sunstone-views/admin.yaml

@@ -21,7 +21,7 @@ enabled_tabs:
     - secgroups-tab
     - vrouters-tab
     - zones-tab
-    - oneflow-dashboard
+    - oneflow-dashboard-tab
     - oneflow-services-tab
     - oneflow-templates-tab
     - marketplaces-tab
@@ -470,11 +470,11 @@ tabs:
             VirtualRouter.delete: true
             VirtualRouter.attachnic: true
             VirtualRouter.detachnic: true
-    oneflow-dashboard:
+    oneflow-dashboard-tab:
         panel_tabs:
         table_columns:
         actions:
-    oneflow-services:
+    oneflow-services-tab:
         panel_tabs:
             service_info_tab: true
             service_roles_tab: true
@@ -529,7 +529,7 @@ tabs:
             Service.shutdown: true
             Service.recover: true
             Service.delete: true
-    oneflow-templates:
+    oneflow-templates-tab:
         panel_tabs:
             service_template_info_tab: true
             service_template_roles_tab: true

src/sunstone/etc/sunstone-views/admin_vcenter.yaml

@@ -20,7 +20,7 @@ enabled_tabs:
     #- secgroups-tab
     - vrouters-tab
     - zones-tab
-    - oneflow-dashboard
+    - oneflow-dashboard-tab
     - oneflow-services-tab
     - oneflow-templates-tab
     - settings-tab
@@ -461,11 +461,11 @@ tabs:
             VirtualRouter.delete: true
             VirtualRouter.attachnic: true
             VirtualRouter.detachnic: true
-    oneflow-dashboard:
+    oneflow-dashboard-tab:
         panel_tabs:
         table_columns:
         actions:
-    oneflow-services:
+    oneflow-services-tab:
         panel_tabs:
             service_info_tab: true
             service_roles_tab: true
@@ -520,7 +520,7 @@ tabs:
             Service.shutdown: true
             Service.recover: true
             Service.delete: true
-    oneflow-templates:
+    oneflow-templates-tab:
         panel_tabs:
             service_template_info_tab: true
             service_template_roles_tab: true

src/sunstone/etc/sunstone-views/user.yaml

@@ -20,7 +20,7 @@ enabled_tabs:
     - secgroups-tab
     - vrouters-tab
     #- zones-tab
-    - oneflow-dashboard
+    - oneflow-dashboard-tab
     - oneflow-services-tab
     - oneflow-templates-tab
     - marketplaces-tab
@@ -465,11 +465,11 @@ tabs:
             VirtualRouter.delete: true
             VirtualRouter.attachnic: true
             VirtualRouter.detachnic: true
-    oneflow-dashboard:
+    oneflow-dashboard-tab:
         panel_tabs:
         table_columns:
         actions:
-    oneflow-services:
+    oneflow-services-tab:
         panel_tabs:
             service_info_tab: true
             service_roles_tab: true
@@ -524,7 +524,7 @@ tabs:
             Service.shutdown: true
             Service.recover: true
             Service.delete: true
-    oneflow-templates:
+    oneflow-templates-tab:
         panel_tabs:
             service_template_info_tab: true
             service_template_roles_tab: true

src/sunstone/public/app/main.js

@@ -139,7 +139,7 @@ require.config({
         'tabs/secgroups-tab',
         'tabs/vrouters-tab',
         'tabs/zones-tab',
-        'tabs/oneflow-dashboard',
+        'tabs/oneflow-dashboard-tab',
         'tabs/oneflow-services-tab',
         'tabs/oneflow-templates-tab',
         'tabs/marketplaces-tab',

src/sunstone/public/app/tabs/oneflow-dashboard.js

@@ -15,7 +15,7 @@
 /* -------------------------------------------------------------------------- */
 
 define(function(require) {
-  var TAB_ID = 'oneflow-dashboard';
+  var TAB_ID = 'oneflow-dashboard-tab';
 
   var Tab = {
     tabId: TAB_ID,

src/sunstone/public/app/tabs/oneflow-services-tab.js

@@ -45,7 +45,7 @@ define(function(require) {
     tabId: TAB_ID,
     title: Locale.tr("Services"),
     tabClass: "subTab",
-    parentTab: "oneflow-dashboard",
+    parentTab: "oneflow-dashboard-tab",
     listHeader: '<i class="fa fa-fw fa-cubes"></i>&emsp;'+Locale.tr("OneFlow - Services"),
     infoHeader: '<i class="fa fa-fw fa-cubes"></i>&emsp;'+Locale.tr("OneFlow - Service"),
     subheader: '',

src/sunstone/public/app/tabs/oneflow-services-tab/panels/roles.js

@@ -187,7 +187,7 @@ define(function(require) {
 
       this.servicerolesDataTable.initialize();
 
-      Sunstone.insertButtonsInTab("oneflow-services", "service_roles_tab", roles_buttons, $('#role_actions', context));
+      Sunstone.insertButtonsInTab(TAB_ID, "service_roles_tab", roles_buttons, $('#role_actions', context));
     }
   }
 
@@ -299,7 +299,7 @@ define(function(require) {
 
       this.serviceroleVMsDataTable.initialize();
       Sunstone.insertButtonsInTab(
-        "oneflow-services",
+        TAB_ID,
         "service_roles_tab",
         roles_vm_buttons,
         $('div#role_vms_actions', context));

src/sunstone/public/app/tabs/oneflow-services-tab/tabId.js

@@ -15,5 +15,5 @@
 /* -------------------------------------------------------------------------- */
 
 define(function(require){
-  return 'oneflow-services';
+  return 'oneflow-services-tab';
 });

src/sunstone/public/app/tabs/oneflow-templates-tab.js

@@ -46,7 +46,7 @@ define(function(require) {
     tabId: TAB_ID,
     title: Locale.tr("Templates"),
     tabClass: "subTab",
-    parentTab: "oneflow-dashboard",
+    parentTab: "oneflow-dashboard-tab",
     listHeader: '<i class="fa fa-fw fa-file-o"></i>&emsp;'+Locale.tr("OneFlow - Templates"),
     infoHeader: '<i class="fa fa-fw fa-file-o"></i>&emsp;'+Locale.tr("OneFlow - Template"),
     subheader: '',

src/sunstone/public/app/tabs/oneflow-templates-tab/tabId.js

@@ -15,5 +15,5 @@
 /* -------------------------------------------------------------------------- */
 
 define(function(require){
-  return 'oneflow-templates';
+  return 'oneflow-templates-tab';
 });