B #5790: onevm disk-saveas can use snapshot name (#2148)

src/cli/one_helper/onevm_helper.rb

@@ -297,7 +297,7 @@ class OneVMHelper < OpenNebulaHelper::OneHelper
         vm.info
         ids = vm.retrieve_elements("/VM/SNAPSHOTS/SNAPSHOT[NAME='#{id}']/ID")
 
-        return [-1, "#{id} not found or duplicated"] \
+        return [-1, "Snapshot #{id} not found or duplicated"] \
                 if ids.nil? || ids.size > 1
 
         [0, ids[0].to_i]

src/cli/onevm

@@ -472,7 +472,13 @@ CommandParser::CmdParser.new(ARGV) do
             verbose = "disk #{disk_id} prepared to be saved in " \
                       "the image #{image_name}"
         else
-            snapshot_id = snapshot_id.to_i
+            err, snapshot_id = helper.retrieve_disk_snapshot_id(args[0],
+                                                                snapshot_id)
+
+            if err == -1
+                STDERR.puts snapshot_id
+                exit(-1)
+            end
 
             verbose = "disk #{disk_id} snapshot #{snapshot_id} prepared to " \
                       "be saved in the image #{image_name}"

src/dm/DispatchManagerActions.cc

@@ -2016,7 +2016,7 @@ int DispatchManager::disk_snapshot_revert(int vid, int did, int snap_id,
     if (vm->set_snapshot_disk(did, snap_id) == -1)
     {
         oss << "Disk id (" << did << ") or snapshot id ("
-            << snap_id << ") is not invalid.";
+            << snap_id << ") is not valid.";
 
         error_str = oss.str();