shaba/one
1
0
Fork 0
mirror of https://github.com/OpenNebula/one.git synced 2025-01-20 14:03:36 +03:00
Code Releases Wiki Activity

F OpenNebula/one#6712: Add extra check for a hostname (#3276)

Browse Source 
Changes have been made according to RFC 1034.
http://www.faqs.org/rfcs/rfc1034.html (Sections 3.1. Name space specifications and terminology)
This commit is contained in:
Valentyn Bohdan 2024-11-04 14:19:38 +01:00 committed by GitHub
parent bfb6ff386a
commit 5fa479c5d3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 48 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
src/host/HostPool.cc
View File

@ -32,6 +32,53 @@
using namespace std;
// Reference
// https://learn.microsoft.com/en-us/troubleshoot/windows-server/active-directory/naming-conventions-for-computer-domain-site-ou
static bool hostname_is_valid(const string& hostname, string& error_str)
{
if (hostname.size() < 2 || hostname.size() > 63)
{
error_str = "Invalid HOSTNAME, HOSTNAME length should be greater than 1, but smaller than 64 characters";
return false;
}
const auto firstChar = hostname.front();
if (firstChar == '-' || firstChar == '.' || firstChar == '_')
{
std::stringstream ss;
ss << "Invalid HOSTNAME, first character can't be '" << firstChar << "'";
error_str = ss.str();
return false;
}
for (const auto ch : hostname)
{
if (!std::isalnum(ch) && ch != '-' && ch != '.' && ch != '_')
{
std::stringstream ss;
ss << "Invalid HOSTNAME, '" << ch << "' is invalid character for a HOSTNAME";
error_str = ss.str();
return false;
}
}
const auto lastChar = hostname.back();
if (lastChar == '-' || lastChar == '.' || lastChar == '_')
{
std::stringstream ss;
ss << "Invalid HOSTNAME, last character can't be '" << lastChar << "'";
error_str = ss.str();
return false;
}
return true;
}
/* -------------------------------------------------------------------------- */
/* -------------------------------------------------------------------------- */
@ -58,7 +105,7 @@ int HostPool::allocate (
int db_oid;
if ( !PoolObjectSQL::name_is_valid(hostname, error_str) )
if ( !hostname_is_valid(hostname, error_str) || !PoolObjectSQL::name_is_valid(hostname, error_str) )
{
goto error_name;
}