From 82fd8177ba5d35c76f0e93630a38901b3587e145 Mon Sep 17 00:00:00 2001
From: Tino Vazquez <cvazquez@opennebula.io>
Date: Thu, 13 May 2021 19:20:26 +0200
Subject: [PATCH] L #-: Disable new rubocop checks

Lint vCenter related files
---
 share/linters/.rubocop.yml            | 9 +++++++++
 src/cli/onevcenter                    | 2 +-
 src/vnm_mad/remotes/vcenter/clean     | 2 +-
 src/vnm_mad/remotes/vcenter/post      | 2 +-
 src/vnm_mad/remotes/vcenter/update_sg | 2 +-
 5 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/share/linters/.rubocop.yml b/share/linters/.rubocop.yml
index 841affe550..44500544fe 100644
--- a/share/linters/.rubocop.yml
+++ b/share/linters/.rubocop.yml
@@ -748,6 +748,12 @@ Style/SwapValues:
 # LINT
 ######
 
+Lint/IneffectiveAccessModifier:
+    Enabled: false
+
+Lint/OrAssignmentToConstant:
+    Enabled: false
+
 Lint/ConstantDefinitionInBlock:
     Enabled: false
 
@@ -908,6 +914,9 @@ Metrics/AbcSize:
 Metrics/MethodLength:
   Enabled: false
 
+Naming/VariableName:
+    Enabled: false
+
 # uppercase constant mandatory
 Naming/ConstantName:
     Enabled: true
diff --git a/src/cli/onevcenter b/src/cli/onevcenter
index 41dab12b78..1e53899384 100755
--- a/src/cli/onevcenter
+++ b/src/cli/onevcenter
@@ -272,7 +272,7 @@ CommandParser::CmdParser.new(ARGV) do
                                                            vi_client,
                                                            options[:object])
 
-            if options[:object] == "networks" && !args.first.nil?
+            if options[:object] == 'networks' && !args.first.nil?
                 indexes = args.first
             else
                 importer.retrieve_resources(helper.parse_opts(options))
diff --git a/src/vnm_mad/remotes/vcenter/clean b/src/vnm_mad/remotes/vcenter/clean
index ddfb4caea5..e2a2acec4c 100755
--- a/src/vnm_mad/remotes/vcenter/clean
+++ b/src/vnm_mad/remotes/vcenter/clean
@@ -64,7 +64,7 @@ require 'nsx_driver'
 def modified?(template)
     template_xml = Nokogiri::XML(template)
     action = template_xml.xpath('//TEMPLATE/NIC[ATTACH="YES"]')
-    action.empty? ? false : true
+    !action.empty?
 end
 
 template = Base64.decode64(STDIN.read)
diff --git a/src/vnm_mad/remotes/vcenter/post b/src/vnm_mad/remotes/vcenter/post
index 27818e7b73..c91218b1d2 100755
--- a/src/vnm_mad/remotes/vcenter/post
+++ b/src/vnm_mad/remotes/vcenter/post
@@ -64,7 +64,7 @@ require 'nsx_driver'
 def modified?(template)
     template_xml = Nokogiri::XML(template)
     action = template_xml.xpath('//TEMPLATE/NIC[ATTACH="YES"]')
-    action.empty? ? false : true
+    !action.empty?
 end
 
 template = Base64.decode64(STDIN.read)
diff --git a/src/vnm_mad/remotes/vcenter/update_sg b/src/vnm_mad/remotes/vcenter/update_sg
index 3c86c83dc2..64d0eb70ae 100755
--- a/src/vnm_mad/remotes/vcenter/update_sg
+++ b/src/vnm_mad/remotes/vcenter/update_sg
@@ -64,7 +64,7 @@ require 'nsx_driver'
 def modified?(template)
     template_xml = Nokogiri::XML(template)
     action = template_xml.xpath('//TEMPLATE/NIC[ATTACH="YES"]')
-    action.empty? ? false : true
+    !action.empty?
 end
 
 template = Base64.decode64(STDIN.read)