F #2341 Add debug information to vCenter drivers (stacktrace) (#2362)

* F #2341 Add debug information to vCenter drivers (stacktrace)

* Change default to false for vcenter debug info

(cherry picked from commit 8490a0f64c3eb12d17eebba421ce22d3dfca642c)

src/vmm_mad/remotes/lib/vcenter_driver/vcenter_driver.conf

@@ -20,3 +20,6 @@
 
 # Default timeout to complete deploy
 :vm_poweron_wait_default: 300
+
+# Show stacktraces on every exception
+:debug_information: false

src/vmm_mad/remotes/vcenter/attach_disk

@@ -53,6 +53,9 @@ rescue StandardError => e
     message = "Attach image for VM #{vm_ref} on vCenter cluster" \
               "#{vc_cluster_name} failed due to \"#{e.message}\"\n"
     OpenNebula.log_error(message)
+    if vi_client.get_property_vcenter_conf(:debug_information)
+	    STDERR.puts "#{message} #{e.backtrace}"
+    end
     exit(-1)
 ensure
     vi_client.close_connection if vi_client

src/vmm_mad/remotes/vcenter/attach_nic

@@ -52,6 +52,9 @@ rescue StandardError => e
     message = "Attach NIC for VM #{vm_ref} on vCenter cluster "\
               "#{vc_cluster_name} failed due to \"#{e.message}\"\n"
     OpenNebula.log_error(message)
+    if vi_client.get_property_vcenter_conf(:debug_information)
+	    STDERR.puts "#{message} #{e.backtrace}"
+    end
     exit(-1)
 ensure
     vi_client.close_connection if vi_client

src/vmm_mad/remotes/vcenter/cancel

@@ -51,6 +51,9 @@ rescue StandardError => e
     message = "Cancel VM #{vm_ref} failed due to "\
               "\"#{e.message}\"\n#{e.backtrace.join("\n")}"
     OpenNebula.log_error(message)
+    if vi_client.get_property_vcenter_conf(:debug_information)
+        STDERR.puts "#{message} #{e.backtrace}"
+    end
     exit(-1)
 ensure
     vi_client.close_connection if vi_client

src/vmm_mad/remotes/vcenter/deploy

@@ -76,6 +76,9 @@ rescue StandardError => e
     message =  "Deploy of VM #{vm_id} on vCenter cluster #{cluster_name} " \
                "with #{dfile} failed due to \"#{e.message}\"."
     OpenNebula.log_error(message)
+    if vi_client.get_property_vcenter_conf(:debug_information)
+        STDERR.puts "#{message} #{e.backtrace}"
+    end
     exit(-1)
 ensure
     vi_client.close_connection if vi_client

src/vmm_mad/remotes/vcenter/detach_disk

@@ -52,6 +52,9 @@ rescue StandardError => e
     message = "Detach DISK for VM #{vm_ref} on vCenter cluster " \
               "#{vc_cluster_name} failed due to \"#{e.message}\"."
     OpenNebula.log_error(message)
+    if vi_client.get_property_vcenter_conf(:debug_information)
+        STDERR.puts "#{message} #{e.backtrace}"
+    end
     exit(-1)
 ensure
     vi_client.close_connection if vi_client

src/vmm_mad/remotes/vcenter/detach_nic

@@ -51,6 +51,9 @@ rescue StandardError => e
     message = "Detach NIC for VM #{vm_ref} on vCenter cluster " \
               "#{vc_cluster_name} failed due to \"#{e.message}\"."
     OpenNebula.log_error(message)
+    if vi_client.get_property_vcenter_conf(:debug_information)
+        STDERR.puts "#{message} #{e.backtrace}"
+    end
     exit(-1)
 ensure
     vi_client.close_connection if vi_client

src/vmm_mad/remotes/vcenter/migrate

@@ -42,5 +42,8 @@ rescue StandardError => e
               'failed due to '\
               "\"#{e.message}\"."
     OpenNebula.log_error(message)
+    if vi_client.get_property_vcenter_conf(:debug_information)
+        STDERR.puts "#{message} #{e.backtrace}"
+    end
     exit(-1)
 end

src/vmm_mad/remotes/vcenter/poll

@@ -49,6 +49,9 @@ rescue StandardError => e
               " on vCenter cluster #{vc_cluster_name} failed due to " \
               "\"#{e.message}\"."
     OpenNebula.log_error(message)
+    if vi_client.get_property_vcenter_conf(:debug_information)
+        STDERR.puts "#{message} #{e.backtrace}"
+    end
     exit(-1)
 ensure
     vi_client.close_connection if vi_client

src/vmm_mad/remotes/vcenter/reboot

@@ -47,6 +47,9 @@ rescue StandardError => e
               "#{vc_cluster_name} failed due to "\
               "\"#{e.message}\"\n#{e.backtrace.join("\n")}"
     OpenNebula.log_error(message)
+    if vi_client.get_property_vcenter_conf(:debug_information)
+        STDERR.puts "#{message} #{e.backtrace}"
+    end
     exit(-1)
 ensure
     vi_client.close_connection if vi_client

src/vmm_mad/remotes/vcenter/reconfigure

@@ -50,6 +50,9 @@ rescue StandardErrord => e
               "#{vc_cluster_name} failed due to "\
               "\"#{e.message}\"."
     STDERR.puts error_message(message)
+    if vi_client.get_property_vcenter_conf(:debug_information)
+        STDERR.puts "#{e.backtrace}"
+    end
     exit(-1)
 ensure
     vi_client.close_connection if vi_client

src/vmm_mad/remotes/vcenter/reset

@@ -46,6 +46,9 @@ rescue StandardError => e
               "#{vc_cluster_name} failed due to "\
               "\"#{e.message}\"."
     OpenNebula.log_error(message)
+    if vi_client.get_property_vcenter_conf(:debug_information)
+        STDERR.puts "#{message} #{e.backtrace}"
+    end
     exit(-1)
 ensure
     vi_client.close_connection if vi_client

src/vmm_mad/remotes/vcenter/restore

@@ -47,6 +47,9 @@ rescue StandardError => e
               "#{vc_cluster_name} failed due to "\
               "\"#{e.message}\"."
     OpenNebula.log_error(message)
+    if vi_client.get_property_vcenter_conf(:debug_information)
+        STDERR.puts "#{message} #{e.backtrace}"
+    end
     exit(-1)
 ensure
     vi_client.close_connection if vi_client

src/vmm_mad/remotes/vcenter/save

@@ -61,6 +61,9 @@ rescue StandardError => e
               "#{vc_cluster_name} failed due to "\
               "\"#{e.message}\"\n#{e.backtrace.join("\n")}"
     OpenNebula.log_error(message)
+    if vi_client.get_property_vcenter_conf(:debug_information)
+        STDERR.puts "#{message} #{e.backtrace}"
+    end
     exit(-1)
 ensure
     vi_client.close_connection if vi_client

src/vmm_mad/remotes/vcenter/shutdown

@@ -68,6 +68,9 @@ rescue StandardError => e
               "#{vc_cluster_name} failed due to "\
               "\"#{e.message}\"\n#{e.backtrace.join("\n")}"
     OpenNebula.log_error(message)
+    if vi_client.get_property_vcenter_conf(:debug_information)
+        STDERR.puts "#{message} #{e.backtrace}"
+    end
     exit(-1)
 ensure
     vi_client.close_connection if vi_client

src/vmm_mad/remotes/vcenter/snapshot_create

@@ -63,6 +63,9 @@ rescue StandardError => e
               "#{vc_cluster_name} failed due to "\
               "\"#{e.message}\"\n"
     OpenNebula.log_error(message)
+    if vi_client.get_property_vcenter_conf(:debug_information)
+        STDERR.puts "#{message} #{e.backtrace}"
+    end
     exit(-1)
 ensure
     vi_client.close_connection if vi_client

src/vmm_mad/remotes/vcenter/snapshot_delete

@@ -46,6 +46,9 @@ rescue StandardError => e
               "#{vc_cluster_name} could not be deleted due to "\
               "\"#{e.message}\"\n"
     OpenNebula.log_error(message)
+    if vi_client.get_property_vcenter_conf(:debug_information)
+        STDERR.puts "#{message} #{e.backtrace}"
+    end
     exit(-1)
 ensure
     vi_client.close_connection if vi_client

src/vmm_mad/remotes/vcenter/snapshot_revert

@@ -47,6 +47,9 @@ rescue StandardError => e
               "#{vc_cluster_name} could not be reverted due "\
               "to \"#{e.message}\"\n"
     OpenNebula.log_error(message)
+    if vi_client.get_property_vcenter_conf(:debug_information)
+        STDERR.puts "#{message} #{e.backtrace}"
+    end
     exit(-1)
 ensure
     vi_client.close_connection if vi_client