shaba/one
1
0
Fork 0
mirror of https://github.com/OpenNebula/one.git synced 2025-03-16 22:50:10 +03:00
Code Releases Wiki Activity

L #-: Autostart hook linting (#1351)

Browse Source
This commit is contained in:
Ricardo Diaz 2021-07-08 16:59:05 +02:00 committed by GitHub
parent acd1cc9469
commit ad5bd71d8e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
share/hooks/autostart/host
View File

@ -71,7 +71,6 @@ require 'getoptlong'
require 'base64'
require 'open3'
################################################################################
# Arguments
################################################################################
@ -80,18 +79,16 @@ require 'open3'
standard_input = STDIN.read
ARGV.replace(standard_input.split(' '))
raw_host_template = Base64.decode64(ARGV[0])
xml_host_template = Nokogiri::XML(raw_host_template)
HOST_ID = xml_host_template.xpath('HOST/ID').text
################################################################################
# Methods
################################################################################
def log(msg, level="I")
def log(msg, level = 'I')
File.open(LOG_FILE, 'a') do |f|
msg.lines do |l|
f.puts "[#{Time.now}][HOST #{HOST_ID}][#{level}] #{l}"
@ -100,11 +97,11 @@ def log(msg, level="I")
end
def log_error(msg)
log(msg, "E")
log(msg, 'E')
end
def exit_error
log_error("Exiting due to previous error.")
log_error('Exiting due to previous error.')
exit(-1)
end
@ -112,11 +109,11 @@ end
# Main
################################################################################
log "OpenNebula Autostart Host Hook launched"
log 'OpenNebula Autostart Host Hook launched'
begin
client = Client.new()
rescue Exception => e
client = Client.new
rescue StandardError => e
log_error e.to_s
exit_error
end
@ -125,11 +122,11 @@ host = OpenNebula::Host.new_with_id(HOST_ID, client)
rc = host.info
if OpenNebula.is_error?(rc)
log_error "#{rc.message}"
log_error rc.message.to_s
exit_error
end
log "#{host.name}"
log host.name.to_s
# Iterate over guest VMs
xml_host_template.xpath('HOST/VMS').text.split.each do |vm_id|
@ -143,7 +140,7 @@ xml_host_template.xpath('HOST/VMS').text.split.each do |vm_id|
# Skip if VM AUTOSTART not enabled
autostart = vm['USER_TEMPLATE/AUTOSTART']
if !autostart || (autostart != "true" && autostart != "yes")
if !autostart || (autostart != 'true' && autostart != 'yes')
log "vm #{vm_id}: skip: autostart not enabled"
next
end
@ -153,7 +150,7 @@ xml_host_template.xpath('HOST/VMS').text.split.each do |vm_id|
# determine the state of active VMs, UNKNOWN state is kept.
# Skip if LCM State is not UNKNOWN
if vm.lcm_state_str != 'UNKNOWN'
log "vm #{vm_id}: skip: lcm_state (#{vm.lcm_state_str}) is not 'UNKNOWN'"
log "vm #{vm_id}: skip: lcm_state (#{vm.lcm_state_str}) is not UNKNOWN"
next
end
@ -173,8 +170,9 @@ xml_host_template.xpath('HOST/VMS').text.split.each do |vm_id|
# Skip if action in last history record of guest is not 'none'
last_action = vm["#{last_history_xpath}/ACTION"]
last_action_str = OpenNebula::VirtualMachine.get_history_action(last_action)
if not %w{none live-migrate}.include?(last_action_str)
log "vm #{vm_id}: skip: last_action (#{last_action_str}) is not 'none' or 'live-migrate'"
if !%w[none live-migrate].include?(last_action_str)
log "vm #{vm_id}: skip: last_action (#{last_action_str}) "<<
'is not none or live-migrate'
next
end

29
share/hooks/autostart/vm
View File

@ -73,7 +73,6 @@ require 'getoptlong'
require 'base64'
require 'open3'
################################################################################
# Arguments
################################################################################
@ -82,18 +81,16 @@ require 'open3'
standard_input = STDIN.read
ARGV.replace(standard_input.split(' '))
raw_vm_template = Base64.decode64(ARGV[0])
xml_vm_template = Nokogiri::XML(raw_vm_template)
VM_ID = xml_vm_template.xpath('VM/ID').text
################################################################################
# Methods
################################################################################
def log(msg, level="I")
def log(msg, level = 'I')
File.open(LOG_FILE, 'a') do |f|
msg.lines do |l|
f.puts "[#{Time.now}][VM #{VM_ID}][#{level}] #{l}"
@ -102,11 +99,11 @@ def log(msg, level="I")
end
def log_error(msg)
log(msg, "E")
log(msg, 'E')
end
def exit_error
log_error("Exiting due to previous error.")
log_error('Exiting due to previous error.')
exit(-1)
end
@ -114,11 +111,11 @@ end
# Main
################################################################################
log "OpenNebula Autostart VM Hook launched"
log 'OpenNebula Autostart VM Hook launched'
begin
client = Client.new()
rescue Exception => e
client = Client.new
rescue StandardError => e
log_error e.to_s
exit_error
end
@ -127,23 +124,23 @@ vm = OpenNebula::VirtualMachine.new_with_id(VM_ID, client)
rc = vm.info
if OpenNebula.is_error?(rc)
log_error "#{rc.message}"
log_error rc.message.to_s
exit_error
end
log "#{vm.name}"
log vm.name.to_s
# Skip if AUTOSTART not enabled
autostart = vm['USER_TEMPLATE/AUTOSTART']
if !autostart || (autostart != "true" && autostart != "yes")
log "skip: autostart not enabled"
if !autostart || (autostart != 'true' && autostart != 'yes')
log 'skip: autostart not enabled'
exit 0
end
# ACTION in last history record of guest is equal to 'monitor' if an active VM
# was powered off by monitor.
# Skip if VM is not poweroff by monitor
last_action = vm["HISTORY_RECORDS/HISTORY[last()]/ACTION"]
last_action = vm['HISTORY_RECORDS/HISTORY[last()]/ACTION']
last_action_str = OpenNebula::VirtualMachine.get_history_action(last_action)
if last_action_str != 'monitor'
log "skip: last_action (#{last_action_str}) is not 'monitor'"
@ -151,9 +148,9 @@ if last_action_str != 'monitor'
end
# Autostart VM
log "resume"
log 'resume'
rc = vm.resume
log_error "#{rc.message}" if OpenNebula.is_error?(rc)
log_error rc.message.to_s if OpenNebula.is_error?(rc)
exit 0