shaba/one
1
0
Fork 0
mirror of https://github.com/OpenNebula/one.git synced 2025-02-18 17:57:24 +03:00
Code Releases Wiki Activity

Fix VM ID parsing in associate_address()

Browse Source 
The current code in `ElasticIP::associate_address()` strips the leading `i-` prefix of VM instance IDs, if found, in order to convert EC2 instance IDs into OpenNebula VM IDs. Unfortunately that does not work for IDs greater than 7, since the stripped string is interpreted as an octal number due to the remaining leading 0's:

    $ econe-allocate-address
    $ econe-describe-addresses 
      publicIp                instanceId
    192.168.1.
    $ econe-associate-address 192.168.1.1 i-00000106
    $ econe-describe-addresses 
      publicIp                instanceId
    192.168.1.                i-00000070 

(Note that decimal 106 is octal 70)
This commit is contained in:
Carlos Valiente 2016-03-28 20:16:20 +01:00
parent c6076a173a
commit c7ed0950b1
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/cloud/ec2/lib/elastic_ip.rb
View File

@ -119,8 +119,7 @@ module ElasticIP
user_id = retrieve_uid
eip = params["PublicIp"]
vmid = params['InstanceId']
vmid = vmid.split('-')[1] if vmid[0]==?i
vmid = params['InstanceId'].sub(/^i\-0*/, '')
unless vnet["TEMPLATE/EC2_ADDRESSES[IP=\"#{eip}\" and UID=\"#{retrieve_uid}\"]/IP"]
rc = OpenNebula::Error.new("address:#{eip} does not exist")