L #-: Linting for rubocop 1.53.0

share/linters/.rubocop.yml

@@ -793,6 +793,9 @@ Style/RedundantLineContinuation:
 Style/RedundantFilterChain:
   Enabled: false
 
+Style/ReturnNilInPredicateMethodDefinition:
+  Enabled: false
+
 ######
 # LINT
 ######

src/im_mad/remotes/lib/vcenter_monitor.rb

@@ -55,8 +55,8 @@ $LOAD_PATH << RUBY_LIB_LOCATION
 require 'yaml'
 require 'rexml/document'
 
-require_relative './vcenter_cluster'
-require_relative './monitord_client'
+require_relative 'vcenter_cluster'
+require_relative 'monitord_client'
 
 #---------------------------------------------------------------------------
 #

src/mad/ruby/DriverExecHelper.rb

@@ -189,7 +189,7 @@ module DriverExecHelper
                 cfg=file.read
             end
 
-            cfg.split(/\n/).each do |line|
+            cfg.split("\n").each do |line|
                 m=line.match(/^([^=]+)=(.*)$/)
 
                 next unless m

src/tm_mad/ceph/prebackup

@@ -119,7 +119,6 @@ vm.elements.each 'TEMPLATE/DISK' do |d|
     conv_cmd << ds.cmd_confinement(qemu_cmd, rdir)
 
     clup_cmd << "rm -f #{draw}\n"
-
 rescue StandardError => e
     STDERR.puts "Missing configuration attributes in DISK: #{e.message}"
     exit(1)

src/tm_mad/ceph/prebackup_live

@@ -126,7 +126,6 @@ vm.elements.each 'TEMPLATE/DISK' do |d|
 
     clup_cmd << "#{cmd} snap rm #{rbd_src}@backup\n"
     clup_cmd << "rm -f #{draw}\n"
-
 rescue StandardError => e
     STDERR.puts "Missing configuration attributes in DISK: #{e.message}"
     exit(1)

src/tm_mad/lib/backup_qcow2.rb

@@ -22,7 +22,7 @@ require 'rexml/document'
 require 'base64'
 require 'getoptlong'
 
-require_relative './kvm'
+require_relative 'kvm'
 
 #-------------------------------------------------------------------------------
 # CONFIGURATION CONSTANTS

src/vmm_mad/remotes/kvm/attach_nic

@@ -51,7 +51,7 @@ end
 
 $LOAD_PATH << RUBY_LIB_LOCATION
 
-require_relative './opennebula_vm'
+require_relative 'opennebula_vm'
 require_relative '../lib/command'
 
 include VirtualMachineManagerKVM

src/vmm_mad/remotes/kvm/detach_nic

@@ -52,7 +52,7 @@ end
 
 $LOAD_PATH << RUBY_LIB_LOCATION
 
-require_relative './opennebula_vm'
+require_relative 'opennebula_vm'
 require_relative '../lib/command'
 
 include VirtualMachineManagerKVM

src/vmm_mad/remotes/lib/nsx_driver/virtual_wire.rb

@@ -91,7 +91,7 @@ module NSXDriver
                            .get(url)
                            .xpath(NSXConstants::NSXV_LS_XPATH)
             virtualwires.each do |virtualwire|
-                lsname_arr = name.split(/-sid-/)
+                lsname_arr = name.split('-sid-')
                 lsname = lsname_arr[-1].split('-', 2)[-1]
                 lsid = lsname_arr[0].split(/vxw-dvs-\w.-/)[-1]
                 if virtualwire.xpath('name').text == lsname &&