F OpenNebula/one#5422: Lint

src/fireedge/.eslintrc

@@ -8,7 +8,6 @@
     "plugin:react/recommended",
     "standard"
   ],
-  "parser": "babel-eslint",
   "parserOptions": {
     "ecmaFeatures": {
         "jsx": true

src/fireedge/src/client/components/Table/EnhancedTable.js

@@ -1,3 +1,4 @@
+/* eslint-disable react/jsx-key */
 import React from 'react'
 import PropTypes from 'prop-types'
 
@@ -84,7 +85,7 @@ const EnhancedTable = ({
       />
       <MTable size='small' {...getTableProps()}>
         <TableHead>
-          {headerGroups.map(headerGroup => (
+          {headerGroups.map((headerGroup) => (
             <TableRow {...headerGroup.getHeaderGroupProps()}>
               {headerGroup.headers.map(column => (
                 <TableCell

src/fireedge/src/client/components/Tables/Enhanced/Utils/GlobalFilter.js

@@ -43,10 +43,9 @@ const GlobalFilter = props => {
    * @type {import('react-table').UseGlobalFiltersInstanceProps &
    * import('react-table').UseGlobalFiltersState}
    */
-  const { preGlobalFilteredRows, globalFilter, setGlobalFilter } = props
+  const { globalFilter, setGlobalFilter } = props
 
   const classes = useStyles()
-  const count = preGlobalFilteredRows.length
 
   const [value, setValue] = React.useState(globalFilter)
 
@@ -55,26 +54,6 @@ const GlobalFilter = props => {
     debounce(value => { setGlobalFilter(value || undefined) }, 200)
   )
 
-  // Global filter only works with pagination from the first page.
-  // This may not be a problem for server side pagination when
-  // only the current page is downloaded.
-
-  /* <Box className={classes.search}>
-      <Box className={classes.searchIcon}>
-        <SearchIcon />
-      </Box>
-      <InputBase
-        type='search'
-        onChange={searchProps.handleChange}
-        fullWidth
-        placeholder={`${T.Search}...`}
-        classes={{
-          root: classes.inputRoot,
-          input: classes.inputInput
-        }}
-      />
-    </Box> */
-
   return (
     <div className={classes.search}>
       <div className={classes.searchIcon}>

src/fireedge/src/client/components/Tables/Enhanced/Utils/GlobalSort.js

@@ -13,7 +13,7 @@ const useStyles = makeStyles(theme => ({
     flexWrap: 'wrap',
     gap: 6,
     alignItems: 'center'
-  },
+  }
 }))
 
 const GlobalSort = props => {
@@ -26,7 +26,7 @@ const GlobalSort = props => {
    */
   const { headers, sortBy, setSortBy } = props
 
-  const headersNotSorted = React.useMemo(() => 
+  const headersNotSorted = React.useMemo(() =>
     headers.filter(({ isSorted, canSort, isVisible }) =>
       !isSorted && canSort && isVisible
     ), [sortBy.length])
@@ -36,9 +36,9 @@ const GlobalSort = props => {
   }
 
   const handleDelete = removeId => {
-    setSortBy(sortBy.filter(({id}) => id !== removeId))
+    setSortBy(sortBy.filter(({ id }) => id !== removeId))
   }
-  
+
   const handleToggle = (id, desc) => {
     setSortBy(sortBy.map(sort => sort.id === id ? ({ ...sort, desc }) : sort))
   }

src/fireedge/src/client/components/Tables/Hosts/detail.js

@@ -1,4 +1,5 @@
 import React, { useEffect } from 'react'
+import PropTypes from 'prop-types'
 import { LinearProgress } from '@material-ui/core'
 
 import Tabs from 'client/components/Tabs'
@@ -30,7 +31,7 @@ const HostDetail = ({ id }) => {
     return <div>{error}</div>
   }
 
-  const { ID, NAME, IM_MAD, VM_MAD, VMS, CLUSTER } = data
+  const { ID, NAME, IM_MAD, VM_MAD /* VMS, CLUSTER */ } = data
 
   const { name: stateName, color: stateColor } = HostModel.getState(data)
 
@@ -63,4 +64,8 @@ const HostDetail = ({ id }) => {
   )
 }
 
+HostDetail.propTypes = {
+  id: PropTypes.string.isRequired
+}
+
 export default HostDetail

src/fireedge/src/client/components/Tables/Images/detail.js

@@ -1,4 +1,5 @@
 import React, { useEffect } from 'react'
+import PropTypes from 'prop-types'
 import { LinearProgress } from '@material-ui/core'
 
 import Tabs from 'client/components/Tabs'
@@ -76,4 +77,8 @@ const ImageDetail = ({ id }) => {
   )
 }
 
+ImageDetail.propTypes = {
+  id: PropTypes.string.isRequired
+}
+
 export default ImageDetail

src/fireedge/src/client/components/Tables/Vms/detail.js

@@ -1,4 +1,5 @@
 import React, { useEffect } from 'react'
+import PropTypes from 'prop-types'
 import { LinearProgress, Accordion, AccordionSummary, AccordionDetails } from '@material-ui/core'
 
 import Tabs from 'client/components/Tabs'
@@ -192,4 +193,8 @@ const VmDetail = ({ id }) => {
   )
 }
 
+VmDetail.propTypes = {
+  id: PropTypes.string.isRequired
+}
+
 export default VmDetail

src/fireedge/src/client/features/One/marketplace/hooks.js

@@ -6,7 +6,7 @@ import * as actions from 'client/features/One/marketplace/actions'
 import { RESOURCES } from 'client/features/One/slice'
 
 export const useMarketplace = () => (
-  useSelector(state => state.one.[RESOURCES.marketplace])
+  useSelector(state => state.one[RESOURCES.marketplace])
 )
 
 export const useMarketplaceApi = () => {

src/fireedge/src/client/features/One/utils.js

@@ -61,4 +61,4 @@ export const updateResourceList = (currentList, value) => {
     : [value, currentList]
 
   return updatedList
-}
+}

src/fireedge/src/client/features/One/vnetwork/hooks.js

@@ -6,7 +6,7 @@ import * as actions from 'client/features/One/vnetwork/actions'
 import { RESOURCES } from 'client/features/One/slice'
 
 export const useVNetwork = () => (
-  useSelector(state => state.one.[RESOURCES.vn])
+  useSelector(state => state.one[RESOURCES.vn])
 )
 
 export const useVNetworkApi = () => {

src/fireedge/src/client/features/One/vnetworkTemplate/hooks.js

@@ -6,7 +6,7 @@ import * as actions from 'client/features/One/vnetworkTemplate/actions'
 import { RESOURCES } from 'client/features/One/slice'
 
 export const useVNetworkTemplate = () => (
-  useSelector(state => state.one.[RESOURCES.vntemplate])
+  useSelector(state => state.one[RESOURCES.vntemplate])
 )
 
 export const useVNetworkTemplateApi = () => {

src/fireedge/src/client/models/VirtualMachine.js

@@ -1,6 +1,6 @@
 import { STATES, VM_STATES, VM_LCM_STATES } from 'client/constants'
 
-const EXTERNAL_IP_ATTRS = [
+/* const EXTERNAL_IP_ATTRS = [
   'GUEST_IP',
   'GUEST_IP_ADDRESSES',
   'AWS_IP_ADDRESS',
@@ -8,7 +8,7 @@ const EXTERNAL_IP_ATTRS = [
   'AWS_PRIVATE_IP_ADDRESS',
   'AZ_IPADDRESS',
   'SL_PRIMARYIPADDRESS'
-]
+] */
 
 const NIC_ALIAS_IP_ATTRS = [
   'IP',