shaba/openuds
1
0
Fork 1
mirror of https://github.com/dkmstr/openuds.git synced 2024-12-22 13:34:04 +03:00
Code Issues Releases Wiki Activity

* Changed separator of action/parameters to '\r'

Browse Source 
* Added "ChangeUserPassword" to Operations
* Added so GetInfo can return a message not only for machine renaming, but also for an user password changing (for WinRandomPassOsManager)
This commit is contained in:
Adolfo Gómez 2012-11-26 09:08:10 +00:00
parent 830e1b2e6f
commit 2506d32da8
3 changed files with 71 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
udsService/rpc/Operation.cs
View File

@ -35,6 +35,16 @@ namespace uds
[DllImport("user32.dll", ExactSpelling = true, SetLastError = true)]
internal static extern bool ExitWindowsEx(int flg, int rea);
[DllImport("netapi32.dll", CharSet = CharSet.Unicode, CallingConvention = CallingConvention.StdCall,
SetLastError = true)]
static extern uint NetUserChangePassword(
[MarshalAs(UnmanagedType.LPWStr)] string domainname,
[MarshalAs(UnmanagedType.LPWStr)] string username,
[MarshalAs(UnmanagedType.LPWStr)] string oldpassword,
[MarshalAs(UnmanagedType.LPWStr)] string newpassword
);
[Flags]
public enum JoinOptions
{
@ -141,5 +151,23 @@ namespace uds
}
public static bool ChangeUserPassword(string user, string oldPass, string newPass)
{
try {
logger.Debug("Setting new password for user " + user + " to " + newPass);
uint res = NetUserChangePassword(null, user, oldPass, newPass);
logger.Debug("Result of changeUserPassword: " + res);
if( res != 0 )
logger.Error("Could not change password for user \"" + user + "\" (using password \"" + newPass + "\"), result: " + res);
return res == 0;
}
catch (Exception e)
{
logger.Error("Exception at change user password", e);
return false;
}
}
}
}

2
udsService/rpc/rpc.cs
View File

@ -18,7 +18,7 @@ namespace uds
private const string LOGON_MSG = "logon";
private const string LOGOFF_MSG = "logoff";
private const string INFO_MSG = "info";
private const string INFO_MSG = "information";
private const string READY_MSG = "ready";
private const string IP_MSG = "ip";

49
udsService/udsService/Service.cs
View File

@ -127,10 +127,18 @@ namespace uds.Services
rpc.ResetManager();
return;
}
// Message is in the form "action:params", where we can identify:
// rename:computername
// domain:computername\tdomain\tou\tuserToAuth\tpassToAuth
string[] data = action.Split(':');
// Important note:
// Remove ":" as separator, due to the posibility that ":" can be used as part of a password
// Old ":" is now '\r'
// In order to keep compatibility, getInfo will invoke rcp "information", so old actors "versions"
// will keep invoking "info" and return the old ":" separator way
// Message is in the form "action\rparams", where we can identify:
// rename\rcomputername --- > Just rename
// rename\rcomputername\tuser\toldPass\tnewPass --> Rename with user password changing
// domain:computername\tdomain\tou\tuserToAuth\tpassToAuth --> Rename and add machine to domain
string[] data = action.Split('\r');
if (data.Length != 2)
{
logger.Error("Unrecognized instruction: \"" + action + "\"");
@ -138,14 +146,27 @@ namespace uds.Services
return;
}
string[] parms = data[1].Split('\t');
switch (data[0])
{
case "rename":
Rename(data[1]);
if (parms.Length == 1 )
// Do not have to change user password
Rename(parms[0], null, null, null);
else if (parms.Length == 4)
// Rename, and also change user password
Rename(parms[0], parms[1], parms[2], parms[2]);
else
{
logger.Error("Unrecognized parameters: " + data[1]);
rpc.ResetManager();
return;
}
break;
case "domain":
{
string[] parms = data[1].Split('\t');
if (parms.Length != 5)
{
logger.Error("Unrecognized parameters: " + data[1]);
@ -213,23 +234,37 @@ namespace uds.Services
}
}
private void Rename(string name)
private void Rename(string name, string user, string oldPass, string newPass)
{
logger.Info("Requested renaming of computer to \"" + name + "\"");
// name and newName can be different case, but still same
Info.DomainInfo info = Info.Computer.GetDomainInfo();
if ( string.Equals(info.ComputerName, name, StringComparison.CurrentCultureIgnoreCase))
{
logger.Debug("Computer do not needs to be renamed");
rpc.SetReady();
return;
}
// Set user password if provided
if (user != null)
{
if (Operation.ChangeUserPassword(user, oldPass, newPass) == false)
{
logger.Error("Could not change password to " + newPass + " for user " + user);
rpc.ResetManager();
return;
}
}
if (Operation.RenameComputer(name) == false)
{
logger.Error("Could not rename machine to \"" + name + "\"");
rpc.ResetManager();
return;
}
Reboot();
}