shaba/openuds
1
0
Fork 1
mirror of https://github.com/dkmstr/openuds.git synced 2025-01-08 21:18:00 +03:00
Code Issues Releases Wiki Activity

Updated ovirt engine so 3.5.4 works correctly with disk cloning (Bug has been fixed on oVirt)

Browse Source
This commit is contained in:
Adolfo Gómez García 2015-09-21 07:29:10 +02:00
parent eea9db7a0d
commit b64fa374d7
2 changed files with 18 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
server/src/uds/services/OVirt/OVirtProvider.py
View File

@ -45,7 +45,7 @@ from client import oVirtClient
import logging
__updated__ = '2015-07-24'
__updated__ = '2015-09-21'
logger = logging.getLogger(__name__)

29
server/src/uds/services/OVirt/client/oVirtClient.py
View File

@ -9,8 +9,9 @@ from ovirtsdk.api import API
import threading
import logging
import re
__updated__ = '2015-06-12'
__updated__ = '2015-09-21'
logger = logging.getLogger(__name__)
@ -90,17 +91,24 @@ class Client(object):
finally:
lock.release()
def _isFullyFunctionalVersion(self, api):
'''
Same as isFullyFunctionalVersion, but without locking. For internal use only
'''
version = re.search('([0-9]+).([0-9]+).([0-9]+)?', api.get_product_info().full_version).groups()
if version[0] == '3' and version[1] == '5' and (version[2] is None or version[2] < '4'): # 3.5 fails if disks are in request
return [False, 'Version 3.5 is not fully supported due a BUG in oVirt REST API (but partially supported. See UDS Documentation)']
return [True, 'Test successfully passed']
def isFullyFunctionalVersion(self):
try:
lock.acquire(True)
version = self.__getApi().get_product_info().version
if version.major == 3 and version.minor == 5: # 3.5 fails if disks are in request
return [False, 'Version 3.5 is not fully supported due a BUG in oVirt REST API (but partially supported. See UDS Documentation)']
return self._isFullyFunctionalVersion(self.__getApi())
finally:
lock.release()
return [True, 'Test successfully passed']
def getVms(self, force=False):
'''
Obtains the list of machines inside ovirt that do aren't part of uds
@ -373,13 +381,12 @@ class Client(object):
if vm.get_status().get_state() != 'down':
raise Exception('Machine must be in down state to publish it')
print vm.disks.list()
# Create disks description to be created in specified storage domain, one for each disk
sd = params.StorageDomains(storage_domain=[params.StorageDomain(id=storageId)])
version = api.get_product_info().version
fix = version.major == 3 and version.minor == 5 # 3.5 fails if disks are in request
fix = not self._isFullyFunctionalVersion(api)[0] # If we need a fix for "publish"
print "FIX: {}".format(fix)
dsks = []
for dsk in vm.disks.list():
@ -407,8 +414,6 @@ class Client(object):
# display=display)
return api.templates.add(template).get_id()
# return api.templates.get(name=name).get_id()
finally:
lock.release()