shaba/openuds
1
0
Fork 1
mirror of https://github.com/dkmstr/openuds.git synced 2025-01-06 13:17:54 +03:00
Code Issues Releases Wiki Activity

fixed user interface serialization with stored_field_name (typo fix...)

Browse Source
This commit is contained in:
Adolfo Gómez García 2024-01-12 02:15:50 +01:00
parent 698d9cbcc7
commit cd737c4b5f
No known key found for this signature in database
GPG Key ID: DD1ABF20724CDA23
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
server/src/uds/core/ui/user_interface.py
View File

@ -1429,7 +1429,7 @@ class UserInterface(metaclass=UserInterfaceAbstract):
}
# Any unexpected type will raise an exception
arr = [
(field_name, field.stored_field_name() or field.type.name, fw_converters[field.type](field))
(field.stored_field_name() or field_name, field.type.name, fw_converters[field.type](field))
for field_name, field in self._gui.items()
if fw_converters[field.type](field) is not None
]

14
server/tests/core/ui/test_userinterface_serialization.py
View File

@ -40,6 +40,7 @@ from ...utils.test import UDSTestCase
from uds.core import types, consts
from uds.core.ui.user_interface import gui
from unittest import mock
from ...fixtures.user_interface import (
TestingUserInterface,
@ -166,6 +167,7 @@ class UserinterfaceTest(UDSTestCase):
def test_new_serialization(self):
# This test is to ensure that new serialized data can be loaded
# First
ui = TestingUserInterface()
data = ui.serialize_fields()
ui2 = TestingUserInterface()
@ -176,9 +178,21 @@ class UserinterfaceTest(UDSTestCase):
def test_stored_field_name(self):
# This test is to ensure that new serialized data can be loaded
# mock logging warning
ui = TestingUserInterfaceFieldNameOrig()
data = ui.serialize_fields()
ui2 = TestingUserInterfaceFieldName()
ui2.unserialize_fields(data)
self.assertEqual(ui.strField.value, ui2.str_field.value)
with mock.patch('logging.Logger.warning') as mock_warning:
data = ui2.serialize_fields() # Should store str_field as strField
ui.unserialize_fields(data)
# Logger.warning should has not been called
mock_warning.assert_not_called()
# And strField should be loaded from str_field
self.assertEqual(ui.strField.value, ui2.str_field.value)