shaba/ostree
1
0
Fork 0
mirror of https://github.com/ostreedev/ostree.git synced 2024-10-26 17:25:36 +03:00
Code Issues Projects Releases Wiki Activity
56020b7160
ostree/Makefile-tests.am

442 lines
15 KiB
Plaintext
Raw Normal View History

Install tests Matching https://live.gnome.org/GnomeGoals/InstalledTests
2013-05-01 23:26:21 +04:00
# Makefile for tests code
#
# Copyright (C) 2013 Colin Walters <walters@verbum.org>
#
Add SPDX-License-Identifier to source files SPDX License List is a list of (common) open source licenses that can be referred to by a “short identifier”. It has several advantages compared to the common "license header texts" usually found in source files. Some of the advantages: * It is precise; there is no ambiguity due to variations in license header text * It is language neutral * It is easy to machine process * It is concise * It is simple and can be used without much cost in interpreted environments like java Script, etc. * An SPDX license identifier is immutable. * It provides simple guidance for developers who want to make sure the license for their code is respected See http://spdx.org for further reading. Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> Closes: #1439 Approved by: cgwalters
2018-01-30 22:26:26 +03:00
# SPDX-License-Identifier: LGPL-2.0+
#
Install tests Matching https://live.gnome.org/GnomeGoals/InstalledTests
2013-05-01 23:26:21 +04:00
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
# License as published by the Free Software Foundation; either
# version 2 of the License, or (at your option) any later version.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with this library; if not, write to the
# Free Software Foundation, Inc., 59 Temple Place - Suite 330,
# Boston, MA 02111-1307, USA.
build: distribute TAP helper scripts in tarballs Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 12:43:34 +03:00
EXTRA_DIST += \
buildutil/tap-driver.sh \
buildutil/tap-test \
Distribute valgrind suppressions in tarballs Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #557 Approved by: cgwalters
2016-10-08 01:12:29 +03:00
tests/glib.supp \
tests/ostree.supp \
build: distribute TAP helper scripts in tarballs Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 12:43:34 +03:00
$(NULL)
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
# We should probably consider flipping the default for DEBUG. Also,
# include the builddir in $PATH so we find our just-built ostree
# binary.
build: Use AM_TESTS_ENVIRONMENT rather than TESTS_ENVIRONMENT TESTS_ENVIRONMENT is reserved for the user to be able to set when running the tests. AM_TESTS_ENVIRONMENT is for the tests’ Makefile to set itself. https://www.gnu.org/software/automake/manual/html_node/Scripts_002dbased-Testsuites.html Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #880 Approved by: cgwalters
2017-05-23 15:26:25 +03:00
AM_TESTS_ENVIRONMENT += OT_TESTS_DEBUG=1 \
Add Coccinelle usage: one for blacklisting, one for patch collection This is inspired by the [Coccinelle](http://coccinelle.lip6.fr/) usage in systemd. I also took it a bit further and added infrastructure to have spatches which should never apply. This acts as a blacklist. The reason to do the latter is that coccinelle is *way* more powerful than the regular expresssions we have in `make syntax-check`. I started with blacklisting `g_error_free()` directly. The reason that's bad is it leaves a dangling pointer. Closes: #754 Approved by: jlebon
2017-03-23 20:06:07 +03:00
OSTREE_UNINSTALLED_SRCDIR=$(abs_top_srcdir) \
Split trivial-httpd into separate binary Working on the libcurl backend, I hit the issue that the trivial-httpd program depends on libsoup. I briefly considered having two versions, but libcurl is client only, and moreover trivial-httpd is no longer trivial - it has various features which are used by the test suite extensively. Hence, what we'll do is build it as a separate binary which links to libsoup, and use it during the tests. We *also* currently still provide `ostree trivial-httpd` since some things use it like `rpm-ostree-toolbox` and the Cockpit tests. After those are ported to use some other webserver, I plan to add a build-time option to drop it. Closes: #636 Approved by: jlebon
2016-12-30 22:18:34 +03:00
OSTREE_UNINSTALLED=$(abs_top_builddir) \
tests: Use G_DEBUG=fatal-warnings here too I am trying to track down a warning I see in `test-keyfile-utils` which turned out to be the installed case only, but let's inject this here too. (The GLib default is broken, but it's hard to fix upstream without breaking the world) Closes: #610 Approved by: jlebon
2016-12-05 20:58:43 +03:00
G_DEBUG=fatal-warnings \
tests: prepend to an existing LD_LIBRARY_PATH, GI_TYPELIB_PATH If we're using LD_LIBRARY_PATH for some locally-built library, we want to search those after OSTree's own libraries. Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #606 Approved by: cgwalters
2016-11-30 13:01:05 +03:00
GI_TYPELIB_PATH=$$(cd $(top_builddir) && pwd)$${GI_TYPELIB_PATH:+:$$GI_TYPELIB_PATH} \
LD_LIBRARY_PATH=$$(cd $(top_builddir)/.libs && pwd)$${LD_LIBRARY_PATH:+:$${LD_LIBRARY_PATH}} \
tests: Modernize valgrind infrastructure The recent memleak fixes motivated me to look at the bitrotted code to run invocations of `ostree` in the test suite underneath valgrind. There are a few things here. First, update suppressions file from libhif, since I recently worked on it. When running *uninstalled* as we now support, we need `libtool --mode=execute` in the mix so it expands out to the uninstalled binary and we don't valgrind the intermediate shell. However, it's harder than that because we chdir into a tmpdir, which defeats the libtool logic. AFAICS, the only fix for this is to determine the realbin path before we chdir, and then unfortunately we need to change every use of `ostree` to `${OSTREE}` =( Then this immediately breaks for me on RHEL7 because my ancient copy of `valgrind-3.10.0-16.el7.x86_64` is unaware of syscall 306, i.e. `syncfs`. But let's do this first before I dive into that. Closes: #292 Approved by: krnowak
2016-05-11 22:54:48 +03:00
PATH=$$(cd $(top_builddir)/tests && pwd):$${PATH} \
build: Add --enable-experimental-api configure option for unstable APIs There are currently no unstable APIs, but some will be added in following commits. They will be built and exposed in the libostree global symbol list iff configured with --enable-experimental-api. Distributions should not package OSTree with --enable-experimental-api. This is designed for previewing new APIs on controlled platforms; any of the APIs hidden behind this option may be changed or removed at any point. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #832 Approved by: cgwalters
2017-05-01 12:59:33 +03:00
OSTREE_FEATURES="$(OSTREE_FEATURES)" \
tests: Run python tests with stdout unbuffered Set the PYTHONUNBUFFERED environment variable during tests so that python leaves stdout unbuffered. This is helpful when reading logs for failures since the interleaved stdout and stderr will generally come out in the right order. It's not perfect since tap-driver.sh does some special redirection to the log file, but it's an improvement. Closes: #1352 Approved by: dbnicholson
2017-10-14 03:52:04 +03:00
PYTHONUNBUFFERED=1 \
Load g-i bindings from builddir during build-time testing Previously, the build-time tests would only pass if the g-i bindings to OSTree were already installed, with a reasonably similar version. Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #232 Approved by: cgwalters
2016-03-31 11:02:23 +03:00
$(NULL)
Skip gjs-based tests if ASAN is enabled Unfortunately, introspection uses dlopen(), which doesn't quite work when the DSO is compiled with ASAN but the outer executable isn't. Trying to inject LD_PRELOAD=libasan means the outer executable has to be leak free...which, yeah, I'm not going to get into running ASAN today on gjs or pygobject. So, let's skip those tests - ideally, we still run them in some other context without the sanitizers. The coverage we have from them is middling anyways. Closes: #622 Approved by: jlebon
2016-12-08 05:59:40 +03:00
if BUILDOPT_ASAN
build: Use AM_TESTS_ENVIRONMENT rather than TESTS_ENVIRONMENT TESTS_ENVIRONMENT is reserved for the user to be able to set when running the tests. AM_TESTS_ENVIRONMENT is for the tests’ Makefile to set itself. https://www.gnu.org/software/automake/manual/html_node/Scripts_002dbased-Testsuites.html Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #880 Approved by: cgwalters
2017-05-23 15:26:25 +03:00
AM_TESTS_ENVIRONMENT += OT_SKIP_READDIR_RAND=1 G_SLICE=always-malloc
Skip gjs-based tests if ASAN is enabled Unfortunately, introspection uses dlopen(), which doesn't quite work when the DSO is compiled with ASAN but the outer executable isn't. Trying to inject LD_PRELOAD=libasan means the outer executable has to be leak free...which, yeah, I'm not going to get into running ASAN today on gjs or pygobject. So, let's skip those tests - ideally, we still run them in some other context without the sanitizers. The coverage we have from them is middling anyways. Closes: #622 Approved by: jlebon
2016-12-08 05:59:40 +03:00
endif
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
Makefile-tests.am: make check uses the built binaries The tests suite was failing locally as it was using the installed version of rofiles-fuse, instead of the built one. Create the needed symlinks in tests/ as we are already doing for the "ostree" binary. ostree-prepare-root and ostree-remount added for completeness. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Closes: #395 Approved by: cgwalters
2016-07-14 14:42:32 +03:00
uninstalled_test_data = tests/ostree-symlink-stamp tests/ostree-prepare-root-symlink-stamp \
tests: Don't symlink rofiles-fuse if it's disabled Creating the symlink will cause make to try to build rofiles-fuse, which will fail if it's disabled. Normally I wouldn't disable rofiles-fuse, but it's triggering a hang in our ARM Xenial builder's kernel in splice. I'm sure that's fuse's fault, but for now I just need to disable rofiles-fuse there and found --disable-rofiles-fuse didn't actually work. Closes: #1325 Approved by: cgwalters
2017-11-03 23:13:50 +03:00
tests/ostree-remount-symlink-stamp
tests: Modernize valgrind infrastructure The recent memleak fixes motivated me to look at the bitrotted code to run invocations of `ostree` in the test suite underneath valgrind. There are a few things here. First, update suppressions file from libhif, since I recently worked on it. When running *uninstalled* as we now support, we need `libtool --mode=execute` in the mix so it expands out to the uninstalled binary and we don't valgrind the intermediate shell. However, it's harder than that because we chdir into a tmpdir, which defeats the libtool logic. AFAICS, the only fix for this is to determine the realbin path before we chdir, and then unfortunately we need to change every use of `ostree` to `${OSTREE}` =( Then this immediately breaks for me on RHEL7 because my ancient copy of `valgrind-3.10.0-16.el7.x86_64` is unaware of syscall 306, i.e. `syncfs`. But let's do this first before I dive into that. Closes: #292 Approved by: krnowak
2016-05-11 22:54:48 +03:00
Add --enable-installed-tests=exclusive, fix installed case The major reason to do this is that running tests *both* installed and uninstalled in our CI is a mostly pointless waste of time. Particularly given we have a few expensive tests. We *do* have tests that only run uninstalled (since they require the source code) like `test-symbols.sh`. Hence, add `--enable-installed-tests=exclusive` to mean *only* do installed for most tests. We'll still have uninstalled coverage via the Travis/Debian configs, and we could perhaps do another build with a subset of uninstalled tests, but I'm not really concerned about it. I'd like to do a renewed push for the InstalledTests model since I feel it's just fundamentally better. (`g-d-t-r` kind of sucks, but then so does the automake runner). Also while we're here - fix the CI to use the correct context, which started this mess. Closes: #837 Approved by: dbnicholson
2017-05-08 17:44:43 +03:00
dist_uninstalled_test_scripts = tests/test-symbols.sh tests/coccinelle.sh
# This logic implements ENABLE_INSTALLED_TESTS_EXCLUSIVE; see below.
# The goal here if installed tests are enabled, we explicitly make the
# tests *only* run installed, to avoid having to run them twice in CI.
# This overrides the glib-tap.mk emphasis on doing both, if we'd
# used e.g. `dist_test_scripts`.
dist_test_scripts = $(NULL)
Make P2P API public (no longer experimental) Currently the API that allows P2P operations (e.g. pulling an ostree ref from a LAN or USB source) is hidden behind the configure flag --enable-experimental-api. This commit makes the API public and makes that flag essentially a no-op (leaving it in place in case we want to use it again in the future). The P2P API has been tested over the last several months and proven to work. This means that since we're no longer using the "experimental" feature flag, P2P builds of Flatpak will fail when using versions of OSTree from this commit onwards, until Flatpak is patched in the near future. If you want to build Flatpak < 0.11.8 with P2P enabled and link against OSTree 2018.6, you'll have to patch Flatpak. However, since Flatpak won't yet have a hard dependency on OSTree 2018.6, it needs a new way to determine if the P2P API in OSTree is available, so this commit adds a "p2p" feature flag. This way the feature set is more semantically correct than if we had continued to use the "experimental" feature flag. In addition to making the P2P API public, this commit makes the P2P unit tests run by default, removes the f27-experimental CI instance that's no longer needed, changes a few man pages to reflect the changes, and updates the bash completion script to accept the new commands and options. Closes: #1596 Approved by: cgwalters
2018-05-23 01:55:14 +03:00
test_programs = \
tests/test-bloom \
tests/test-repo-finder-config \
tests/test-repo-finder-mount \
$(NULL)
Add --enable-installed-tests=exclusive, fix installed case The major reason to do this is that running tests *both* installed and uninstalled in our CI is a mostly pointless waste of time. Particularly given we have a few expensive tests. We *do* have tests that only run uninstalled (since they require the source code) like `test-symbols.sh`. Hence, add `--enable-installed-tests=exclusive` to mean *only* do installed for most tests. We'll still have uninstalled coverage via the Travis/Debian configs, and we could perhaps do another build with a subset of uninstalled tests, but I'm not really concerned about it. I'd like to do a renewed push for the InstalledTests model since I feel it's just fundamentally better. (`g-d-t-r` kind of sucks, but then so does the automake runner). Also while we're here - fix the CI to use the correct context, which started this mess. Closes: #837 Approved by: dbnicholson
2017-05-08 17:44:43 +03:00
_installed_or_uninstalled_test_scripts = \
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
tests/test-basic.sh \
Fix TAP syntax in test-basic-user.sh, and run it In its initial commit, Alexander Larsson wrote This works standalone, but unfortunately it breaks in gnome-desktop-testing-runner as /tmp doesn't support xattrs, so it is not installed atm. but we now (a) use /var/tmp, and (b) explicitly skip the test if xattr support is unavailable. So it should be OK to run now. Closes: #652 Approved by: cgwalters
2017-01-19 14:21:58 +03:00
tests/test-basic-user.sh \
Add basic tests for bare-user-only repo modes This is somewhat complicated by such repos only properly supporting some subset of file metadata (uid/gid 0, etc). We fix this by always commiting with filters that make it work. Closes: #750 Approved by: cgwalters
2017-03-26 12:03:47 +03:00
tests/test-basic-user-only.sh \
checkout: Merge union/add logic for copies during checkout We really have an astonishing variety of similar functions which write files and symlinks. I was working on a different PR and the duplication between the union-mode and add-mode/none-mode checkout functions bothered me. I realized that the "handle EEXIST" tri-state maps directly to the `GLnxLinkTmpfileReplaceMode`, so deduping things makes even more sense. Closes: #801 Approved by: jlebon
2017-04-18 19:41:40 +03:00
tests/test-basic-root.sh \
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
tests/test-pull-subpath.sh \
tests/test-archivez.sh \
tests/test-remote-add.sh \
pull: Add support for `http-headers` option Some deployments may want to gate access to content based on things like OAuth. In this model, the client system would normally compute a token and pass it to the server via an API. We could theoretically support this in the remote config too, but that'd be a bit weird for OAuth as the information is dynamic. Therefore this cleans up the code a little bit to more clearly handle the case that the fetcher is initialized from both remote config data plus pull options. Closes: #574 Approved by: giuseppe
2016-11-16 05:03:26 +03:00
tests/test-remote-headers.sh \
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
tests/test-commit-sign.sh \
tests/test-export.sh \
tests/test-help.sh \
tests/test-libarchive.sh \
Add test case for inheriting remote options Closes: #236 Approved by: cgwalters
2016-04-01 11:20:34 +03:00
tests/test-parent.sh \
tests: Run pull tests for bare/bare-user We have variants of `test-basic` for all 4 modes, but not for pull-test, which for some reason was named `pull-archive`, but mostly pulls *into* bare repos. The test code was structured like the basic one where it called into a `pull-test.sh`, so let's actually use it for 2/3 bare modes. (I tried to extend it to `bare-user-only` but it failed, going to look at that after this). This is related to https://github.com/ostreedev/ostree/issues/991 Closes: #998 Approved by: jlebon
2017-07-10 04:46:23 +03:00
tests/test-pull-bare.sh \
tests/test-pull-bareuser.sh \
tests: Add test-pull-bareuseronly I was going to fix a bug in the static deltas code and I noticed we were missing `pull-test.sh` coverage for bareuseronly 🙈. Obviously fixing this requires duplicating some of the bits we have in `basic-test.sh`; need to hoist that into `libtest.sh`. For now though let's get the coverage. Closes: #1270 Approved by: jlebon
2017-10-14 01:14:17 +03:00
tests/test-pull-bareuseronly.sh \
tests: Add a "pull-test2" that uses slightly more realistic content This one actually exercises the delta paths more; I pulled the data from some local F26AH builds. One thing I noticed while doing that is that we try bsdiff on xz'd data, but that won't be useful. https://github.com/projectatomic/rpm-ostree/issues/470 https://bugzilla.redhat.com/show_bug.cgi?id=1367496 Anyways I verified this test fails without the fixup for `pread()` in https://github.com/ostreedev/ostree/pull/1312 Closes: #1314 Approved by: jlebon
2017-10-30 21:17:10 +03:00
tests/test-pull2-bareuseronly.sh \
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
tests/test-pull-commit-only.sh \
tests/test-pull-depth.sh \
tests/test-pull-mirror-summary.sh \
tests/test-pull-large-metadata.sh \
tests/test-pull-metalink.sh \
tests/test-pull-summary-sigs.sh \
tests/test-pull-resume.sh \
tests: Add some test coverage of repeated pulls w/HTTP 500s Systems like pulp may want to keep retrying in a loop if the server throws a (hopefully transient) 500, and we need test coverage of handling these errors versus our existing 404 and 206 coverage. Closes: #383 Approved by: mbarnes
2016-07-08 00:39:07 +03:00
tests/test-pull-repeated.sh \
Add --untrusted option to pull and pull-local https://bugzilla.gnome.org/show_bug.cgi?id=764125 Closes: #221 Approved by: cgwalters
2016-03-23 14:32:03 +03:00
tests/test-pull-untrusted.sh \
tests: Add a test for ostree pull --url Closes: #271 Approved by: cgwalters
2016-04-22 15:41:04 +03:00
tests/test-pull-override-url.sh \
Add "pull --localcache-repo" This is a lot like `git clone --reference`, but we chose "localcache" as the term "reference" is already used. The main use case I'm targeting this for is the Fedora Atomic Host installer case where we embed the repo content in the installer, but we may want to kickstart and download newer content. There, while we want to get a newer ref, we can still use the local repo as an object cache, since we have it sitting there in memory anyways. Another case is where one has a host ostree (say e.g. Fedora Atomic Workstation), and one wants to create a local archive mirror of FAH. Then one can use `pull --reference /ostree/repo` and pull the common objects (e.g. contents of `bash.rpm` etc.) Closes: https://github.com/ostreedev/ostree/issues/975 Closes: #982 Approved by: jlebon
2017-06-29 05:19:15 +03:00
tests/test-pull-localcache.sh \
Fix local-pull test This was not being run for whatever reason. Also, the test count was wrong. Closes: #237 Approved by: cgwalters
2016-04-04 15:43:33 +03:00
tests/test-local-pull.sh \
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
tests/test-local-pull-depth.sh \
tests/test-admin-upgrade-unconfigured.sh \
Allow commits to mark refs as EOL, replaced by others A commit can now include a "ostree.endoflife-rebase" metadata key pointing to a new ref. When updating, the sysroot upgrader will see this and proceed to pull and deploy the new ref instead. The origin file in the new deployment will point to the new ref. This functionality is planned to be used in Endless OS. We will create a lesser tested branch for brand new, cutting edge hardware support, and ship that on hardware platforms that require the latest drivers. However, once our slower-moving official release is later updated to support the new hardware, we will use this functionality to migrate those bleeding-edge users over to the official release. Closes: #874 Approved by: cgwalters
2017-05-15 21:13:38 +03:00
tests/test-admin-upgrade-endoflife.sh \
deploy: Delete .updated file from /etc and /var on new deployments Systemd units using ConditionNeedsUpdate run if the mtime of .updated in the specified directory is newer than /usr. Since /usr has an mtime of 0, there's no way to have an older .updated file. Systemd units typically specify ConditionNeedsUpdate=/etc or ConditionNeedsUpdate=/var to support stateless systems like ostree. Remove the file from the new deployment's /etc and the OS's /var regardless of where they came from to ensure that these systemd units run when booting new deployments. This will provide a method to run services only on upgrade. Closes: #1628 https://bugzilla.gnome.org/show_bug.cgi?id=752950 Closes: #1631 Approved by: cgwalters
2015-07-25 19:51:14 +03:00
tests/test-admin-upgrade-systemd-update.sh \
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
tests/test-admin-deploy-syslinux.sh \
tests/test-admin-deploy-2.sh \
tests/test-admin-deploy-karg.sh \
tests/test-admin-deploy-switch.sh \
tests/test-admin-deploy-etcmerge-cornercases.sh \
tests/test-admin-deploy-uboot.sh \
Introducing ostree-grub-generator ostree-grub-generator can be used to customize the generated grub.cfg file. Compile time decision ostree-grub-generator vs grub2-mkconfig can be overwritten with the OSTREE_GRUB2_EXEC envvar - useful for auto tests and OS installers. Why this alternative approach: 1) The current approach is less flexible than using a custom 'ostree-grub-generator' script. Each system can adjust this script for its needs, instead of using the hardcoded values from ostree-bootloader-grub2.c. 2) Too much overhead on embedded to generate grub.cfg via /etc/grub.d/ configuration files. It is still possible to do so, even with this patch applied. No need to install grub2 package on a target device. 3) The grub2-mkconfig code path has other issues: https://bugzilla.gnome.org/show_bug.cgi?id=761180 Task: https://bugzilla.gnome.org/show_bug.cgi?id=762220 Closes: #228 Approved by: cgwalters
2016-04-01 14:51:18 +03:00
tests/test-admin-deploy-grub2.sh \
Add sysroot.bootloader repo config key The sysroot.bootloader key configures the bootloader that OSTree uses when deploying a sysroot. Having this key allows specifying behavior not to use the default bootloader backend code, which is preferable when creating a first deployment from the sysroot (#1774). As of now, the key can take the values "auto" or "none". If the key is not given, the value defaults to "auto". "auto" causes _ostree_sysroot_query_bootloader() to be used when writing a new deployment, which is the original behavior that dynamically detects which bootloader to use. "none" avoids querying the bootloader dynamically. The BLS config fragments are still written to sysroot/boot/loader/entries for use by higher-level software. More values can be supported in future to specify a single bootloader, different behavior for the bootloader code, or a list of bootloaders to try. Resolves: #1774 Closes: #1814 Approved by: jlebon
2019-02-15 00:18:01 +03:00
tests/test-admin-deploy-none.sh \
repo: Clean up staging directory for previous boot IDs We had a policy of cleaning up all files in `$repo/tmp` older than one day, but we should really clean up previous bootid staging directories too, as they can potentially take up a lot of disk space. https://bugzilla.gnome.org/show_bug.cgi?id=760531 Closes: #170 Approved by: jlebon
2016-01-13 19:33:54 +03:00
tests/test-admin-deploy-bootid-gc.sh \
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
tests/test-admin-instutil-set-kargs.sh \
tests/test-admin-upgrade-not-backwards.sh \
tests/test-admin-pull-deploy-commit.sh \
upgrade: Add support for --pull-only and --deploy-only This makes it easier to script downloading updates in the background, and only do deployments just before rebooting. Partially addresses https://github.com/ostreedev/ostree/issues/640 Closes: #642 Approved by: jlebon
2017-01-05 19:29:41 +03:00
tests/test-admin-pull-deploy-split.sh \
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
tests/test-admin-locking.sh \
tests/test-admin-deploy-clean.sh \
tests/test-reset-nonlinear.sh \
tests/test-oldstyle-partial.sh \
tests/test-delta.sh \
tests/test-xattrs.sh \
tests/test-auto-summary.sh \
tests/test-prune.sh \
tests: Test concurrent operations Test that concurrent commits and prunes can succeed. Mostly this is a check that the new locking works correctly and the concurrent processes will properly wait until they've acquired the appropriate repository lock. Closes: #1343 Approved by: cgwalters
2017-10-14 03:50:28 +03:00
tests/test-concurrency.py \
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
tests/test-refs.sh \
docs: Add a section on writing buildsystems And add a test that is a demo buildsystem.
2016-03-04 05:17:53 +03:00
tests/test-demo-buildsystem.sh \
tests: Add basic tests for ostree-prepare-root These tests use unshare and mount to prepare a fake initrd/early boot directory structure so we can then test ostree-prepare-root. Things that are tested: * Running in an initrd environment * Running without initrd * /var and /sysroot being mounted correctly * /usr being mounted read-only Things not tested (yet): * Running as init - this could be accomplished by unsharing the pid namespace too. * mounting/unmounting `/proc` if `/proc/cmdline` isn't available * Persistent overlayfs for `/usr` * Probably other things The tests are basic but can be extended in the future as we do more work on `ostree-prepare-root`. These tests must be run as root as they require the ability to `mount` and to `unshare` the mount namespace. Perhaps in the future we can use user namespaces for this test once they are more widely available. Closes: #403 Approved by: cgwalters
2016-07-27 18:40:05 +03:00
tests/test-switchroot.sh \
tests: add tests for contenturl and mirrorlist Closes: #469 Approved by: cgwalters
2016-08-25 22:34:34 +03:00
tests/test-pull-contenturl.sh \
tests/test-pull-mirrorlist.sh \
ostree/summary: Add support for adding additional metadata When updating a summary file, parse additional arguments to the `ostree summary` command as additional metadata to be put into the summary. Add some tests for this. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #961 Approved by: cgwalters
2017-06-22 17:16:53 +03:00
tests/test-summary-update.sh \
tests: Add a test for `ostree summary --view` This includes a test of the new human-readable key names. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #826 Approved by: cgwalters
2017-05-07 20:55:29 +03:00
tests/test-summary-view.sh \
Support for booting without initramfs Previously when initramfs-* was not found in a deployment's boot directory, it was assumed that rootfs is prepared for ostree booting by a kernel patch. With this patch, the behaviour changes to be - if initramfs-* is not found, assume that system is using a static ostree-prepare-root as init process. Booting without initramfs is a common use case on embedded systems. This approach is also more convenient, than having to patch the kernel. Closes: #1401 Approved by: cgwalters
2016-08-24 14:26:47 +03:00
tests/test-no-initramfs.sh \
create-usb: Add a create-usb command to complement OstreeRepoFinderMount This can be used to put OSTree repositories on USB sticks in a format recognised by OstreeRepoFinderMount. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #1182 Approved by: cgwalters
2017-09-15 18:05:12 +03:00
tests/test-create-usb.sh \
tests: Add integration tests for collections Test various pieces of core and command line utility functionality relating to the newly-introduced concept of collections. Mostly focussed around the find-remotes utility, and around handling of collection–refs. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #924 Approved by: cgwalters
2017-06-13 20:55:53 +03:00
tests/test-find-remotes.sh \
tests/test-fsck-collections.sh \
tests/test-init-collections.sh \
tests/test-prune-collections.sh \
tests/test-refs-collections.sh \
tests/test-remote-add-collections.sh \
tests: Add a manual integration test for OstreeRepoFinderMount Test an end-to-end flow of pulling refs from an online repository → local OS repository → create a USB stick of them → pull to a local OS repository on another machine. This is a manual test, as it requires a throwaway USB stick which the test can format as ext4 or vfat to test the flow works with both file systems. Run it as: MOUNT_INTEGRATION_DEV=/dev/sdb1 make check \ TESTS=tests/test-repo-finder-mount-integration.sh Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #1203 Approved by: cgwalters
2017-09-18 17:43:41 +03:00
tests/test-repo-finder-mount-integration.sh \
tests: Add integration tests for collections Test various pieces of core and command line utility functionality relating to the newly-introduced concept of collections. Mostly focussed around the find-remotes utility, and around handling of collection–refs. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #924 Approved by: cgwalters
2017-06-13 20:55:53 +03:00
tests/test-summary-collections.sh \
tests: New tests for creating commits with bindings and pulling them Closes: #972 Approved by: cgwalters
2017-06-28 13:46:02 +03:00
tests/test-pull-collections.sh \
src/ostree: Add --group option to ostree config Fetching value from a repo config using 'ostree config get SECTIONNAME.KEYNAME' didn't work in some cases like when having dots in Group Name entry. As per Desktop entry file specification, Group Name may contain all ASCII characters except for [ and ] and control characters. Link - https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-1.1.html Having --group option will help user to clearly specify Group Name and get desired result. It also adds test for ostree config get|set and bash completion for --group option Fixes https://github.com/ostreedev/ostree/issues/1565 Closes: #1696 Approved by: cgwalters
2018-08-17 18:55:56 +03:00
tests/test-config.sh \
tests: Add integration tests for collections Test various pieces of core and command line utility functionality relating to the newly-introduced concept of collections. Mostly focussed around the find-remotes utility, and around handling of collection–refs. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #924 Approved by: cgwalters
2017-06-13 20:55:53 +03:00
$(NULL)
Make P2P API public (no longer experimental) Currently the API that allows P2P operations (e.g. pulling an ostree ref from a LAN or USB source) is hidden behind the configure flag --enable-experimental-api. This commit makes the API public and makes that flag essentially a no-op (leaving it in place in case we want to use it again in the future). The P2P API has been tested over the last several months and proven to work. This means that since we're no longer using the "experimental" feature flag, P2P builds of Flatpak will fail when using versions of OSTree from this commit onwards, until Flatpak is patched in the near future. If you want to build Flatpak < 0.11.8 with P2P enabled and link against OSTree 2018.6, you'll have to patch Flatpak. However, since Flatpak won't yet have a hard dependency on OSTree 2018.6, it needs a new way to determine if the P2P API in OSTree is available, so this commit adds a "p2p" feature flag. This way the feature set is more semantically correct than if we had continued to use the "experimental" feature flag. In addition to making the P2P API public, this commit makes the P2P unit tests run by default, removes the f27-experimental CI instance that's no longer needed, changes a few man pages to reflect the changes, and updates the bash completion script to accept the new commands and options. Closes: #1596 Approved by: cgwalters
2018-05-23 01:55:14 +03:00
build: Conditionally build the GPG-related tests Do not build GPG signing/verification tests if `--without-gpgme` option is used during configuration. Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com> Closes: #1889 Approved by: cgwalters
2019-05-21 01:23:14 +03:00
if USE_GPGME
_installed_or_uninstalled_test_scripts += \
tests/test-remote-gpg-import.sh \
tests/test-gpg-signed-commit.sh \
tests/test-admin-gpg.sh \
$(NULL)
endif
Make P2P API public (no longer experimental) Currently the API that allows P2P operations (e.g. pulling an ostree ref from a LAN or USB source) is hidden behind the configure flag --enable-experimental-api. This commit makes the API public and makes that flag essentially a no-op (leaving it in place in case we want to use it again in the future). The P2P API has been tested over the last several months and proven to work. This means that since we're no longer using the "experimental" feature flag, P2P builds of Flatpak will fail when using versions of OSTree from this commit onwards, until Flatpak is patched in the near future. If you want to build Flatpak < 0.11.8 with P2P enabled and link against OSTree 2018.6, you'll have to patch Flatpak. However, since Flatpak won't yet have a hard dependency on OSTree 2018.6, it needs a new way to determine if the P2P API in OSTree is available, so this commit adds a "p2p" feature flag. This way the feature set is more semantically correct than if we had continued to use the "experimental" feature flag. In addition to making the P2P API public, this commit makes the P2P unit tests run by default, removes the f27-experimental CI instance that's no longer needed, changes a few man pages to reflect the changes, and updates the bash completion script to accept the new commands and options. Closes: #1596 Approved by: cgwalters
2018-05-23 01:55:14 +03:00
experimental_test_scripts = \
$(NULL)
tests: Assert that byte-order is swapped on LE but not BE CPUs Closes: #1392 Signed-off-by: Simon McVittie <smcv@collabora.com> Closes: #1393 Approved by: cgwalters
2018-01-03 11:23:10 +03:00
test_extra_programs = \
tests/get-byte-order \
Make P2P API public (no longer experimental) Currently the API that allows P2P operations (e.g. pulling an ostree ref from a LAN or USB source) is hidden behind the configure flag --enable-experimental-api. This commit makes the API public and makes that flag essentially a no-op (leaving it in place in case we want to use it again in the future). The P2P API has been tested over the last several months and proven to work. This means that since we're no longer using the "experimental" feature flag, P2P builds of Flatpak will fail when using versions of OSTree from this commit onwards, until Flatpak is patched in the near future. If you want to build Flatpak < 0.11.8 with P2P enabled and link against OSTree 2018.6, you'll have to patch Flatpak. However, since Flatpak won't yet have a hard dependency on OSTree 2018.6, it needs a new way to determine if the P2P API in OSTree is available, so this commit adds a "p2p" feature flag. This way the feature set is more semantically correct than if we had continued to use the "experimental" feature flag. In addition to making the P2P API public, this commit makes the P2P unit tests run by default, removes the f27-experimental CI instance that's no longer needed, changes a few man pages to reflect the changes, and updates the bash completion script to accept the new commands and options. Closes: #1596 Approved by: cgwalters
2018-05-23 01:55:14 +03:00
tests/repo-finder-mount \
tests: Assert that byte-order is swapped on LE but not BE CPUs Closes: #1392 Signed-off-by: Simon McVittie <smcv@collabora.com> Closes: #1393 Approved by: cgwalters
2018-01-03 11:23:10 +03:00
$(NULL)
tests_get_byte_order_SOURCES = tests/get-byte-order.c
tests_get_byte_order_CFLAGS = $(AM_CFLAGS) $(GLIB_CFLAGS)
tests_get_byte_order_LDADD = $(GLIB_LIBS)
create-usb: Add a create-usb command to complement OstreeRepoFinderMount This can be used to put OSTree repositories on USB sticks in a format recognised by OstreeRepoFinderMount. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #1182 Approved by: cgwalters
2017-09-15 18:05:12 +03:00
tests_repo_finder_mount_SOURCES = tests/repo-finder-mount.c
tests_repo_finder_mount_CFLAGS = $(common_tests_cflags)
tests_repo_finder_mount_LDADD = $(common_tests_ldadd) libostreetest.la
build: Ensure all experimental tests are distributed in tarballs As with the previous commit, ensure that tests which are run when configured with --enable-experimental-api, are always distributed; even when running `make dist` from a source tree configured with --disable-experimental-api. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #1002 Approved by: cgwalters
2017-07-12 17:04:34 +03:00
if ENABLE_EXPERIMENTAL_API
_installed_or_uninstalled_test_scripts += $(experimental_test_scripts)
else
EXTRA_DIST += $(experimental_test_scripts)
tests: Add integration tests for collections Test various pieces of core and command line utility functionality relating to the newly-introduced concept of collections. Mostly focussed around the find-remotes utility, and around handling of collection–refs. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #924 Approved by: cgwalters
2017-06-13 20:55:53 +03:00
endif
Import rofiles-fuse While it's not strictly tied to OSTree, let's move https://github.com/cgwalters/rofiles-fuse in here because: - It's *very* useful in concert with OSTree - It's tiny - We can reuse OSTree's test, documentation, etc. infrastructure One thing to consider also is that at some point we could experiment with writing a FUSE filesystem for OSTree. This could internalize a better equivalent of `--link-checkout-speedup`, but on the other hand, the cost of walking filesystem trees for these types of operations is really quite small. But if we did decide to do more FUSE things in OSTree, this is a step towards that too.
2016-02-10 14:42:54 +03:00
if BUILDOPT_FUSE
Add --enable-installed-tests=exclusive, fix installed case The major reason to do this is that running tests *both* installed and uninstalled in our CI is a mostly pointless waste of time. Particularly given we have a few expensive tests. We *do* have tests that only run uninstalled (since they require the source code) like `test-symbols.sh`. Hence, add `--enable-installed-tests=exclusive` to mean *only* do installed for most tests. We'll still have uninstalled coverage via the Travis/Debian configs, and we could perhaps do another build with a subset of uninstalled tests, but I'm not really concerned about it. I'd like to do a renewed push for the InstalledTests model since I feel it's just fundamentally better. (`g-d-t-r` kind of sucks, but then so does the automake runner). Also while we're here - fix the CI to use the correct context, which started this mess. Closes: #837 Approved by: dbnicholson
2017-05-08 17:44:43 +03:00
_installed_or_uninstalled_test_scripts += tests/test-rofiles-fuse.sh
tests: Don't symlink rofiles-fuse if it's disabled Creating the symlink will cause make to try to build rofiles-fuse, which will fail if it's disabled. Normally I wouldn't disable rofiles-fuse, but it's triggering a hang in our ARM Xenial builder's kernel in splice. I'm sure that's fuse's fault, but for now I just need to disable rofiles-fuse there and found --disable-rofiles-fuse didn't actually work. Closes: #1325 Approved by: cgwalters
2017-11-03 23:13:50 +03:00
uninstalled_test_data += tests/rofiles-fuse-symlink-stamp
Distribute test scripts even if we wouldn't run them This fixes a "make dist" tarball produced on a minimal system and run on a non-minimal system. Automake knows that files that are only conditionally included in dist_whatever_WHATEVER are to be distributed, but it does not do the same for files that are only conditionally included in EXTRA_DIST, which is how glib-tap.mk's various variables like dist_test_scripts work. Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #557 Approved by: cgwalters
2016-10-08 01:09:29 +03:00
else
EXTRA_DIST += tests/test-rofiles-fuse.sh
Import rofiles-fuse While it's not strictly tied to OSTree, let's move https://github.com/cgwalters/rofiles-fuse in here because: - It's *very* useful in concert with OSTree - It's tiny - We can reuse OSTree's test, documentation, etc. infrastructure One thing to consider also is that at some point we could experiment with writing a FUSE filesystem for OSTree. This could internalize a better equivalent of `--link-checkout-speedup`, but on the other hand, the cost of walking filesystem trees for these types of operations is really quite small. But if we did decide to do more FUSE things in OSTree, this is a step towards that too.
2016-02-10 14:42:54 +03:00
endif
build: Make libsoup optional again The "remote cookies" code broke this. While I'm not sure anyone is actually using ostree-without-http, it isn't too hard to keep the build time conditional going. Further, this work is preparatory for libcurl porting. Closes: #621 Approved by: jlebon
2016-12-08 05:16:52 +03:00
if USE_LIBSOUP
Add --enable-installed-tests=exclusive, fix installed case The major reason to do this is that running tests *both* installed and uninstalled in our CI is a mostly pointless waste of time. Particularly given we have a few expensive tests. We *do* have tests that only run uninstalled (since they require the source code) like `test-symbols.sh`. Hence, add `--enable-installed-tests=exclusive` to mean *only* do installed for most tests. We'll still have uninstalled coverage via the Travis/Debian configs, and we could perhaps do another build with a subset of uninstalled tests, but I'm not really concerned about it. I'd like to do a renewed push for the InstalledTests model since I feel it's just fundamentally better. (`g-d-t-r` kind of sucks, but then so does the automake runner). Also while we're here - fix the CI to use the correct context, which started this mess. Closes: #837 Approved by: dbnicholson
2017-05-08 17:44:43 +03:00
_installed_or_uninstalled_test_scripts += tests/test-remote-cookies.sh
build: Make libsoup optional again The "remote cookies" code broke this. While I'm not sure anyone is actually using ostree-without-http, it isn't too hard to keep the build time conditional going. Further, this work is preparatory for libcurl porting. Closes: #621 Approved by: jlebon
2016-12-08 05:16:52 +03:00
endif
Add --enable-installed-tests=exclusive, fix installed case The major reason to do this is that running tests *both* installed and uninstalled in our CI is a mostly pointless waste of time. Particularly given we have a few expensive tests. We *do* have tests that only run uninstalled (since they require the source code) like `test-symbols.sh`. Hence, add `--enable-installed-tests=exclusive` to mean *only* do installed for most tests. We'll still have uninstalled coverage via the Travis/Debian configs, and we could perhaps do another build with a subset of uninstalled tests, but I'm not really concerned about it. I'd like to do a renewed push for the InstalledTests model since I feel it's just fundamentally better. (`g-d-t-r` kind of sucks, but then so does the automake runner). Also while we're here - fix the CI to use the correct context, which started this mess. Closes: #837 Approved by: dbnicholson
2017-05-08 17:44:43 +03:00
# These call into gjs scripts
Skip gjs-based tests if ASAN is enabled Unfortunately, introspection uses dlopen(), which doesn't quite work when the DSO is compiled with ASAN but the outer executable isn't. Trying to inject LD_PRELOAD=libasan means the outer executable has to be leak free...which, yeah, I'm not going to get into running ASAN today on gjs or pygobject. So, let's skip those tests - ideally, we still run them in some other context without the sanitizers. The coverage we have from them is middling anyways. Closes: #622 Approved by: jlebon
2016-12-08 05:59:40 +03:00
js_tests = tests/test-corruption.sh tests/test-pull-corruption.sh
tests: Only install test-corruption if gjs is found It now uses a gjs-based helper.
2014-01-21 23:53:06 +04:00
if BUILDOPT_GJS
Add --enable-installed-tests=exclusive, fix installed case The major reason to do this is that running tests *both* installed and uninstalled in our CI is a mostly pointless waste of time. Particularly given we have a few expensive tests. We *do* have tests that only run uninstalled (since they require the source code) like `test-symbols.sh`. Hence, add `--enable-installed-tests=exclusive` to mean *only* do installed for most tests. We'll still have uninstalled coverage via the Travis/Debian configs, and we could perhaps do another build with a subset of uninstalled tests, but I'm not really concerned about it. I'd like to do a renewed push for the InstalledTests model since I feel it's just fundamentally better. (`g-d-t-r` kind of sucks, but then so does the automake runner). Also while we're here - fix the CI to use the correct context, which started this mess. Closes: #837 Approved by: dbnicholson
2017-05-08 17:44:43 +03:00
_installed_or_uninstalled_test_scripts += $(js_tests)
Distribute test scripts even if we wouldn't run them This fixes a "make dist" tarball produced on a minimal system and run on a non-minimal system. Automake knows that files that are only conditionally included in dist_whatever_WHATEVER are to be distributed, but it does not do the same for files that are only conditionally included in EXTRA_DIST, which is how glib-tap.mk's various variables like dist_test_scripts work. Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #557 Approved by: cgwalters
2016-10-08 01:09:29 +03:00
else
EXTRA_DIST += $(js_tests)
tests: Only install test-corruption if gjs is found It now uses a gjs-based helper.
2014-01-21 23:53:06 +04:00
endif
build: distribute test scripts in tarballs Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 12:39:46 +03:00
dist_installed_test_data = tests/archive-test.sh \
Install tests Matching https://live.gnome.org/GnomeGoals/InstalledTests
2013-05-01 23:26:21 +04:00
tests/pull-test.sh \
tests: Add a "pull-test2" that uses slightly more realistic content This one actually exercises the delta paths more; I pulled the data from some local F26AH builds. One thing I noticed while doing that is that we try bsdiff on xz'd data, but that won't be useful. https://github.com/projectatomic/rpm-ostree/issues/470 https://bugzilla.redhat.com/show_bug.cgi?id=1367496 Anyways I verified this test fails without the fixup for `pread()` in https://github.com/ostreedev/ostree/pull/1312 Closes: #1314 Approved by: jlebon
2017-10-30 21:17:10 +03:00
tests/pull-test2.sh \
Unify uboot and syslinux test cases The test-admin-deploy-1 was copied into -uboot at some point. But really they should be testing exactly the same thing, except for the bootloader backend. Unify these tests by extracting a common test core.
2014-01-15 18:48:04 +04:00
tests/admin-test.sh \
Split out basic tests from test-basic.sh This will let us reuse them with other repo types https://bugzilla.gnome.org/show_bug.cgi?id=741125
2014-12-05 16:28:16 +03:00
tests/basic-test.sh \
deltas: Heuristically detect endianness for older deltas If the average object size is greater than 4GiB, let's assume we're dealing with opposite endianness. I'm fairly confident no one is going to be shipping peta- or exa- byte size ostree deltas, period. Past the gigabyte scale you really want bittorrent or something.
2016-02-25 01:04:04 +03:00
tests/pre-endian-deltas-repo-big.tar.xz \
tests/pre-endian-deltas-repo-little.tar.xz \
tests: Add a "pull-test2" that uses slightly more realistic content This one actually exercises the delta paths more; I pulled the data from some local F26AH builds. One thing I noticed while doing that is that we try bsdiff on xz'd data, but that won't be useful. https://github.com/projectatomic/rpm-ostree/issues/470 https://bugzilla.redhat.com/show_bug.cgi?id=1367496 Anyways I verified this test fails without the fixup for `pread()` in https://github.com/ostreedev/ostree/pull/1312 Closes: #1314 Approved by: jlebon
2017-10-30 21:17:10 +03:00
tests/fah-deltadata-old.tar.xz \
tests/fah-deltadata-new.tar.xz \
tests: Add a test case for path traversal in a dirtree I was reading about a recent security issue with both EMC and VMWare: https://arstechnica.com/information-technology/2018/01/emc-vmware-security-bugs-throw-gasoline-on-cloud-security-fire/ It's a classic path traversal problem, and that made me think more about our handling of this in libostree. Fortunately of course, not being new to this rodeo, long ago I *did* consider path traversal. Inside the pull code, we call `ot_util_filename_validate()`. Also, `fsck` does this too. I have further followups here, but let's add some test cases for this. I crafted a repository with a `../` in a dirtree object by patching libostree to inject it, and that's included as a tarball. This patch covers the two cases where we do already have checks; pulling via HTTP, and in `fsck`. Closes: #1412 Approved by: jlebon
2018-01-12 17:01:52 +03:00
tests/ostree-path-traverse.tar.gz \
tests: Install libtest-core.sh with installed tests Without this, running the installed tests fails dramatically. Remove it from EXTRA_DIST since dist_installed_test_data takes care of dist. Closes: #837 Approved by: dbnicholson
2017-05-04 22:16:21 +03:00
tests/libtest-core.sh \
Install tests Matching https://live.gnome.org/GnomeGoals/InstalledTests
2013-05-01 23:26:21 +04:00
$(NULL)
tests: Install libtest-core.sh with installed tests Without this, running the installed tests fails dramatically. Remove it from EXTRA_DIST since dist_installed_test_data takes care of dist. Closes: #837 Approved by: dbnicholson
2017-05-04 22:16:21 +03:00
EXTRA_DIST += tests/libtest.sh
tests: Tweak installed tests to deal with ASAN We need to disable readdir-rand there too. Closes: #622 Approved by: jlebon
2016-12-08 20:50:20 +03:00
Make corrupt-repo-ref.js executable Debian's Lintian packaging consistency check complains that it isn't executable but has a #! line. In fact it's reasonable to run this script directly, so make it executable, and put it in a _scripts variable so it will be installed executable. Closes: #652 Approved by: cgwalters
2017-01-19 14:34:57 +03:00
dist_test_extra_scripts = \
tests/bootloader-entries-crosscheck.py \
tests/corrupt-repo-ref.js \
tests/ostree-grub-generator \
$(NULL)
tests: Add a crosscheck for syslinux bootloader config generation And actually wire this one up in admin-test.sh.
2015-05-28 03:08:44 +03:00
build: Conditionally build the GPG-related tests Do not build GPG signing/verification tests if `--without-gpgme` option is used during configuration. Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com> Closes: #1889 Approved by: cgwalters
2019-05-21 01:23:14 +03:00
if USE_GPGME
build: Don't install test data without --enable-installed-tests Otherwise $(installed_testdir) is empty so we try to put content in `/`, which I noticed when trying to build an RPM (it works works fine `sudo make install`).
2016-03-08 21:12:00 +03:00
# We can't use nobase_ as we need to strip off the tests/, can't
# use plain installed_ as we do need the gpghome/ prefix.
if ENABLE_INSTALLED_TESTS
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
gpginsttestdir = $(installed_testdir)/gpghome
build: distribute more test files Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 12:45:48 +03:00
dist_gpginsttest_DATA = tests/gpghome/secring.gpg \
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
tests/gpghome/pubring.gpg \
tests: Add test-remote-gpg-import.sh
2015-05-07 20:42:19 +03:00
tests/gpghome/trustdb.gpg \
tests/gpghome/key1.asc \
tests/gpghome/key2.asc \
tests/gpghome/key3.asc
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
gpginsttest_trusteddir = $(installed_testdir)/gpghome/trusted
build: distribute more test files Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 12:45:48 +03:00
dist_gpginsttest_trusted_DATA = tests/gpghome/trusted/pubring.gpg
tests: Fix up GPG tests for more strict EL7 GPG These GPG tests were failing for me on EL7 - it appears to be because we had only one directory for both private and public keys, and we were giving that to ostree for verification, which passed them onto gpgv. In EL7 beta at least, gpgv now barfs if it finds a private key where it is just expecting to find public keys. Fix this by splitting out the public trusted directory from the private key directory. Except now for signing, we still need the public key there, so symlink it. Whee!
2014-02-10 18:38:07 +04:00
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
gpgvinsttestdir = $(installed_testdir)/gpg-verify-data
build: distribute more test files Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 12:45:48 +03:00
dist_gpgvinsttest_DATA = $(addprefix tests/gpg-verify-data/, \
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
gpg.conf lgpl2 lgpl2.sig pubring.gpg secring.gpg trustdb.gpg)
build: Don't install test data without --enable-installed-tests Otherwise $(installed_testdir) is empty so we try to put content in `/`, which I noticed when trying to build an RPM (it works works fine `sudo make install`).
2016-03-08 21:12:00 +03:00
endif
build: Conditionally build the GPG-related tests Do not build GPG signing/verification tests if `--without-gpgme` option is used during configuration. Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com> Closes: #1889 Approved by: cgwalters
2019-05-21 01:23:14 +03:00
endif
tests: Restore accidentally deleted Makefile bit Not sure how this got deleted...
2015-02-16 18:29:14 +03:00
Distribute test scripts even if we wouldn't run them This fixes a "make dist" tarball produced on a minimal system and run on a non-minimal system. Automake knows that files that are only conditionally included in dist_whatever_WHATEVER are to be distributed, but it does not do the same for files that are only conditionally included in EXTRA_DIST, which is how glib-tap.mk's various variables like dist_test_scripts work. Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #557 Approved by: cgwalters
2016-10-08 01:09:29 +03:00
js_installed_tests = \
tests/test-core.js \
repo: Fix non-system remotes-config-dir usage Before commit e0346c1, a non-system repo could specify remotes-config-dir and have remotes read from there. However, adding remotes would only be done in the config dir for a system repo. Restore that by respecting remotes-config-dir when no sysroot is found and adding back the ostree_repo_is_system() check when adding remotes. Closes: #1133 Closes: #1151 Approved by: cgwalters
2017-09-07 22:02:51 +03:00
tests/test-remotes-config-dir.js \
core: Add size information to commit metadata Add a --generate-sizes option to commit to add size information to the commit metadata. This will be used by higher level code which wants to determine the total size necessary for downloading.
2013-10-09 06:44:39 +04:00
tests/test-sizes.js \
Revert "Disable test-sysroot.test" This reverts commit 73868a96d14fa13e69d9df778d2363b89f41fef5.
2014-03-19 17:15:29 +04:00
tests/test-sysroot.js \
tests: Add a simple test-sysroot.js that covers OSTree.Sysroot This will be more interesting as a test case user of the API.
2013-10-03 03:47:38 +04:00
$(NULL)
Distribute test scripts even if we wouldn't run them This fixes a "make dist" tarball produced on a minimal system and run on a non-minimal system. Automake knows that files that are only conditionally included in dist_whatever_WHATEVER are to be distributed, but it does not do the same for files that are only conditionally included in EXTRA_DIST, which is how glib-tap.mk's various variables like dist_test_scripts work. Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #557 Approved by: cgwalters
2016-10-08 01:09:29 +03:00
if BUILDOPT_GJS
tests: More fixes for gjs tests Previous to this commit, the gjs tests were installed-only; and our logic for handling the "--enable-installed-tests=exclusive" logic actually also meant they weren't installed. It did work for me locally with `--enable-installed-tests`. However, to make things fully symmetric, let's enable the js tests to also be run under `make check`. Also remove `corrupt-repo-ref.js` from the PAPR invocation since it's not actually a unit test, it's a utility helper. Closes: #1022 Approved by: jlebon
2017-07-20 17:32:44 +03:00
_installed_or_uninstalled_test_scripts += $(js_installed_tests)
Distribute test scripts even if we wouldn't run them This fixes a "make dist" tarball produced on a minimal system and run on a non-minimal system. Automake knows that files that are only conditionally included in dist_whatever_WHATEVER are to be distributed, but it does not do the same for files that are only conditionally included in EXTRA_DIST, which is how glib-tap.mk's various variables like dist_test_scripts work. Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #557 Approved by: cgwalters
2016-10-08 01:09:29 +03:00
else
EXTRA_DIST += $(js_installed_tests)
tests: Add a gjs-based test This covers introspection, and in general is a much better way to get API coverage tests.
2013-09-18 20:01:46 +04:00
endif
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
test_ltlibraries = libreaddir-rand.la
tests: Run all tests through a randomized readdir() Having undefined (but in practice rarely changing) ordering for `readdir()` ended up screwing us over for bootloader config generation; see https://bugzilla.redhat.com/show_bug.cgi?id=1226520 Let's make things significantly more likely to fail more quickly in the future if similar bugs are introduced. We accomplish this by introducing a little `LD_PRELOAD` library that randomizes the results of `readdir()`.
2015-06-02 05:34:14 +03:00
libreaddir_rand_la_SOURCES = tests/readdir-rand.c
build: Fix libreaddir-rand to honor global CFLAGS It's unfortunate that in automake one has to explicitly include the globa `$(AM_CFLAGS)` if one sets `CFLAGS`, and similarly for other variables. I'm trying to use `-fsanitize=address`, and not including it was causing linker failures. We also weren't inheriting the global warnings etc., so I had to fix a decl-after-statement. Closes: #351 Approved by: jlebon
2016-06-17 16:36:51 +03:00
libreaddir_rand_la_CFLAGS = $(AM_CFLAGS) $(OT_INTERNAL_GIO_UNIX_CFLAGS)
Link libreaddir-rand to libdl It uses dlsym(). There's no point in being extra-portable here because OSTree only targets Linux anyway. Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #336 Approved by: cgwalters
2016-06-12 17:25:21 +03:00
libreaddir_rand_la_LIBADD = \
-ldl \
$(OT_INTERNAL_GIO_UNIX_LIBS) \
$(NULL)
build: Fix libreaddir-rand to honor global CFLAGS It's unfortunate that in automake one has to explicitly include the globa `$(AM_CFLAGS)` if one sets `CFLAGS`, and similarly for other variables. I'm trying to use `-fsanitize=address`, and not including it was causing linker failures. We also weren't inheriting the global warnings etc., so I had to fix a decl-after-statement. Closes: #351 Approved by: jlebon
2016-06-17 16:36:51 +03:00
libreaddir_rand_la_LDFLAGS = $(AM_LDFLAGS) -avoid-version
Force libreaddir-rand to be a shared library If installed-tests are disabled, it would normally be a static (convenience) library, which isn't something we can LD_PRELOAD. Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #232 Approved by: cgwalters
2016-03-31 12:17:02 +03:00
if !ENABLE_INSTALLED_TESTS
libreaddir_rand_la_LDFLAGS += -rpath $(abs_builddir)
endif
tests: Run all tests through a randomized readdir() Having undefined (but in practice rarely changing) ordering for `readdir()` ended up screwing us over for bootloader config generation; see https://bugzilla.redhat.com/show_bug.cgi?id=1226520 Let's make things significantly more likely to fail more quickly in the future if similar bugs are introduced. We accomplish this by introducing a little `LD_PRELOAD` library that randomizes the results of `readdir()`.
2015-06-02 05:34:14 +03:00
Add --enable-installed-tests=exclusive, fix installed case The major reason to do this is that running tests *both* installed and uninstalled in our CI is a mostly pointless waste of time. Particularly given we have a few expensive tests. We *do* have tests that only run uninstalled (since they require the source code) like `test-symbols.sh`. Hence, add `--enable-installed-tests=exclusive` to mean *only* do installed for most tests. We'll still have uninstalled coverage via the Travis/Debian configs, and we could perhaps do another build with a subset of uninstalled tests, but I'm not really concerned about it. I'd like to do a renewed push for the InstalledTests model since I feel it's just fundamentally better. (`g-d-t-r` kind of sucks, but then so does the automake runner). Also while we're here - fix the CI to use the correct context, which started this mess. Closes: #837 Approved by: dbnicholson
2017-05-08 17:44:43 +03:00
_installed_or_uninstalled_test_programs = tests/test-varint tests/test-ot-unix-utils tests/test-bsdiff tests/test-mutable-tree \
gpg: Add OstreeGpgVerifyResult Wrappers a referenced gpgme_verify_result_t so detailed verify results can be examined independently of executing a verify operation. _ostree_gpg_verifier_check_signature() now returns this object instead of a single valid/invalid boolean, but the idea is for OstreeRepo to also return this object for commit signature verification so it can be utilized at the CLI layer (and possibly by other programs).
2015-03-04 20:44:47 +03:00
tests/test-keyfile-utils tests/test-ot-opt-utils tests/test-ot-tool-util \
build: Conditionally build the GPG-related tests Do not build GPG signing/verification tests if `--without-gpgme` option is used during configuration. Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com> Closes: #1889 Approved by: cgwalters
2019-05-21 01:23:14 +03:00
tests/test-checksum tests/test-lzma tests/test-rollsum \
lib/kargs: Make API public and upstream new rpm-ostree APIs This change makes public the current kargs API in src/libostree/ostree-kernel-args.c and adds documentations. Upstreams the new kargs API from rpm-ostree/src/libpriv/rpmostree-kargs-process.c Merges libostree_kernel_args_la_SOURCES to libostree_1_la_SOURCES in Makefile-libostree.am Upstreams tests/check/test-kargs.c from rpm-ostree. Closes: #1833 Closes: #1869 Approved by: jlebon
2019-05-28 21:02:54 +03:00
tests/test-basic-c tests/test-sysroot-c tests/test-pull-c tests/test-repo tests/test-include-ostree-h tests/test-kargs
tests: add test for test-ot-opt-utils. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-06 13:38:13 +03:00
build: Conditionally build the GPG-related tests Do not build GPG signing/verification tests if `--without-gpgme` option is used during configuration. Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com> Closes: #1889 Approved by: cgwalters
2019-05-21 01:23:14 +03:00
if USE_GPGME
_installed_or_uninstalled_test_programs += \
tests/test-gpg-verify-result \
$(NULL)
endif
lib/repo-finder: Add Avahi based OstreeRepoFinder implementation This is a more complex implementation of OstreeRepoFinder which resolves ref names to remote URIs by looking for refs advertised by peers on the local network using DNS-SD records and mDNS (Avahi). The idea is to allow OS and app updates to be propagated over local networks, without the internet. It requires an OSTree server and code to generate the DNS-SD adverts in order to be fully functional — support for this will be added separately. Unit tests are included. Includes fixes by Krzesimir Nowak <krzesimir@kinvolk.io>. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #924 Approved by: cgwalters
2017-04-19 02:13:28 +03:00
if USE_AVAHI
test_programs += tests/test-repo-finder-avahi
endif
lib/repo-finder: Add config-file based OstreeRepoFinder implementation This is a basic implementation of OstreeRepoFinder which resolves ref names to remote URIs by looking their collection IDs up in the local configuration of remotes who have their collection-id key set. Unit tests are included. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #924 Approved by: cgwalters
2017-04-19 02:05:06 +03:00
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
# An interactive tool
noinst_PROGRAMS += tests/test-rollsum-cli
repo: Add ostree_repo_import_archive_to_mtree This is a more flexible version of the previous ostree_repo_write_archive_to_mtree() which took a file reference. This has an extensible options structure, and in particular now supports `ignore_unsupported_content`. I plan to use this for importing Docker images which contain device nodes. (There's no reason for container images to have those, so we'll just ignore them). Also here, just like the export variant, the caller is responsible for setting up libarchive.
2016-02-19 00:49:30 +03:00
if USE_LIBARCHIVE
Add --enable-installed-tests=exclusive, fix installed case The major reason to do this is that running tests *both* installed and uninstalled in our CI is a mostly pointless waste of time. Particularly given we have a few expensive tests. We *do* have tests that only run uninstalled (since they require the source code) like `test-symbols.sh`. Hence, add `--enable-installed-tests=exclusive` to mean *only* do installed for most tests. We'll still have uninstalled coverage via the Travis/Debian configs, and we could perhaps do another build with a subset of uninstalled tests, but I'm not really concerned about it. I'd like to do a renewed push for the InstalledTests model since I feel it's just fundamentally better. (`g-d-t-r` kind of sucks, but then so does the automake runner). Also while we're here - fix the CI to use the correct context, which started this mess. Closes: #837 Approved by: dbnicholson
2017-05-08 17:44:43 +03:00
_installed_or_uninstalled_test_programs += tests/test-libarchive-import
repo: Add ostree_repo_import_archive_to_mtree This is a more flexible version of the previous ostree_repo_write_archive_to_mtree() which took a file reference. This has an extensible options structure, and in particular now supports `ignore_unsupported_content`. I plan to use this for importing Docker images which contain device nodes. (There's no reason for container images to have those, so we'll just ignore them). Also here, just like the export variant, the caller is responsible for setting up libarchive.
2016-02-19 00:49:30 +03:00
endif
tests: Unify some tmpdir code, add ability for C to use libtest.sh I want to be able to easily test the C API on actual data in an OSTree repo. The shell `libtest.sh` has code to generate it. Bridge the two worlds by introducing a little `libostreetest` library which has a C API which spawns a shell that runs things in `libtest.sh`. Yes, this is about as beautiful as it sounds, which is to say, it's not. But it works! Note while we were here, I realized we were actually now creating *two* tmpdirs per test in `make check` because the tap driver was already doing that. Unify it so we know the C code can rely on it.
2016-03-02 18:05:08 +03:00
common_tests_cflags = $(ostree_bin_shared_cflags) $(OT_INTERNAL_GIO_UNIX_CFLAGS) -I$(srcdir)/libglnx
common_tests_ldadd = $(ostree_bin_shared_ldadd) $(OT_INTERNAL_GIO_UNIX_LIBS)
noinst_LTLIBRARIES += libostreetest.la
lib/repo-finder: Add mount based OstreeRepoFinder implementation This is a basic implementation of OstreeRepoFinder which resolves ref names to remote URIs by looking for them on any currently mounted removable storage volumes. The idea is to support OS and app updates via USB stick. Unit tests are included. This bumps libostree’s maximum GLib dependency from 2.44 to 2.50 for g_drive_is_removable(). If GLib 2.50 is not available, the call which needs it will be omitted and the OstreeRepoFinderMount implementation will scan all volumes (not just removable ones); this is a performance hit, but not a functionality hit. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #924 Approved by: cgwalters
2017-04-19 02:07:51 +03:00
libostreetest_la_SOURCES = tests/libostreetest.c tests/test-mock-gio.c tests/test-mock-gio.h
tests: Unify some tmpdir code, add ability for C to use libtest.sh I want to be able to easily test the C API on actual data in an OSTree repo. The shell `libtest.sh` has code to generate it. Bridge the two worlds by introducing a little `libostreetest` library which has a C API which spawns a shell that runs things in `libtest.sh`. Yes, this is about as beautiful as it sounds, which is to say, it's not. But it works! Note while we were here, I realized we were actually now creating *two* tmpdirs per test in `make check` because the tap driver was already doing that. Unify it so we know the C code can rely on it.
2016-03-02 18:05:08 +03:00
libostreetest_la_CFLAGS = $(common_tests_cflags) -I $(srcdir)/tests
libostreetest_la_LIBADD = $(common_tests_ldadd)
TESTS_CFLAGS = $(common_tests_cflags)
TESTS_LDADD = $(common_tests_ldadd) libostreetest.la
tests: Move test-varint and test-rollsum under "make check" "make check" tests are always enabled and they do not require to be installed. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-02-02 14:56:40 +03:00
tests: rename test-rollsum to test-rollsum-cli Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-08-14 09:43:44 +03:00
tests_test_rollsum_cli_SOURCES = src/libostree/ostree-rollsum.c tests/test-rollsum-cli.c
tests_test_rollsum_cli_CFLAGS = $(TESTS_CFLAGS) $(OT_DEP_ZLIB_CFLAGS)
oxidation: Add implementation of bupsplit in Rust This is an initial drop of "oxidation", or adding implementation of components in Rust. The bupsplit code is a good target - no dependencies, just computation. Translation into Rust had a few twists - - The C code relies a lot on overflowing unsigned ints, and also on the C promotion rules for e.g. `uint8_t -> int32_t` - There were some odd loops that I introduced bugs in while translating...in particular, the function always returns `len`, but I mistakenly translated to `len+1`, resulting in an OOB read on the C side, which was hard to debug. On the plus side, an off-by-one array indexing in the Rust code paniced nicely. In practice, we'll need a lot more build infrastructure to make this work, such as using `cargo vendor` when producing build artifacts for example. Also, Cargo is yet another thing we need to cache. Where do we go with this? Well, I think we should merge this, it's not a lot of code. We can just have it be an alternative CI target. Should we do a lot more right now? Probably not immediately, but I find the medium/long term prospects pretty exciting! Closes: #656 Approved by: jlebon
2017-01-25 05:43:53 +03:00
tests_test_rollsum_cli_LDADD = $(bupsplitpath) $(TESTS_LDADD) $(OT_DEP_ZLIB_LIBS)
tests: Move test-varint and test-rollsum under "make check" "make check" tests are always enabled and they do not require to be installed. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-02-02 14:56:40 +03:00
tests: Add tests for rollsum
2015-08-25 16:27:56 +03:00
tests_test_rollsum_SOURCES = src/libostree/ostree-rollsum.c tests/test-rollsum.c
tests_test_rollsum_CFLAGS = $(TESTS_CFLAGS) $(OT_DEP_ZLIB_CFLAGS)
oxidation: Add implementation of bupsplit in Rust This is an initial drop of "oxidation", or adding implementation of components in Rust. The bupsplit code is a good target - no dependencies, just computation. Translation into Rust had a few twists - - The C code relies a lot on overflowing unsigned ints, and also on the C promotion rules for e.g. `uint8_t -> int32_t` - There were some odd loops that I introduced bugs in while translating...in particular, the function always returns `len`, but I mistakenly translated to `len+1`, resulting in an OOB read on the C side, which was hard to debug. On the plus side, an off-by-one array indexing in the Rust code paniced nicely. In practice, we'll need a lot more build infrastructure to make this work, such as using `cargo vendor` when producing build artifacts for example. Also, Cargo is yet another thing we need to cache. Where do we go with this? Well, I think we should merge this, it's not a lot of code. We can just have it be an alternative CI target. Should we do a lot more right now? Probably not immediately, but I find the medium/long term prospects pretty exciting! Closes: #656 Approved by: jlebon
2017-01-25 05:43:53 +03:00
tests_test_rollsum_LDADD = $(bupsplitpath) $(TESTS_LDADD) $(OT_DEP_ZLIB_LIBS)
tests: Add tests for rollsum
2015-08-25 16:27:56 +03:00
lib/bloom: Add an internal bloom filter implementation This will be used in an upcoming commit. It adds a basic bloom filter implementation, using the SipHash family of hash functions. The implementation (including its parameter choices and hash functions) will become a protocol detail in future, so must not be changed so that its output is bitwise incompatible between OSTree versions. Unit tests are included. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #924 Approved by: cgwalters
2017-04-19 02:11:28 +03:00
tests_test_bloom_SOURCES = src/libostree/ostree-bloom.c tests/test-bloom.c
tests_test_bloom_CFLAGS = $(TESTS_CFLAGS)
tests_test_bloom_LDADD = $(TESTS_LDADD)
tests: Add test for including ostree.h Closes: #1615 Approved by: jlebon
2018-06-07 00:34:01 +03:00
tests_test_include_ostree_h_SOURCES = tests/test-include-ostree-h.c
# Don't use TESTS_CFLAGS so we test if the public header can be included by external programs
tests_test_include_ostree_h_CFLAGS = $(AM_CFLAGS) $(OT_INTERNAL_GIO_UNIX_CFLAGS) -I$(srcdir)/src/libostree -I$(builddir)/src/libostree
# Don't define OSTREE_COMPILATION so that we're compiling as if it's an external program
tests_test_include_ostree_h_CPPFLAGS = $(AM_CPPFLAGS) -UOSTREE_COMPILATION
tests_test_include_ostree_h_LDADD = $(TESTS_LDADD)
lib/repo-finder: Add Avahi based OstreeRepoFinder implementation This is a more complex implementation of OstreeRepoFinder which resolves ref names to remote URIs by looking for refs advertised by peers on the local network using DNS-SD records and mDNS (Avahi). The idea is to allow OS and app updates to be propagated over local networks, without the internet. It requires an OSTree server and code to generate the DNS-SD adverts in order to be fully functional — support for this will be added separately. Unit tests are included. Includes fixes by Krzesimir Nowak <krzesimir@kinvolk.io>. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #924 Approved by: cgwalters
2017-04-19 02:13:28 +03:00
if USE_AVAHI
tests_test_repo_finder_avahi_SOURCES = src/libostree/ostree-repo-finder-avahi-parser.c tests/test-repo-finder-avahi.c
tests_test_repo_finder_avahi_CFLAGS = $(TESTS_CFLAGS)
tests_test_repo_finder_avahi_LDADD = $(TESTS_LDADD)
endif
lib/kargs: Make API public and upstream new rpm-ostree APIs This change makes public the current kargs API in src/libostree/ostree-kernel-args.c and adds documentations. Upstreams the new kargs API from rpm-ostree/src/libpriv/rpmostree-kargs-process.c Merges libostree_kernel_args_la_SOURCES to libostree_1_la_SOURCES in Makefile-libostree.am Upstreams tests/check/test-kargs.c from rpm-ostree. Closes: #1833 Closes: #1869 Approved by: jlebon
2019-05-28 21:02:54 +03:00
tests_test_kargs_SOURCES = src/libostree/ostree-kernel-args.c tests/test-kargs.c
tests_test_kargs_CFLAGS = $(TESTS_CFLAGS)
tests_test_kargs_LDADD = $(TESTS_LDADD)
lib/repo-finder: Add config-file based OstreeRepoFinder implementation This is a basic implementation of OstreeRepoFinder which resolves ref names to remote URIs by looking their collection IDs up in the local configuration of remotes who have their collection-id key set. Unit tests are included. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #924 Approved by: cgwalters
2017-04-19 02:05:06 +03:00
tests_test_repo_finder_config_SOURCES = tests/test-repo-finder-config.c
tests_test_repo_finder_config_CFLAGS = $(TESTS_CFLAGS)
tests_test_repo_finder_config_LDADD = $(TESTS_LDADD)
lib/repo-finder: Add mount based OstreeRepoFinder implementation This is a basic implementation of OstreeRepoFinder which resolves ref names to remote URIs by looking for them on any currently mounted removable storage volumes. The idea is to support OS and app updates via USB stick. Unit tests are included. This bumps libostree’s maximum GLib dependency from 2.44 to 2.50 for g_drive_is_removable(). If GLib 2.50 is not available, the call which needs it will be omitted and the OstreeRepoFinderMount implementation will scan all volumes (not just removable ones); this is a performance hit, but not a functionality hit. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #924 Approved by: cgwalters
2017-04-19 02:07:51 +03:00
tests_test_repo_finder_mount_SOURCES = tests/test-repo-finder-mount.c
tests_test_repo_finder_mount_CFLAGS = $(TESTS_CFLAGS)
tests_test_repo_finder_mount_LDADD = $(TESTS_LDADD)
tests: add tests for mutable tree. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-04 16:14:18 +03:00
tests_test_mutable_tree_CFLAGS = $(TESTS_CFLAGS)
tests_test_mutable_tree_LDADD = $(TESTS_LDADD)
tests: Unify some tmpdir code, add ability for C to use libtest.sh I want to be able to easily test the C API on actual data in an OSTree repo. The shell `libtest.sh` has code to generate it. Bridge the two worlds by introducing a little `libostreetest` library which has a C API which spawns a shell that runs things in `libtest.sh`. Yes, this is about as beautiful as it sounds, which is to say, it's not. But it works! Note while we were here, I realized we were actually now creating *two* tmpdirs per test in `make check` because the tap driver was already doing that. Unify it so we know the C code can rely on it.
2016-03-02 18:05:08 +03:00
tests_test_basic_c_CFLAGS = $(TESTS_CFLAGS)
tests_test_basic_c_LDADD = $(TESTS_LDADD)
lib: Add ostree_sysroot_load_if_changed() API This will allow daemons like rpm-ostree to detect if there are any new deployments efficiently, in combination with using inotify. If there are any changes, rpm-ostree wants publish them on DBus. While we're here, add some changes to start doing unit C testing of the sysroot API.
2016-03-03 21:49:54 +03:00
tests_test_sysroot_c_CFLAGS = $(TESTS_CFLAGS)
tests_test_sysroot_c_LDADD = $(TESTS_LDADD)
tests/test-pull-c: New test that runs through the pull API via C We have had in the past issues with running `ostree_repo_pull()` multiple times in the same process, embarassingly enough. Nothing in the current test suite covers this, so let's start. Closes: #322 Approved by: jlebon
2016-06-06 21:49:11 +03:00
tests_test_pull_c_CFLAGS = $(TESTS_CFLAGS)
tests_test_pull_c_LDADD = $(TESTS_LDADD)
lib/repo: Add ostree_repo_hash() and tests Add a hash function for OstreeRepo instances, which relies on the repo being open, and hence being able to hash the device and inode of its root directory. Add unit tests for this and ostree_repo_equal(). Signed-off-by: Philip Withnall <withnall@endlessm.com> https://github.com/ostreedev/ostree/issues/1191 Closes: #1205 Approved by: cgwalters
2017-09-21 22:22:09 +03:00
tests_test_repo_CFLAGS = $(TESTS_CFLAGS)
tests_test_repo_LDADD = $(TESTS_LDADD)
tests: Remove some duplications from Makefile-tests.am Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-03 16:21:40 +03:00
tests_test_ot_unix_utils_CFLAGS = $(TESTS_CFLAGS)
tests_test_ot_unix_utils_LDADD = $(TESTS_LDADD)
tests: Move test-varint and test-rollsum under "make check" "make check" tests are always enabled and they do not require to be installed. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-02-02 14:56:40 +03:00
tests: Remove some duplications from Makefile-tests.am Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-03 16:21:40 +03:00
tests_test_varint_SOURCES = src/libostree/ostree-varint.c tests/test-varint.c
tests_test_varint_CFLAGS = $(TESTS_CFLAGS)
tests_test_varint_LDADD = $(TESTS_LDADD)
tests: add test for bsdiff Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-02-23 12:05:19 +03:00
tests: Remove some duplications from Makefile-tests.am Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-03 16:21:40 +03:00
tests_test_bsdiff_CFLAGS = $(TESTS_CFLAGS)
tests_test_bsdiff_LDADD = libbsdiff.la $(TESTS_LDADD)
keyfile-utils: add tests Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-05 17:40:52 +03:00
core: new function _ostree_parse_delta_name Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-04-28 18:45:37 +03:00
tests_test_checksum_SOURCES = src/libostree/ostree-core.c tests/test-checksum.c
tests_test_checksum_CFLAGS = $(TESTS_CFLAGS) $(libglnx_cflags)
tests_test_checksum_LDADD = $(TESTS_LDADD)
repo: Add ostree_repo_import_archive_to_mtree This is a more flexible version of the previous ostree_repo_write_archive_to_mtree() which took a file reference. This has an extensible options structure, and in particular now supports `ignore_unsupported_content`. I plan to use this for importing Docker images which contain device nodes. (There's no reason for container images to have those, so we'll just ignore them). Also here, just like the export variant, the caller is responsible for setting up libarchive.
2016-02-19 00:49:30 +03:00
tests_test_libarchive_import_SOURCES = tests/test-libarchive-import.c
test-libarchive: fix underlinking Signed-off-by: Simon McVittie <smcv@debian.org>
2016-03-11 11:46:27 +03:00
tests_test_libarchive_import_CFLAGS = $(TESTS_CFLAGS) $(libglnx_cflags) $(OT_DEP_LIBARCHIVE_CFLAGS)
tests_test_libarchive_import_LDADD = $(TESTS_LDADD) $(OT_DEP_LIBARCHIVE_LIBS)
repo: Add ostree_repo_import_archive_to_mtree This is a more flexible version of the previous ostree_repo_write_archive_to_mtree() which took a file reference. This has an extensible options structure, and in particular now supports `ignore_unsupported_content`. I plan to use this for importing Docker images which contain device nodes. (There's no reason for container images to have those, so we'll just ignore them). Also here, just like the export variant, the caller is responsible for setting up libarchive.
2016-02-19 00:49:30 +03:00
keyfile-utils: add tests Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-05 17:40:52 +03:00
tests_test_keyfile_utils_CFLAGS = $(TESTS_CFLAGS)
tests_test_keyfile_utils_LDADD = $(TESTS_LDADD)
tests: add test for test-ot-opt-utils. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-06 13:38:13 +03:00
tests_test_ot_opt_utils_CFLAGS = $(TESTS_CFLAGS)
tests_test_ot_opt_utils_LDADD = $(TESTS_LDADD)
tests: Add tests for test-ot-tool-util Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-06 14:54:53 +03:00
tests_test_ot_tool_util_CFLAGS = $(TESTS_CFLAGS)
tests_test_ot_tool_util_LDADD = $(TESTS_LDADD)
gpg: Add OstreeGpgVerifyResult Wrappers a referenced gpgme_verify_result_t so detailed verify results can be examined independently of executing a verify operation. _ostree_gpg_verifier_check_signature() now returns this object instead of a single valid/invalid boolean, but the idea is for OstreeRepo to also return this object for commit signature verification so it can be utilized at the CLI layer (and possibly by other programs).
2015-03-04 20:44:47 +03:00
tests: add tests for LZMA compressor and decompressor Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-08-11 12:26:14 +03:00
tests_test_lzma_SOURCES = src/libostree/ostree-lzma-common.c src/libostree/ostree-lzma-compressor.c \
src/libostree/ostree-lzma-decompressor.c tests/test-lzma.c
tests: Build test-lzma with LZMA flags test-lzma builds a copy of the compressor and decompressor directly, so the compiler needs access to the LZMA headers and the linker needs to link the program with liblzma.
2015-08-26 19:54:31 +03:00
tests_test_lzma_CFLAGS = $(TESTS_CFLAGS) $(OT_DEP_LZMA_CFLAGS)
tests_test_lzma_LDADD = $(TESTS_LDADD) $(OT_DEP_LZMA_LIBS)
tests: add tests for LZMA compressor and decompressor Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-08-11 12:26:14 +03:00
build: Conditionally build the GPG-related tests Do not build GPG signing/verification tests if `--without-gpgme` option is used during configuration. Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com> Closes: #1889 Approved by: cgwalters
2019-05-21 01:23:14 +03:00
if USE_GPGME
gpg: Add OstreeGpgVerifyResult Wrappers a referenced gpgme_verify_result_t so detailed verify results can be examined independently of executing a verify operation. _ostree_gpg_verifier_check_signature() now returns this object instead of a single valid/invalid boolean, but the idea is for OstreeRepo to also return this object for commit signature verification so it can be utilized at the CLI layer (and possibly by other programs).
2015-03-04 20:44:47 +03:00
tests_test_gpg_verify_result_SOURCES = \
src/libostree/ostree-gpg-verify-result-private.h \
tests/test-gpg-verify-result.c
tests: Link test-gpg-verify-result with gpgme This test uses gpgme directly to verify the signatures, so it needs to find the gpgme headers and link with gpgme to ensure the linker can resolve the symbols.
2015-05-13 01:48:22 +03:00
tests_test_gpg_verify_result_CFLAGS = $(TESTS_CFLAGS) $(OT_INTERNAL_GPGME_CFLAGS)
tests_test_gpg_verify_result_LDADD = $(TESTS_LDADD) $(OT_INTERNAL_GPGME_LIBS)
gpg: Add OstreeGpgVerifyResult Wrappers a referenced gpgme_verify_result_t so detailed verify results can be examined independently of executing a verify operation. _ostree_gpg_verifier_check_signature() now returns this object instead of a single valid/invalid boolean, but the idea is for OstreeRepo to also return this object for commit signature verification so it can be utilized at the CLI layer (and possibly by other programs).
2015-03-04 20:44:47 +03:00
build: Conditionally build the GPG-related tests Do not build GPG signing/verification tests if `--without-gpgme` option is used during configuration. Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com> Closes: #1889 Approved by: cgwalters
2019-05-21 01:23:14 +03:00
EXTRA_DIST += \
tests/gpg-verify-data/README.md \
$(NULL)
endif
gpg: Add OstreeGpgVerifyResult Wrappers a referenced gpgme_verify_result_t so detailed verify results can be examined independently of executing a verify operation. _ostree_gpg_verifier_check_signature() now returns this object instead of a single valid/invalid boolean, but the idea is for OstreeRepo to also return this object for commit signature verification so it can be utilized at the CLI layer (and possibly by other programs).
2015-03-04 20:44:47 +03:00
EXTRA_DIST += \
tests: add libostreetest.h to EXTRA_DIST Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Closes: #242 Approved by: cgwalters
2016-04-07 10:53:54 +03:00
tests/libostreetest.h \
build: distribute more test files Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 12:45:48 +03:00
tests/libtest.sh \
tests: Remove gpg verification files from EXTRA_DIST Follow on from 70a11189. These files are already disted. Closes: #372 Approved by: cgwalters
2016-05-13 16:47:09 +03:00
$(NULL)
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
build: Make tests/libreaddir-rand.so rule use AM_V_GEN So non-verbose builds don't have a verbose rule smack in the middle. Closes: #241 Approved by: giuseppe
2016-04-07 04:26:38 +03:00
tests/libreaddir-rand.so: Makefile
Avoid race condition in case tests directory does not exist Make sure the tests directory exists before symlinking files into it. Closes: #1703 Closes: #1704 Approved by: cgwalters
2018-08-14 13:38:15 +03:00
mkdir -p tests/
$(AM_V_GEN) ln -fns ../.libs/libreaddir-rand.so tests/
build: Make tests/libreaddir-rand.so rule use AM_V_GEN So non-verbose builds don't have a verbose rule smack in the middle. Closes: #241 Approved by: giuseppe
2016-04-07 04:26:38 +03:00
ALL_LOCAL_RULES += tests/libreaddir-rand.so
Makefile-tests.am: make check uses the built binaries The tests suite was failing locally as it was using the installed version of rofiles-fuse, instead of the built one. Create the needed symlinks in tests/ as we are already doing for the "ostree" binary. ostree-prepare-root and ostree-remount added for completeness. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Closes: #395 Approved by: cgwalters
2016-07-14 14:42:32 +03:00
CLEANFILES += tests/libreaddir-rand.so tests/ostree-symlink-stamp \
tests/ostree-prepare-root-symlink-stamp tests/ostree-remount-symlink-stamp \
tests/rofiles-fuse-symlink-stamp tests/ostree
build: Update .gitignore The patch to add more symlink bits also needed CLEANFILES updates. Closes: #446 Approved by: jlebon
2016-08-09 03:19:54 +03:00
CLEANFILES += tests/ostree-prepare-root tests/ostree-remount tests/rofiles-fuse
tests: Modernize valgrind infrastructure The recent memleak fixes motivated me to look at the bitrotted code to run invocations of `ostree` in the test suite underneath valgrind. There are a few things here. First, update suppressions file from libhif, since I recently worked on it. When running *uninstalled* as we now support, we need `libtool --mode=execute` in the mix so it expands out to the uninstalled binary and we don't valgrind the intermediate shell. However, it's harder than that because we chdir into a tmpdir, which defeats the libtool logic. AFAICS, the only fix for this is to determine the realbin path before we chdir, and then unfortunately we need to change every use of `ostree` to `${OSTREE}` =( Then this immediately breaks for me on RHEL7 because my ancient copy of `valgrind-3.10.0-16.el7.x86_64` is unaware of syscall 306, i.e. `syncfs`. But let's do this first before I dive into that. Closes: #292 Approved by: krnowak
2016-05-11 22:54:48 +03:00
build: Make symlink depend on source Closes: https://github.com/ostreedev/ostree/issues/389 Closes: #400 Approved by: smcv
2016-07-15 18:17:43 +03:00
tests/%-symlink-stamp: % Makefile
$(AM_V_GEN) set -e; \
Makefile-tests.am: make check uses the built binaries The tests suite was failing locally as it was using the installed version of rofiles-fuse, instead of the built one. Create the needed symlinks in tests/ as we are already doing for the "ostree" binary. ostree-prepare-root and ostree-remount added for completeness. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Closes: #395 Approved by: cgwalters
2016-07-14 14:42:32 +03:00
lt_bin=`cd $(top_builddir) && ./libtool --mode=execute echo $*`; \
if test "$${lt_bin}" = "$*"; then \
real_bin=$(abs_top_builddir)/$*; \
else \
real_bin="$${lt_bin}"; \
fi; \
ln -sf "$${real_bin}" tests/$*; \
tests: Modernize valgrind infrastructure The recent memleak fixes motivated me to look at the bitrotted code to run invocations of `ostree` in the test suite underneath valgrind. There are a few things here. First, update suppressions file from libhif, since I recently worked on it. When running *uninstalled* as we now support, we need `libtool --mode=execute` in the mix so it expands out to the uninstalled binary and we don't valgrind the intermediate shell. However, it's harder than that because we chdir into a tmpdir, which defeats the libtool logic. AFAICS, the only fix for this is to determine the realbin path before we chdir, and then unfortunately we need to change every use of `ostree` to `${OSTREE}` =( Then this immediately breaks for me on RHEL7 because my ancient copy of `valgrind-3.10.0-16.el7.x86_64` is unaware of syscall 306, i.e. `syncfs`. But let's do this first before I dive into that. Closes: #292 Approved by: krnowak
2016-05-11 22:54:48 +03:00
touch $@
Symlink libreaddir-rand.so into tests directory This means it can be LD_PRELOADed during build-time testing. Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #232 Approved by: cgwalters
2016-03-28 15:46:23 +03:00
Add --enable-installed-tests=exclusive, fix installed case The major reason to do this is that running tests *both* installed and uninstalled in our CI is a mostly pointless waste of time. Particularly given we have a few expensive tests. We *do* have tests that only run uninstalled (since they require the source code) like `test-symbols.sh`. Hence, add `--enable-installed-tests=exclusive` to mean *only* do installed for most tests. We'll still have uninstalled coverage via the Travis/Debian configs, and we could perhaps do another build with a subset of uninstalled tests, but I'm not really concerned about it. I'd like to do a renewed push for the InstalledTests model since I feel it's just fundamentally better. (`g-d-t-r` kind of sucks, but then so does the automake runner). Also while we're here - fix the CI to use the correct context, which started this mess. Closes: #837 Approved by: dbnicholson
2017-05-08 17:44:43 +03:00
# See above comment on binding the tests to be either installed or not.
if ENABLE_INSTALLED_TESTS_EXCLUSIVE
dist_installed_test_scripts = $(_installed_or_uninstalled_test_scripts)
installed_test_programs = $(_installed_or_uninstalled_test_programs)
check-local:
echo "NOTE: Exclusive installed tests are enabled; to run them, make install, then: gnome-desktop-testing-runner -p 0 libostree/"
else
dist_test_scripts += $(_installed_or_uninstalled_test_scripts)
test_programs += $(_installed_or_uninstalled_test_programs)
endif
build-sys: Allow building with curl, but without libsoup Some people (particularly embedded) may find it simpler to drop libsoup from the build dependency side, but still use libcurl. Note though this currently neuters almost all of the tests. Signed-off-by: Anton Gerasimov <anton.gerasimov@openmailbox.org> Closes: #1397 Approved by: cgwalters
2018-01-08 16:53:46 +03:00
if !USE_LIBSOUP
no-soup-for-you-warning:
@echo "WARNING: $(PACKAGE) was built without libsoup, which is currently" 1>&2
@echo "WARNING: required for many unit tests." 1>&2
sleep 10
check: no-soup-for-you-warning
endif
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
# Unfortunately the glib test data APIs don't actually handle
# non-recursive Automake, so we change our code to canonically look
# for tests/ which is just a symlink when installed.
build: Don't install test data without --enable-installed-tests Otherwise $(installed_testdir) is empty so we try to put content in `/`, which I noticed when trying to build an RPM (it works works fine `sudo make install`).
2016-03-08 21:12:00 +03:00
if ENABLE_INSTALLED_TESTS
ci: Combine UBSAN and ASAN by default I only recently realized this was possible. While we're still seeing leaks in the CI environment for some reason, adding ASAN gives us use-after-free detection etc., which is obviously still very useful even if we're not doing leak checking. Closes: #622 Approved by: jlebon
2016-12-08 05:26:43 +03:00
install-installed-tests-extra:
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 18:28:04 +03:00
if test -L $(DESTDIR)$(installed_testdir)/tests; then \
rm $(DESTDIR)$(installed_testdir)/tests; \
fi
ln -s . $(DESTDIR)$(installed_testdir)/tests
tests: Tweak installed tests to deal with ASAN We need to disable readdir-rand there too. Closes: #622 Approved by: jlebon
2016-12-08 20:50:20 +03:00
if BUILDOPT_ASAN
sed -e 's,^BUILT_WITH_ASAN=.*,BUILT_WITH_ASAN=1,' < $(srcdir)/tests/libtest.sh > $(DESTDIR)$(installed_testdir)/tests/libtest.sh
else
install -m 0644 $(srcdir)/tests/libtest.sh $(DESTDIR)$(installed_testdir)/tests/libtest.sh
endif
ci: Combine UBSAN and ASAN by default I only recently realized this was possible. While we're still seeing leaks in the CI environment for some reason, adding ASAN gives us use-after-free detection etc., which is obviously still very useful even if we're not doing leak checking. Closes: #622 Approved by: jlebon
2016-12-08 05:26:43 +03:00
INSTALL_DATA_HOOKS += install-installed-tests-extra
build: Don't install test data without --enable-installed-tests Otherwise $(installed_testdir) is empty so we try to put content in `/`, which I noticed when trying to build an RPM (it works works fine `sudo make install`).
2016-03-08 21:12:00 +03:00
endif
Reference in New Issue Copy Permalink