shaba/ostree
1
0
Fork 0
mirror of https://github.com/ostreedev/ostree.git synced 2025-02-27 01:57:49 +03:00
Code Issues Projects Releases Wiki Activity
ostree/Makefile-tests.am

268 lines
9.3 KiB
Plaintext
Raw Normal View History

Install tests Matching https://live.gnome.org/GnomeGoals/InstalledTests
2013-05-01 15:26:21 -04:00
# Makefile for tests code
#
# Copyright (C) 2013 Colin Walters <walters@verbum.org>
#
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
# License as published by the Free Software Foundation; either
# version 2 of the License, or (at your option) any later version.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with this library; if not, write to the
# Free Software Foundation, Inc., 59 Temple Place - Suite 330,
# Boston, MA 02111-1307, USA.
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
include $(top_srcdir)/buildutil/glib-tap.mk
build: distribute TAP helper scripts in tarballs Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 10:43:34 +01:00
EXTRA_DIST += \
buildutil/tap-driver.sh \
buildutil/tap-test \
$(NULL)
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
# We should probably consider flipping the default for DEBUG. Also,
# include the builddir in $PATH so we find our just-built ostree
# binary.
TESTS_ENVIRONMENT += OT_TESTS_DEBUG=1 \
Load g-i bindings from builddir during build-time testing Previously, the build-time tests would only pass if the g-i bindings to OSTree were already installed, with a reasonably similar version. Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #232 Approved by: cgwalters
2016-03-31 09:02:23 +01:00
GI_TYPELIB_PATH=$$(cd $(top_builddir) && pwd) \
LD_LIBRARY_PATH=$$(cd $(top_builddir)/.libs && pwd) \
tests: Modernize valgrind infrastructure The recent memleak fixes motivated me to look at the bitrotted code to run invocations of `ostree` in the test suite underneath valgrind. There are a few things here. First, update suppressions file from libhif, since I recently worked on it. When running *uninstalled* as we now support, we need `libtool --mode=execute` in the mix so it expands out to the uninstalled binary and we don't valgrind the intermediate shell. However, it's harder than that because we chdir into a tmpdir, which defeats the libtool logic. AFAICS, the only fix for this is to determine the realbin path before we chdir, and then unfortunately we need to change every use of `ostree` to `${OSTREE}` =( Then this immediately breaks for me on RHEL7 because my ancient copy of `valgrind-3.10.0-16.el7.x86_64` is unaware of syscall 306, i.e. `syncfs`. But let's do this first before I dive into that. Closes: #292 Approved by: krnowak
2016-05-11 15:54:48 -04:00
PATH=$$(cd $(top_builddir)/tests && pwd):$${PATH} \
Load g-i bindings from builddir during build-time testing Previously, the build-time tests would only pass if the g-i bindings to OSTree were already installed, with a reasonably similar version. Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #232 Approved by: cgwalters
2016-03-31 09:02:23 +01:00
$(NULL)
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
Makefile-tests.am: make check uses the built binaries The tests suite was failing locally as it was using the installed version of rofiles-fuse, instead of the built one. Create the needed symlinks in tests/ as we are already doing for the "ostree" binary. ostree-prepare-root and ostree-remount added for completeness. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Closes: #395 Approved by: cgwalters
2016-07-14 13:42:32 +02:00
uninstalled_test_data = tests/ostree-symlink-stamp tests/ostree-prepare-root-symlink-stamp \
tests/ostree-remount-symlink-stamp tests/rofiles-fuse-symlink-stamp
tests: Modernize valgrind infrastructure The recent memleak fixes motivated me to look at the bitrotted code to run invocations of `ostree` in the test suite underneath valgrind. There are a few things here. First, update suppressions file from libhif, since I recently worked on it. When running *uninstalled* as we now support, we need `libtool --mode=execute` in the mix so it expands out to the uninstalled binary and we don't valgrind the intermediate shell. However, it's harder than that because we chdir into a tmpdir, which defeats the libtool logic. AFAICS, the only fix for this is to determine the realbin path before we chdir, and then unfortunately we need to change every use of `ostree` to `${OSTREE}` =( Then this immediately breaks for me on RHEL7 because my ancient copy of `valgrind-3.10.0-16.el7.x86_64` is unaware of syscall 306, i.e. `syncfs`. But let's do this first before I dive into that. Closes: #292 Approved by: krnowak
2016-05-11 15:54:48 -04:00
build: distribute test scripts in tarballs Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 10:39:46 +01:00
dist_uninstalled_test_scripts = tests/test-symbols.sh
tests: Add a test-abi This would have caught a potential ABI regression in https://bugzilla.gnome.org/show_bug.cgi?id=764056 (If we ran this test while building `--without-libarchive`) Pull request: #218 Approved by: jlebon
2016-03-23 15:18:27 -04:00
build: distribute test scripts in tarballs Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 10:39:46 +01:00
dist_test_scripts = \
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
tests/test-basic.sh \
tests/test-pull-subpath.sh \
tests/test-archivez.sh \
tests/test-remote-add.sh \
tests/test-remote-gpg-import.sh \
tests/test-commit-sign.sh \
tests/test-export.sh \
tests/test-help.sh \
tests/test-libarchive.sh \
Add test case for inheriting remote options Closes: #236 Approved by: cgwalters
2016-04-01 10:20:34 +02:00
tests/test-parent.sh \
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
tests/test-pull-archive-z.sh \
tests/test-pull-commit-only.sh \
tests/test-pull-corruption.sh \
tests/test-pull-depth.sh \
tests/test-pull-mirror-summary.sh \
tests/test-pull-large-metadata.sh \
tests/test-pull-metalink.sh \
tests/test-pull-summary-sigs.sh \
tests/test-pull-resume.sh \
tests: Add some test coverage of repeated pulls w/HTTP 500s Systems like pulp may want to keep retrying in a loop if the server throws a (hopefully transient) 500, and we need test coverage of handling these errors versus our existing 404 and 206 coverage. Closes: #383 Approved by: mbarnes
2016-07-07 17:39:07 -04:00
tests/test-pull-repeated.sh \
Add --untrusted option to pull and pull-local https://bugzilla.gnome.org/show_bug.cgi?id=764125 Closes: #221 Approved by: cgwalters
2016-03-23 12:32:03 +01:00
tests/test-pull-untrusted.sh \
tests: Add a test for ostree pull --url Closes: #271 Approved by: cgwalters
2016-04-22 14:41:04 +02:00
tests/test-pull-override-url.sh \
Fix local-pull test This was not being run for whatever reason. Also, the test count was wrong. Closes: #237 Approved by: cgwalters
2016-04-04 14:43:33 +02:00
tests/test-local-pull.sh \
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
tests/test-local-pull-depth.sh \
tests/test-gpg-signed-commit.sh \
tests/test-admin-upgrade-unconfigured.sh \
tests/test-admin-deploy-syslinux.sh \
tests/test-admin-deploy-2.sh \
tests/test-admin-deploy-karg.sh \
tests/test-admin-deploy-switch.sh \
tests/test-admin-deploy-etcmerge-cornercases.sh \
tests/test-admin-deploy-uboot.sh \
Introducing ostree-grub-generator ostree-grub-generator can be used to customize the generated grub.cfg file. Compile time decision ostree-grub-generator vs grub2-mkconfig can be overwritten with the OSTREE_GRUB2_EXEC envvar - useful for auto tests and OS installers. Why this alternative approach: 1) The current approach is less flexible than using a custom 'ostree-grub-generator' script. Each system can adjust this script for its needs, instead of using the hardcoded values from ostree-bootloader-grub2.c. 2) Too much overhead on embedded to generate grub.cfg via /etc/grub.d/ configuration files. It is still possible to do so, even with this patch applied. No need to install grub2 package on a target device. 3) The grub2-mkconfig code path has other issues: https://bugzilla.gnome.org/show_bug.cgi?id=761180 Task: https://bugzilla.gnome.org/show_bug.cgi?id=762220 Closes: #228 Approved by: cgwalters
2016-04-01 13:51:18 +02:00
tests/test-admin-deploy-grub2.sh \
repo: Clean up staging directory for previous boot IDs We had a policy of cleaning up all files in `$repo/tmp` older than one day, but we should really clean up previous bootid staging directories too, as they can potentially take up a lot of disk space. https://bugzilla.gnome.org/show_bug.cgi?id=760531 Closes: #170 Approved by: jlebon
2016-01-13 11:33:54 -05:00
tests/test-admin-deploy-bootid-gc.sh \
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
tests/test-admin-instutil-set-kargs.sh \
tests/test-admin-upgrade-not-backwards.sh \
tests/test-admin-pull-deploy-commit.sh \
tests/test-admin-locking.sh \
tests/test-admin-deploy-clean.sh \
tests/test-repo-checkout-subpath.sh \
tests/test-reset-nonlinear.sh \
tests/test-oldstyle-partial.sh \
tests/test-delta.sh \
tests/test-xattrs.sh \
tests/test-auto-summary.sh \
tests/test-prune.sh \
tests/test-refs.sh \
docs: Add a section on writing buildsystems And add a test that is a demo buildsystem.
2016-03-03 21:17:53 -05:00
tests/test-demo-buildsystem.sh \
Install tests Matching https://live.gnome.org/GnomeGoals/InstalledTests
2013-05-01 15:26:21 -04:00
$(NULL)
Import rofiles-fuse While it's not strictly tied to OSTree, let's move https://github.com/cgwalters/rofiles-fuse in here because: - It's *very* useful in concert with OSTree - It's tiny - We can reuse OSTree's test, documentation, etc. infrastructure One thing to consider also is that at some point we could experiment with writing a FUSE filesystem for OSTree. This could internalize a better equivalent of `--link-checkout-speedup`, but on the other hand, the cost of walking filesystem trees for these types of operations is really quite small. But if we did decide to do more FUSE things in OSTree, this is a step towards that too.
2016-02-10 12:42:54 +01:00
if BUILDOPT_FUSE
build: distribute test scripts in tarballs Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 10:39:46 +01:00
dist_test_scripts += tests/test-rofiles-fuse.sh
Import rofiles-fuse While it's not strictly tied to OSTree, let's move https://github.com/cgwalters/rofiles-fuse in here because: - It's *very* useful in concert with OSTree - It's tiny - We can reuse OSTree's test, documentation, etc. infrastructure One thing to consider also is that at some point we could experiment with writing a FUSE filesystem for OSTree. This could internalize a better equivalent of `--link-checkout-speedup`, but on the other hand, the cost of walking filesystem trees for these types of operations is really quite small. But if we did decide to do more FUSE things in OSTree, this is a step towards that too.
2016-02-10 12:42:54 +01:00
endif
tests: Only install test-corruption if gjs is found It now uses a gjs-based helper.
2014-01-21 19:53:06 +00:00
# This one uses corrupt-repo-ref.js
if BUILDOPT_GJS
build: distribute test scripts in tarballs Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 10:39:46 +01:00
dist_test_scripts += tests/test-corruption.sh
tests: Only install test-corruption if gjs is found It now uses a gjs-based helper.
2014-01-21 19:53:06 +00:00
endif
build: distribute test scripts in tarballs Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 10:39:46 +01:00
dist_installed_test_data = tests/archive-test.sh \
Install tests Matching https://live.gnome.org/GnomeGoals/InstalledTests
2013-05-01 15:26:21 -04:00
tests/pull-test.sh \
tests/libtest.sh \
Unify uboot and syslinux test cases The test-admin-deploy-1 was copied into -uboot at some point. But really they should be testing exactly the same thing, except for the bootloader backend. Unify these tests by extracting a common test core.
2014-01-15 09:48:04 -05:00
tests/admin-test.sh \
Split out basic tests from test-basic.sh This will let us reuse them with other repo types https://bugzilla.gnome.org/show_bug.cgi?id=741125
2014-12-05 14:28:16 +01:00
tests/basic-test.sh \
Add test-basic-user.sh testing for bare-user repos This just does whatever test-basic.sh does, but on a bare-user repo. This works standalone, but unfortunately it breaks in gnome-desktop-testing-runner as /tmp doesn't support xattrs, so it is not installed atm. https://bugzilla.gnome.org/show_bug.cgi?id=741125
2014-12-05 14:40:15 +01:00
tests/test-basic-user.sh \
tests/pull-corruption: Ensure we corrupt an object to be pulled This test had some nondeterminism because we chose a random object to corrupt, but because there were multiple commits, it was possible that we chose an object that was not being pulled. Fix this by writing some custom GJS code to find an explicitly random object that exists in a given ref, an change a random byte offset. This adds a lot more randomness to the testing too.
2014-01-19 12:39:38 -05:00
tests/corrupt-repo-ref.js \
deltas: Heuristically detect endianness for older deltas If the average object size is greater than 4GiB, let's assume we're dealing with opposite endianness. I'm fairly confident no one is going to be shipping peta- or exa- byte size ostree deltas, period. Past the gigabyte scale you really want bittorrent or something.
2016-02-24 17:04:04 -05:00
tests/pre-endian-deltas-repo-big.tar.xz \
tests/pre-endian-deltas-repo-little.tar.xz \
Install tests Matching https://live.gnome.org/GnomeGoals/InstalledTests
2013-05-01 15:26:21 -04:00
$(NULL)
build: distribute test scripts in tarballs Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 10:39:46 +01:00
dist_test_extra_scripts = tests/bootloader-entries-crosscheck.py \
Introducing ostree-grub-generator ostree-grub-generator can be used to customize the generated grub.cfg file. Compile time decision ostree-grub-generator vs grub2-mkconfig can be overwritten with the OSTREE_GRUB2_EXEC envvar - useful for auto tests and OS installers. Why this alternative approach: 1) The current approach is less flexible than using a custom 'ostree-grub-generator' script. Each system can adjust this script for its needs, instead of using the hardcoded values from ostree-bootloader-grub2.c. 2) Too much overhead on embedded to generate grub.cfg via /etc/grub.d/ configuration files. It is still possible to do so, even with this patch applied. No need to install grub2 package on a target device. 3) The grub2-mkconfig code path has other issues: https://bugzilla.gnome.org/show_bug.cgi?id=761180 Task: https://bugzilla.gnome.org/show_bug.cgi?id=762220 Closes: #228 Approved by: cgwalters
2016-04-01 13:51:18 +02:00
tests/ostree-grub-generator
tests: Add a crosscheck for syslinux bootloader config generation And actually wire this one up in admin-test.sh.
2015-05-27 20:08:44 -04:00
build: Don't install test data without --enable-installed-tests Otherwise $(installed_testdir) is empty so we try to put content in `/`, which I noticed when trying to build an RPM (it works works fine `sudo make install`).
2016-03-08 13:12:00 -05:00
# We can't use nobase_ as we need to strip off the tests/, can't
# use plain installed_ as we do need the gpghome/ prefix.
if ENABLE_INSTALLED_TESTS
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
gpginsttestdir = $(installed_testdir)/gpghome
build: distribute more test files Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 10:45:48 +01:00
dist_gpginsttest_DATA = tests/gpghome/secring.gpg \
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
tests/gpghome/pubring.gpg \
tests: Add test-remote-gpg-import.sh
2015-05-07 13:42:19 -04:00
tests/gpghome/trustdb.gpg \
tests/gpghome/key1.asc \
tests/gpghome/key2.asc \
tests/gpghome/key3.asc
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
gpginsttest_trusteddir = $(installed_testdir)/gpghome/trusted
build: distribute more test files Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 10:45:48 +01:00
dist_gpginsttest_trusted_DATA = tests/gpghome/trusted/pubring.gpg
tests: Fix up GPG tests for more strict EL7 GPG These GPG tests were failing for me on EL7 - it appears to be because we had only one directory for both private and public keys, and we were giving that to ostree for verification, which passed them onto gpgv. In EL7 beta at least, gpgv now barfs if it finds a private key where it is just expecting to find public keys. Fix this by splitting out the public trusted directory from the private key directory. Except now for signing, we still need the public key there, so symlink it. Whee!
2014-02-10 09:38:07 -05:00
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
gpgvinsttestdir = $(installed_testdir)/gpg-verify-data
build: distribute more test files Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 10:45:48 +01:00
dist_gpgvinsttest_DATA = $(addprefix tests/gpg-verify-data/, \
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
gpg.conf lgpl2 lgpl2.sig pubring.gpg secring.gpg trustdb.gpg)
build: Don't install test data without --enable-installed-tests Otherwise $(installed_testdir) is empty so we try to put content in `/`, which I noticed when trying to build an RPM (it works works fine `sudo make install`).
2016-03-08 13:12:00 -05:00
endif
tests: Restore accidentally deleted Makefile bit Not sure how this got deleted...
2015-02-16 10:29:14 -05:00
tests: Add a gjs-based test This covers introspection, and in general is a much better way to get API coverage tests.
2013-09-18 12:01:46 -04:00
if BUILDOPT_GJS
build: distribute test scripts in tarballs Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 10:39:46 +01:00
dist_installed_test_scripts = tests/test-core.js \
core: Add size information to commit metadata Add a --generate-sizes option to commit to add size information to the commit metadata. This will be used by higher level code which wants to determine the total size necessary for downloading.
2013-10-08 20:44:39 -06:00
tests/test-sizes.js \
Revert "Disable test-sysroot.test" This reverts commit 73868a96d14fa13e69d9df778d2363b89f41fef5.
2014-03-19 09:15:29 -04:00
tests/test-sysroot.js \
tests: Add a simple test-sysroot.js that covers OSTree.Sysroot This will be more interesting as a test case user of the API.
2013-10-02 19:47:38 -04:00
$(NULL)
tests: Add a gjs-based test This covers introspection, and in general is a much better way to get API coverage tests.
2013-09-18 12:01:46 -04:00
endif
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
test_ltlibraries = libreaddir-rand.la
tests: Run all tests through a randomized readdir() Having undefined (but in practice rarely changing) ordering for `readdir()` ended up screwing us over for bootloader config generation; see https://bugzilla.redhat.com/show_bug.cgi?id=1226520 Let's make things significantly more likely to fail more quickly in the future if similar bugs are introduced. We accomplish this by introducing a little `LD_PRELOAD` library that randomizes the results of `readdir()`.
2015-06-01 22:34:14 -04:00
libreaddir_rand_la_SOURCES = tests/readdir-rand.c
build: Fix libreaddir-rand to honor global CFLAGS It's unfortunate that in automake one has to explicitly include the globa `$(AM_CFLAGS)` if one sets `CFLAGS`, and similarly for other variables. I'm trying to use `-fsanitize=address`, and not including it was causing linker failures. We also weren't inheriting the global warnings etc., so I had to fix a decl-after-statement. Closes: #351 Approved by: jlebon
2016-06-17 09:36:51 -04:00
libreaddir_rand_la_CFLAGS = $(AM_CFLAGS) $(OT_INTERNAL_GIO_UNIX_CFLAGS)
Link libreaddir-rand to libdl It uses dlsym(). There's no point in being extra-portable here because OSTree only targets Linux anyway. Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #336 Approved by: cgwalters
2016-06-12 10:25:21 -04:00
libreaddir_rand_la_LIBADD = \
-ldl \
$(OT_INTERNAL_GIO_UNIX_LIBS) \
$(NULL)
build: Fix libreaddir-rand to honor global CFLAGS It's unfortunate that in automake one has to explicitly include the globa `$(AM_CFLAGS)` if one sets `CFLAGS`, and similarly for other variables. I'm trying to use `-fsanitize=address`, and not including it was causing linker failures. We also weren't inheriting the global warnings etc., so I had to fix a decl-after-statement. Closes: #351 Approved by: jlebon
2016-06-17 09:36:51 -04:00
libreaddir_rand_la_LDFLAGS = $(AM_LDFLAGS) -avoid-version
Force libreaddir-rand to be a shared library If installed-tests are disabled, it would normally be a static (convenience) library, which isn't something we can LD_PRELOAD. Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #232 Approved by: cgwalters
2016-03-31 10:17:02 +01:00
if !ENABLE_INSTALLED_TESTS
libreaddir_rand_la_LDFLAGS += -rpath $(abs_builddir)
endif
tests: Run all tests through a randomized readdir() Having undefined (but in practice rarely changing) ordering for `readdir()` ended up screwing us over for bootloader config generation; see https://bugzilla.redhat.com/show_bug.cgi?id=1226520 Let's make things significantly more likely to fail more quickly in the future if similar bugs are introduced. We accomplish this by introducing a little `LD_PRELOAD` library that randomizes the results of `readdir()`.
2015-06-01 22:34:14 -04:00
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
test_programs = tests/test-varint tests/test-ot-unix-utils tests/test-bsdiff tests/test-mutable-tree \
gpg: Add OstreeGpgVerifyResult Wrappers a referenced gpgme_verify_result_t so detailed verify results can be examined independently of executing a verify operation. _ostree_gpg_verifier_check_signature() now returns this object instead of a single valid/invalid boolean, but the idea is for OstreeRepo to also return this object for commit signature verification so it can be utilized at the CLI layer (and possibly by other programs).
2015-03-04 12:44:47 -05:00
tests/test-keyfile-utils tests/test-ot-opt-utils tests/test-ot-tool-util \
tests: Unify some tmpdir code, add ability for C to use libtest.sh I want to be able to easily test the C API on actual data in an OSTree repo. The shell `libtest.sh` has code to generate it. Bridge the two worlds by introducing a little `libostreetest` library which has a C API which spawns a shell that runs things in `libtest.sh`. Yes, this is about as beautiful as it sounds, which is to say, it's not. But it works! Note while we were here, I realized we were actually now creating *two* tmpdirs per test in `make check` because the tap driver was already doing that. Unify it so we know the C code can rely on it.
2016-03-02 10:05:08 -05:00
tests/test-gpg-verify-result tests/test-checksum tests/test-lzma tests/test-rollsum \
tests/test-pull-c: New test that runs through the pull API via C We have had in the past issues with running `ostree_repo_pull()` multiple times in the same process, embarassingly enough. Nothing in the current test suite covers this, so let's start. Closes: #322 Approved by: jlebon
2016-06-06 14:49:11 -04:00
tests/test-basic-c tests/test-sysroot-c tests/test-pull-c
tests: add test for test-ot-opt-utils. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-06 11:38:13 +01:00
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
# An interactive tool
noinst_PROGRAMS += tests/test-rollsum-cli
repo: Add ostree_repo_import_archive_to_mtree This is a more flexible version of the previous ostree_repo_write_archive_to_mtree() which took a file reference. This has an extensible options structure, and in particular now supports `ignore_unsupported_content`. I plan to use this for importing Docker images which contain device nodes. (There's no reason for container images to have those, so we'll just ignore them). Also here, just like the export variant, the caller is responsible for setting up libarchive.
2016-02-18 16:49:30 -05:00
if USE_LIBARCHIVE
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
test_programs += tests/test-libarchive-import
repo: Add ostree_repo_import_archive_to_mtree This is a more flexible version of the previous ostree_repo_write_archive_to_mtree() which took a file reference. This has an extensible options structure, and in particular now supports `ignore_unsupported_content`. I plan to use this for importing Docker images which contain device nodes. (There's no reason for container images to have those, so we'll just ignore them). Also here, just like the export variant, the caller is responsible for setting up libarchive.
2016-02-18 16:49:30 -05:00
endif
tests: Unify some tmpdir code, add ability for C to use libtest.sh I want to be able to easily test the C API on actual data in an OSTree repo. The shell `libtest.sh` has code to generate it. Bridge the two worlds by introducing a little `libostreetest` library which has a C API which spawns a shell that runs things in `libtest.sh`. Yes, this is about as beautiful as it sounds, which is to say, it's not. But it works! Note while we were here, I realized we were actually now creating *two* tmpdirs per test in `make check` because the tap driver was already doing that. Unify it so we know the C code can rely on it.
2016-03-02 10:05:08 -05:00
common_tests_cflags = $(ostree_bin_shared_cflags) $(OT_INTERNAL_GIO_UNIX_CFLAGS) -I$(srcdir)/libglnx
common_tests_ldadd = $(ostree_bin_shared_ldadd) $(OT_INTERNAL_GIO_UNIX_LIBS)
noinst_LTLIBRARIES += libostreetest.la
libostreetest_la_SOURCES = tests/libostreetest.c
libostreetest_la_CFLAGS = $(common_tests_cflags) -I $(srcdir)/tests
libostreetest_la_LIBADD = $(common_tests_ldadd)
TESTS_CFLAGS = $(common_tests_cflags)
TESTS_LDADD = $(common_tests_ldadd) libostreetest.la
tests: Move test-varint and test-rollsum under "make check" "make check" tests are always enabled and they do not require to be installed. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-02-02 12:56:40 +01:00
tests: rename test-rollsum to test-rollsum-cli Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-08-14 08:43:44 +02:00
tests_test_rollsum_cli_SOURCES = src/libostree/ostree-rollsum.c tests/test-rollsum-cli.c
tests_test_rollsum_cli_CFLAGS = $(TESTS_CFLAGS) $(OT_DEP_ZLIB_CFLAGS)
tests_test_rollsum_cli_LDADD = libbupsplit.la $(TESTS_LDADD) $(OT_DEP_ZLIB_LIBS)
tests: Move test-varint and test-rollsum under "make check" "make check" tests are always enabled and they do not require to be installed. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-02-02 12:56:40 +01:00
tests: Add tests for rollsum
2015-08-25 09:27:56 -04:00
tests_test_rollsum_SOURCES = src/libostree/ostree-rollsum.c tests/test-rollsum.c
tests_test_rollsum_CFLAGS = $(TESTS_CFLAGS) $(OT_DEP_ZLIB_CFLAGS)
tests_test_rollsum_LDADD = libbupsplit.la $(TESTS_LDADD) $(OT_DEP_ZLIB_LIBS)
tests: add tests for mutable tree. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-04 14:14:18 +01:00
tests_test_mutable_tree_CFLAGS = $(TESTS_CFLAGS)
tests_test_mutable_tree_LDADD = $(TESTS_LDADD)
tests: Unify some tmpdir code, add ability for C to use libtest.sh I want to be able to easily test the C API on actual data in an OSTree repo. The shell `libtest.sh` has code to generate it. Bridge the two worlds by introducing a little `libostreetest` library which has a C API which spawns a shell that runs things in `libtest.sh`. Yes, this is about as beautiful as it sounds, which is to say, it's not. But it works! Note while we were here, I realized we were actually now creating *two* tmpdirs per test in `make check` because the tap driver was already doing that. Unify it so we know the C code can rely on it.
2016-03-02 10:05:08 -05:00
tests_test_basic_c_CFLAGS = $(TESTS_CFLAGS)
tests_test_basic_c_LDADD = $(TESTS_LDADD)
lib: Add ostree_sysroot_load_if_changed() API This will allow daemons like rpm-ostree to detect if there are any new deployments efficiently, in combination with using inotify. If there are any changes, rpm-ostree wants publish them on DBus. While we're here, add some changes to start doing unit C testing of the sysroot API.
2016-03-03 13:49:54 -05:00
tests_test_sysroot_c_CFLAGS = $(TESTS_CFLAGS)
tests_test_sysroot_c_LDADD = $(TESTS_LDADD)
tests/test-pull-c: New test that runs through the pull API via C We have had in the past issues with running `ostree_repo_pull()` multiple times in the same process, embarassingly enough. Nothing in the current test suite covers this, so let's start. Closes: #322 Approved by: jlebon
2016-06-06 14:49:11 -04:00
tests_test_pull_c_CFLAGS = $(TESTS_CFLAGS)
tests_test_pull_c_LDADD = $(TESTS_LDADD)
tests: Remove some duplications from Makefile-tests.am Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-03 14:21:40 +01:00
tests_test_ot_unix_utils_CFLAGS = $(TESTS_CFLAGS)
tests_test_ot_unix_utils_LDADD = $(TESTS_LDADD)
tests: Move test-varint and test-rollsum under "make check" "make check" tests are always enabled and they do not require to be installed. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-02-02 12:56:40 +01:00
tests: Remove some duplications from Makefile-tests.am Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-03 14:21:40 +01:00
tests_test_varint_SOURCES = src/libostree/ostree-varint.c tests/test-varint.c
tests_test_varint_CFLAGS = $(TESTS_CFLAGS)
tests_test_varint_LDADD = $(TESTS_LDADD)
tests: add test for bsdiff Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-02-23 10:05:19 +01:00
tests: Remove some duplications from Makefile-tests.am Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-03 14:21:40 +01:00
tests_test_bsdiff_CFLAGS = $(TESTS_CFLAGS)
tests_test_bsdiff_LDADD = libbsdiff.la $(TESTS_LDADD)
keyfile-utils: add tests Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-05 15:40:52 +01:00
core: new function _ostree_parse_delta_name Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-04-28 17:45:37 +02:00
tests_test_checksum_SOURCES = src/libostree/ostree-core.c tests/test-checksum.c
tests_test_checksum_CFLAGS = $(TESTS_CFLAGS) $(libglnx_cflags)
tests_test_checksum_LDADD = $(TESTS_LDADD)
repo: Add ostree_repo_import_archive_to_mtree This is a more flexible version of the previous ostree_repo_write_archive_to_mtree() which took a file reference. This has an extensible options structure, and in particular now supports `ignore_unsupported_content`. I plan to use this for importing Docker images which contain device nodes. (There's no reason for container images to have those, so we'll just ignore them). Also here, just like the export variant, the caller is responsible for setting up libarchive.
2016-02-18 16:49:30 -05:00
tests_test_libarchive_import_SOURCES = tests/test-libarchive-import.c
test-libarchive: fix underlinking Signed-off-by: Simon McVittie <smcv@debian.org>
2016-03-11 08:46:27 +00:00
tests_test_libarchive_import_CFLAGS = $(TESTS_CFLAGS) $(libglnx_cflags) $(OT_DEP_LIBARCHIVE_CFLAGS)
tests_test_libarchive_import_LDADD = $(TESTS_LDADD) $(OT_DEP_LIBARCHIVE_LIBS)
repo: Add ostree_repo_import_archive_to_mtree This is a more flexible version of the previous ostree_repo_write_archive_to_mtree() which took a file reference. This has an extensible options structure, and in particular now supports `ignore_unsupported_content`. I plan to use this for importing Docker images which contain device nodes. (There's no reason for container images to have those, so we'll just ignore them). Also here, just like the export variant, the caller is responsible for setting up libarchive.
2016-02-18 16:49:30 -05:00
keyfile-utils: add tests Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-05 15:40:52 +01:00
tests_test_keyfile_utils_CFLAGS = $(TESTS_CFLAGS)
tests_test_keyfile_utils_LDADD = $(TESTS_LDADD)
tests: add test for test-ot-opt-utils. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-06 11:38:13 +01:00
tests_test_ot_opt_utils_CFLAGS = $(TESTS_CFLAGS)
tests_test_ot_opt_utils_LDADD = $(TESTS_LDADD)
tests: Add tests for test-ot-tool-util Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-06 12:54:53 +01:00
tests_test_ot_tool_util_CFLAGS = $(TESTS_CFLAGS)
tests_test_ot_tool_util_LDADD = $(TESTS_LDADD)
gpg: Add OstreeGpgVerifyResult Wrappers a referenced gpgme_verify_result_t so detailed verify results can be examined independently of executing a verify operation. _ostree_gpg_verifier_check_signature() now returns this object instead of a single valid/invalid boolean, but the idea is for OstreeRepo to also return this object for commit signature verification so it can be utilized at the CLI layer (and possibly by other programs).
2015-03-04 12:44:47 -05:00
tests: add tests for LZMA compressor and decompressor Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-08-11 11:26:14 +02:00
tests_test_lzma_SOURCES = src/libostree/ostree-lzma-common.c src/libostree/ostree-lzma-compressor.c \
src/libostree/ostree-lzma-decompressor.c tests/test-lzma.c
tests: Build test-lzma with LZMA flags test-lzma builds a copy of the compressor and decompressor directly, so the compiler needs access to the LZMA headers and the linker needs to link the program with liblzma.
2015-08-26 09:54:31 -07:00
tests_test_lzma_CFLAGS = $(TESTS_CFLAGS) $(OT_DEP_LZMA_CFLAGS)
tests_test_lzma_LDADD = $(TESTS_LDADD) $(OT_DEP_LZMA_LIBS)
tests: add tests for LZMA compressor and decompressor Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-08-11 11:26:14 +02:00
gpg: Add OstreeGpgVerifyResult Wrappers a referenced gpgme_verify_result_t so detailed verify results can be examined independently of executing a verify operation. _ostree_gpg_verifier_check_signature() now returns this object instead of a single valid/invalid boolean, but the idea is for OstreeRepo to also return this object for commit signature verification so it can be utilized at the CLI layer (and possibly by other programs).
2015-03-04 12:44:47 -05:00
tests_test_gpg_verify_result_SOURCES = \
src/libostree/ostree-gpg-verify-result-private.h \
tests/test-gpg-verify-result.c
tests: Link test-gpg-verify-result with gpgme This test uses gpgme directly to verify the signatures, so it needs to find the gpgme headers and link with gpgme to ensure the linker can resolve the symbols.
2015-05-12 15:48:22 -07:00
tests_test_gpg_verify_result_CFLAGS = $(TESTS_CFLAGS) $(OT_INTERNAL_GPGME_CFLAGS)
tests_test_gpg_verify_result_LDADD = $(TESTS_LDADD) $(OT_INTERNAL_GPGME_LIBS)
gpg: Add OstreeGpgVerifyResult Wrappers a referenced gpgme_verify_result_t so detailed verify results can be examined independently of executing a verify operation. _ostree_gpg_verifier_check_signature() now returns this object instead of a single valid/invalid boolean, but the idea is for OstreeRepo to also return this object for commit signature verification so it can be utilized at the CLI layer (and possibly by other programs).
2015-03-04 12:44:47 -05:00
EXTRA_DIST += \
tests: add libostreetest.h to EXTRA_DIST Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Closes: #242 Approved by: cgwalters
2016-04-07 09:53:54 +02:00
tests/libostreetest.h \
build: distribute more test files Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #337 Approved by: cgwalters
2016-06-12 10:45:48 +01:00
tests/libtest.sh \
gpg: Add OstreeGpgVerifyResult Wrappers a referenced gpgme_verify_result_t so detailed verify results can be examined independently of executing a verify operation. _ostree_gpg_verifier_check_signature() now returns this object instead of a single valid/invalid boolean, but the idea is for OstreeRepo to also return this object for commit signature verification so it can be utilized at the CLI layer (and possibly by other programs).
2015-03-04 12:44:47 -05:00
tests/gpg-verify-data/README.md \
tests: Remove gpg verification files from EXTRA_DIST Follow on from 70a11189. These files are already disted. Closes: #372 Approved by: cgwalters
2016-05-13 06:47:09 -07:00
$(NULL)
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
build: Make tests/libreaddir-rand.so rule use AM_V_GEN So non-verbose builds don't have a verbose rule smack in the middle. Closes: #241 Approved by: giuseppe
2016-04-06 21:26:38 -04:00
tests/libreaddir-rand.so: Makefile
$(AM_V_GEN) ln -fns ../.libs/libreaddir-rand.so tests
ALL_LOCAL_RULES += tests/libreaddir-rand.so
Makefile-tests.am: make check uses the built binaries The tests suite was failing locally as it was using the installed version of rofiles-fuse, instead of the built one. Create the needed symlinks in tests/ as we are already doing for the "ostree" binary. ostree-prepare-root and ostree-remount added for completeness. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Closes: #395 Approved by: cgwalters
2016-07-14 13:42:32 +02:00
CLEANFILES += tests/libreaddir-rand.so tests/ostree-symlink-stamp \
tests/ostree-prepare-root-symlink-stamp tests/ostree-remount-symlink-stamp \
tests/rofiles-fuse-symlink-stamp tests/ostree
tests: Modernize valgrind infrastructure The recent memleak fixes motivated me to look at the bitrotted code to run invocations of `ostree` in the test suite underneath valgrind. There are a few things here. First, update suppressions file from libhif, since I recently worked on it. When running *uninstalled* as we now support, we need `libtool --mode=execute` in the mix so it expands out to the uninstalled binary and we don't valgrind the intermediate shell. However, it's harder than that because we chdir into a tmpdir, which defeats the libtool logic. AFAICS, the only fix for this is to determine the realbin path before we chdir, and then unfortunately we need to change every use of `ostree` to `${OSTREE}` =( Then this immediately breaks for me on RHEL7 because my ancient copy of `valgrind-3.10.0-16.el7.x86_64` is unaware of syscall 306, i.e. `syncfs`. But let's do this first before I dive into that. Closes: #292 Approved by: krnowak
2016-05-11 15:54:48 -04:00
build: Make symlink depend on source Closes: https://github.com/ostreedev/ostree/issues/389 Closes: #400 Approved by: smcv
2016-07-15 11:17:43 -04:00
tests/%-symlink-stamp: % Makefile
$(AM_V_GEN) set -e; \
Makefile-tests.am: make check uses the built binaries The tests suite was failing locally as it was using the installed version of rofiles-fuse, instead of the built one. Create the needed symlinks in tests/ as we are already doing for the "ostree" binary. ostree-prepare-root and ostree-remount added for completeness. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Closes: #395 Approved by: cgwalters
2016-07-14 13:42:32 +02:00
lt_bin=`cd $(top_builddir) && ./libtool --mode=execute echo $*`; \
if test "$${lt_bin}" = "$*"; then \
real_bin=$(abs_top_builddir)/$*; \
else \
real_bin="$${lt_bin}"; \
fi; \
ln -sf "$${real_bin}" tests/$*; \
tests: Modernize valgrind infrastructure The recent memleak fixes motivated me to look at the bitrotted code to run invocations of `ostree` in the test suite underneath valgrind. There are a few things here. First, update suppressions file from libhif, since I recently worked on it. When running *uninstalled* as we now support, we need `libtool --mode=execute` in the mix so it expands out to the uninstalled binary and we don't valgrind the intermediate shell. However, it's harder than that because we chdir into a tmpdir, which defeats the libtool logic. AFAICS, the only fix for this is to determine the realbin path before we chdir, and then unfortunately we need to change every use of `ostree` to `${OSTREE}` =( Then this immediately breaks for me on RHEL7 because my ancient copy of `valgrind-3.10.0-16.el7.x86_64` is unaware of syscall 306, i.e. `syncfs`. But let's do this first before I dive into that. Closes: #292 Approved by: krnowak
2016-05-11 15:54:48 -04:00
touch $@
Symlink libreaddir-rand.so into tests directory This means it can be LD_PRELOADed during build-time testing. Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #232 Approved by: cgwalters
2016-03-28 13:46:23 +01:00
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
# Unfortunately the glib test data APIs don't actually handle
# non-recursive Automake, so we change our code to canonically look
# for tests/ which is just a symlink when installed.
build: Don't install test data without --enable-installed-tests Otherwise $(installed_testdir) is empty so we try to put content in `/`, which I noticed when trying to build an RPM (it works works fine `sudo make install`).
2016-03-08 13:12:00 -05:00
if ENABLE_INSTALLED_TESTS
tests: Port to glib-tap.mk, make `make check` run all of the tests OSTree's code for testing predates the `glib-tap.mk` making its way into GLib. Let's switch to it, as it provides a number of advantages. By far the biggest advantage is that `make check` can start to run most of the tests *in addition* to having them work installed. This commit keeps the installed tests working, but `make check` turns out to be really broken because...our TAP usage has bitrotted to say the least. Fix that all up. Do some hacks so that the tests work uninstalled as well - in particular, `glib-tap.mk` and the bits encoded into `g_test_build_filename()` assume *recursive* Automake (blah). Work around that by creating a symlink when installed to loop back.
2016-03-02 10:28:04 -05:00
install-test-data-file-path-hack:
if test -L $(DESTDIR)$(installed_testdir)/tests; then \
rm $(DESTDIR)$(installed_testdir)/tests; \
fi
ln -s . $(DESTDIR)$(installed_testdir)/tests
INSTALL_DATA_HOOKS += install-test-data-file-path-hack
build: Don't install test data without --enable-installed-tests Otherwise $(installed_testdir) is empty so we try to put content in `/`, which I noticed when trying to build an RPM (it works works fine `sudo make install`).
2016-03-08 13:12:00 -05:00
endif
Reference in New Issue Copy Permalink