From 351ffdb9778436b193ba9d2fbeebe2358e55004f Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Wed, 4 Oct 2017 10:24:21 -0400 Subject: [PATCH] lib/sysroot: Fix pointer going out of scope in unlock code Fixes Coverity CID #1457317 Closes: #1249 Approved by: jlebon --- src/libostree/ostree-sysroot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libostree/ostree-sysroot.c b/src/libostree/ostree-sysroot.c index b49b4277..984e16d5 100644 --- a/src/libostree/ostree-sysroot.c +++ b/src/libostree/ostree-sysroot.c @@ -1703,6 +1703,7 @@ ostree_sysroot_deployment_unlock (OstreeSysroot *self, return FALSE; const char *ovl_options = NULL; + static const char hotfix_ovl_options[] = "lowerdir=usr,upperdir=.usr-ovl-upper,workdir=.usr-ovl-work"; switch (unlocked_state) { case OSTREE_DEPLOYMENT_UNLOCKED_NONE: @@ -1710,7 +1711,6 @@ ostree_sysroot_deployment_unlock (OstreeSysroot *self, break; case OSTREE_DEPLOYMENT_UNLOCKED_HOTFIX: { - const char hotfix_ovl_options[] = "lowerdir=usr,upperdir=.usr-ovl-upper,workdir=.usr-ovl-work"; /* Create the overlayfs directories in the deployment root * directly for hotfixes. The ostree-prepare-root.c helper * is also set up to detect and mount these.