From 8eec337feee95d76f14f6e1b39e0b08673e40c22 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Mon, 31 Jul 2017 12:27:31 -0400 Subject: [PATCH] lib/deltas: Squash Coverity warning for div-by-zero in delta show If a delta happens to have zero objects, we could end up doing a divide-by-zero when inferring endianness. In practice, a zero-object delta isn't possible to generate I think, but let's make sure the code is defensive all the same. Spotted by Coverity. Coverity CID: 1452208 Closes: #1041 Approved by: pwithnall --- src/libostree/ostree-repo-static-delta-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libostree/ostree-repo-static-delta-core.c b/src/libostree/ostree-repo-static-delta-core.c index c8cefdef..b8a2c590 100644 --- a/src/libostree/ostree-repo-static-delta-core.c +++ b/src/libostree/ostree-repo-static-delta-core.c @@ -649,7 +649,7 @@ _ostree_delta_get_endianness (GVariant *superblock, * deltas, period. Past the gigabyte scale you really want * bittorrent or something. */ - if ((total_size / total_objects) > G_MAXUINT32) + if (total_objects > 0 && (total_size / total_objects) > G_MAXUINT32) { is_byteswapped = TRUE; }