From c015fe13fb5e887a6aa62a3a2830affb6fe17e50 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Thu, 9 Jun 2016 10:49:03 -0400 Subject: [PATCH] lib: Add OSTREE_SUPPRESS_SYNCFS environment variable Just to work around valgrind not understanding the `syncfs()` syscall in EL7 right now. Closes: #292 Approved by: krnowak --- src/libostree/ostree-repo-commit.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/libostree/ostree-repo-commit.c b/src/libostree/ostree-repo-commit.c index 6166c652..fc6ffd24 100644 --- a/src/libostree/ostree-repo-commit.c +++ b/src/libostree/ostree-repo-commit.c @@ -1469,10 +1469,16 @@ ostree_repo_commit_transaction (OstreeRepo *self, goto out; } - if (syncfs (self->tmp_dir_fd) < 0) + /* FIXME: Added since valgrind in el7 doesn't know about + * `syncfs`...we should delete this later. + */ + if (g_getenv ("OSTREE_SUPRESS_SYNCFS") == NULL) { - glnx_set_error_from_errno (error); - goto out; + if (syncfs (self->tmp_dir_fd) < 0) + { + glnx_set_error_from_errno (error); + goto out; + } } if (!rename_pending_loose_objects (self, cancellable, error))