From c6a53ef6e8f9491633b0d494991f94c629791e1d Mon Sep 17 00:00:00 2001 From: Nikita Dubrovskii Date: Mon, 5 Sep 2022 14:54:03 +0200 Subject: [PATCH] s390x: use 'libarchive' to modify initrd in SE case --- Makefile-libostree.am | 6 +- src/libostree/ostree-bootloader-zipl.c | 100 ++++++++++++++++------ src/libostree/ostree-libarchive-private.h | 2 + src/libostree/s390x-se-luks-gencpio | 16 ---- 4 files changed, 75 insertions(+), 49 deletions(-) delete mode 100755 src/libostree/s390x-se-luks-gencpio diff --git a/Makefile-libostree.am b/Makefile-libostree.am index f93f712a..ea5e8ed5 100644 --- a/Makefile-libostree.am +++ b/Makefile-libostree.am @@ -284,12 +284,8 @@ EXTRA_DIST += src/libostree/README-gpg src/libostree/bupsplit.h \ src/libostree/ostree-enumtypes.c.template \ src/libostree/ostree-deployment-private.h \ src/libostree/ostree-repo-deprecated.h \ - src/libostree/ostree-version.h \ - src/libostree/s390x-se-luks-gencpio + src/libostree/ostree-version.h install-mkdir-remotes-d-hook: mkdir -p $(DESTDIR)$(sysconfdir)/ostree/remotes.d INSTALL_DATA_HOOKS += install-mkdir-remotes-d-hook - -# Secure Execution: script for creating new initramdisk with LUKS key and config -pkglibexec_SCRIPTS += src/libostree/s390x-se-luks-gencpio diff --git a/src/libostree/ostree-bootloader-zipl.c b/src/libostree/ostree-bootloader-zipl.c index fc0614c0..05a3b2ac 100644 --- a/src/libostree/ostree-bootloader-zipl.c +++ b/src/libostree/ostree-bootloader-zipl.c @@ -20,6 +20,7 @@ #include "ostree-sysroot-private.h" #include "ostree-bootloader-zipl.h" #include "ostree-deployment-private.h" +#include "ostree-libarchive-private.h" #include "otutil.h" #include #include @@ -34,7 +35,10 @@ #define SECURE_EXECUTION_LUKS_ROOT_KEY "/etc/luks/root" #define SECURE_EXECUTION_LUKS_BOOT_KEY "/etc/luks/boot" #define SECURE_EXECUTION_LUKS_CONFIG "/etc/crypttab" -#define SECURE_EXECUTION_RAMDISK_TOOL PKGLIBEXECDIR "/s390x-se-luks-gencpio" + +#if !(defined HAVE_LIBARCHIVE) && defined(__s390x__) +#error libarchive is required for s390x +#endif /* This is specific to zipl today, but in the future we could also * use it for the grub2-mkconfig case. @@ -199,16 +203,72 @@ _ostree_secure_execution_luks_key_exists (void) access(SECURE_EXECUTION_LUKS_BOOT_KEY, F_OK) == 0); } +static gboolean +_ostree_secure_execution_append_luks_keys (int initrd_fd, + GCancellable *cancellable, + GError **error) +{ +#ifdef HAVE_LIBARCHIVE + // appending cpio gzip archive with LUKS keys + g_autoptr(OtAutoArchiveWrite) a = archive_write_new (); + g_assert (a != NULL); + + if (archive_write_set_format_cpio_newc (a) != 0 || + archive_write_add_filter_gzip (a) != 0 || + archive_write_open_fd(a, initrd_fd) != 0) + return glnx_prefix_error (error, "s390x SE: initing cpio: %s", archive_error_string (a)); + + const char *files[] = {"/etc", "/etc/luks", SECURE_EXECUTION_LUKS_CONFIG, SECURE_EXECUTION_LUKS_BOOT_KEY, SECURE_EXECUTION_LUKS_ROOT_KEY}; + for (uint i = 0; i != G_N_ELEMENTS (files); ++i) + { + const char *path = files[i]; + struct stat st; + if (stat(path, &st) != 0) + glnx_throw_errno_prefix (error, "s390x SE: stat(%s) failed", path); + + g_autoptr(OtArchiveEntry) ae = archive_entry_new (); + g_assert (ae != NULL); + + archive_entry_copy_stat (ae, &st); + archive_entry_set_pathname (ae, path); + if (archive_write_header (a, ae) != 0) + glnx_prefix_error (error, "s390x SE: writing cpio header: %s", archive_error_string (a)); + + if (S_ISREG (st.st_mode)) + { + ot_journal_print(LOG_INFO, "s390x SE: appending %s to initrd", path); + glnx_autofd int fd = -1; + if (!glnx_openat_rdonly (AT_FDCWD, path, TRUE, &fd, error)) + return glnx_prefix_error (error, "s390x SE: opening %s", path); + g_autoptr(GBytes) data = glnx_fd_readall_bytes (fd, cancellable, error); + if (!data) + return glnx_prefix_error (error, "s390x SE: reading %s", path); + + gsize size = 0; + const char *ptr = (const char *) g_bytes_get_data (data, &size); + ssize_t written = archive_write_data (a, ptr, size); + if (written == -1) + return glnx_prefix_error (error, "s390x SE: writing cpio entry: %s", archive_error_string (a)); + if (written != size) + return glnx_prefix_error (error, "s390x SE: writing cpio entry %zd != %zu", written, size); + } + } + ot_journal_print(LOG_INFO, "s390x SE: luks keys added to initrd"); + return TRUE; + #else + return glnx_throw (error, "'libarchive' is required for s390x"); + #endif +} + static gboolean _ostree_secure_execution_generate_initrd (const gchar *initrd, GLnxTmpfile *out_initrd, - gchar **out_initrdname, + GCancellable *cancellable, GError **error) { if (!_ostree_secure_execution_luks_key_exists ()) return glnx_throw (error, "s390x SE: missing luks keys and config"); - if (!glnx_open_anonymous_tmpfile (O_RDWR | O_CLOEXEC, out_initrd, error)) return glnx_prefix_error (error, "s390x SE: opening new ramdisk"); { @@ -218,26 +278,7 @@ _ostree_secure_execution_generate_initrd (const gchar *initrd, return glnx_throw_errno_prefix (error, "s390x SE: copying ramdisk"); } - g_autofree gchar *tmpdir = g_mkdtemp (g_strdup ("/var/tmp/se-initramfs-XXXXXX")); - - *out_initrdname = g_strdup_printf ("/proc/%d/fd/%d", getpid (), out_initrd->fd); - const char *const argv[] = {SECURE_EXECUTION_RAMDISK_TOOL, *out_initrdname, tmpdir, NULL}; - g_autofree gchar *out = NULL; - g_autofree gchar *err = NULL; - int status = 0; - if (!g_spawn_sync (NULL, (char**)argv, NULL, G_SPAWN_SEARCH_PATH, - NULL, NULL, &out, &err, &status, error)) - return glnx_prefix_error(error, "s390x SE: spawning %s", SECURE_EXECUTION_RAMDISK_TOOL); - - if (!g_spawn_check_exit_status (status, error)) - { - g_printerr("s390x SE: `%s` stdout: %s\n", SECURE_EXECUTION_RAMDISK_TOOL, out); - g_printerr("s390x SE: `%s` stderr: %s\n", SECURE_EXECUTION_RAMDISK_TOOL, err); - return glnx_prefix_error(error, "s390x SE: `%s` failed", SECURE_EXECUTION_RAMDISK_TOOL); - } - - ot_journal_print(LOG_INFO, "s390x SE: luks keys added to initrd"); - return TRUE; + return _ostree_secure_execution_append_luks_keys (out_initrd->fd, cancellable, error); } static gboolean @@ -245,6 +286,7 @@ _ostree_secure_execution_generate_sdboot (gchar *vmlinuz, gchar *initramfs, gchar *options, GPtrArray *keys, + GCancellable *cancellable, GError **error) { g_assert (vmlinuz && initramfs && options && keys && keys->len); @@ -252,19 +294,21 @@ _ostree_secure_execution_generate_sdboot (gchar *vmlinuz, ot_journal_print(LOG_INFO, "s390x SE: initrd: %s", initramfs); ot_journal_print(LOG_INFO, "s390x SE: kargs: %s", options); + pid_t self = getpid (); + // Store kernel options to temp file, so `genprotimg` can later embed it g_auto(GLnxTmpfile) cmdline = { 0, }; if (!glnx_open_anonymous_tmpfile (O_RDWR | O_CLOEXEC, &cmdline, error)) return glnx_prefix_error (error, "s390x SE: opening cmdline file"); if (glnx_loop_write (cmdline.fd, options, strlen (options)) < 0) - return glnx_throw_errno_prefix (error, "s390x SE: writting cmdline file"); - g_autofree gchar *cmdline_filename = g_strdup_printf ("/proc/%d/fd/%d", getpid (), cmdline.fd); + return glnx_throw_errno_prefix (error, "s390x SE: writing cmdline file"); + g_autofree gchar *cmdline_filename = g_strdup_printf ("/proc/%d/fd/%d", self, cmdline.fd); // Copy initramfs to temp file and embed LUKS keys & config into it g_auto(GLnxTmpfile) ramdisk = { 0, }; - g_autofree gchar *ramdisk_filename = NULL; - if (!_ostree_secure_execution_generate_initrd (initramfs, &ramdisk, &ramdisk_filename, error)) + if (!_ostree_secure_execution_generate_initrd (initramfs, &ramdisk, cancellable, error)) return FALSE; + g_autofree gchar *ramdisk_filename = g_strdup_printf ("/proc/%d/fd/%d", self, ramdisk.fd); g_autoptr(GPtrArray) argv = g_ptr_array_new (); g_ptr_array_add (argv, "genprotimg"); @@ -328,7 +372,7 @@ _ostree_secure_execution_enable (OstreeBootloaderZipl *self, gboolean rc = _ostree_secure_execution_mount (error) && _ostree_secure_execution_get_bls_config (self, bootversion, &vmlinuz, &initramfs, &options, cancellable, error) && - _ostree_secure_execution_generate_sdboot (vmlinuz, initramfs, options, keys, error) && + _ostree_secure_execution_generate_sdboot (vmlinuz, initramfs, options, keys, cancellable, error) && _ostree_secure_execution_call_zipl (error) && _ostree_secure_execution_umount (error); diff --git a/src/libostree/ostree-libarchive-private.h b/src/libostree/ostree-libarchive-private.h index 6e6daddb..4eaeaedb 100644 --- a/src/libostree/ostree-libarchive-private.h +++ b/src/libostree/ostree-libarchive-private.h @@ -38,6 +38,8 @@ G_BEGIN_DECLS #ifdef HAVE_LIBARCHIVE typedef struct archive OtAutoArchiveWrite; G_DEFINE_AUTOPTR_CLEANUP_FUNC(OtAutoArchiveWrite, archive_write_free) +typedef struct archive_entry OtArchiveEntry; +G_DEFINE_AUTOPTR_CLEANUP_FUNC(OtArchiveEntry, archive_entry_free) typedef struct archive OtAutoArchiveRead; G_DEFINE_AUTOPTR_CLEANUP_FUNC(OtAutoArchiveRead, archive_read_free) diff --git a/src/libostree/s390x-se-luks-gencpio b/src/libostree/s390x-se-luks-gencpio deleted file mode 100755 index 4e5d7ad8..00000000 --- a/src/libostree/s390x-se-luks-gencpio +++ /dev/null @@ -1,16 +0,0 @@ -#!/bin/bash -# This script appends LUKS keys and config to initrd -set -euo pipefail - -initrd=$1 -tmpdir=$2 - -# Appending LUKS root keys and crypttab config to the end of initrd -cd ${tmpdir} -mkdir -p etc/luks -cp -f /etc/luks/* etc/luks/ -cp -f /etc/crypttab etc/ -find . -mindepth 1 | cpio --quiet -H newc -o | gzip -9 -n >> ${initrd} - -# Cleanup -rm -rf etc/