5 Commits

Author	SHA1	Message	Date
Colin Walters	74e3581ed6	lib/repo: Support hardlink conversions from bare-user to bu-only ... Thinking about the problem of flatpak converting from `bare-user` to `bare-user-only` "in place" by creating a new repo and doing a `pull-local`, I realized that we can optimize this process by doing hardlinks for both metadata and regular files. The repo formats are *almost* compatible, the exception being symlinks. An earlier patch caused us to do hardlinks for metadata, this patch takes things to the next step and special cases this specific conversion. In this case we need to parse the source object to determine whether or not it's a symlink. Closes: #922 Approved by: alexlarsson	2017-06-13 12:02:12 +00:00
Colin Walters	8edb5161db	lib/checkout: Ignore world-writable dirs for bare-user-only checkout ... See https://github.com/ostreedev/ostree/pull/909 for more information on the rationale. Basically there's no reason for flatpak (which uses `bare-user-only`) to have world-writable dirs. Particularly with the presence of the system helper. An approach I considered instead was to parse and validate directory metadata objects at commit time. We still may do that in addition; for file objects we *had* to do it that way because the actual files would be laid down suid. But directories live only as inert `.dirmeta` objects until we do a checkout (i.e. `mkdir()`), so we can solve the problem at checkout time. Closes: #914 Approved by: alexlarsson	2017-06-12 14:24:22 +00:00
Colin Walters	c81252c1e0	repo/commit: Support group-writable files for bare-user-only ... These exist in the wild for flatpak, and aren't really a problem. The canonical permissions are still either `0755` or `0644`, we just support the additional writable bit for the group (i.e. extend the set to include `0775` and `0664`) now to avoid breaking some flatpak content. Closes: #913 Approved by: alexlarsson	2017-06-08 06:58:54 +00:00
Colin Walters	81e1f7761f	tests: Add a test for bare-user-only failing to commit suid content ... We didn't have coverage of this before, and adding the test infrastructure will help ensure we have coverage for more changes here. Closes: #913 Approved by: alexlarsson	2017-06-08 06:58:54 +00:00
Alexander Larsson	7c8f95c86f	Add basic tests for bare-user-only repo modes ... This is somewhat complicated by such repos only properly supporting some subset of file metadata (uid/gid 0, etc). We fix this by always commiting with filters that make it work. Closes: #750 Approved by: cgwalters	2017-03-27 13:48:41 +00:00