6397 Commits

Author SHA1 Message Date
Rafael Garcia Ruiz
f6d308f130 Idempotent delete operation for OstreeKernelArgs
ostree_kernel_args_delete_if_present checks if an argument is present
in OstreeKernelArgs and delete it.

Signed-off-by: Rafael Garcia Ruiz <rafael.garcia@collabora.com>
2022-11-18 20:26:28 +01:00
Colin Walters
a34e28ebd0
Merge pull request #2773 from pwithnall/typo-fix
Improve a help string for ostree-commit
2022-11-18 11:35:30 -05:00
Philip Withnall
aef063dfd3 ot-builtin-commit: Don’t mention a C function name in a help string
Instead mention the formal name of the format accepted by
`g_variant_parse()`.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
2022-11-18 15:41:59 +00:00
Philip Withnall
bd487add8c ot-builtin-commit: Fix a typo in a command line help string
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
2022-11-18 15:40:42 +00:00
Dan Nicholson
8229c6d080
Merge pull request #2771 from Razaloc/wip/rafaelgarrui/contains
ostree_kernel_args_contains for OstreeKernelArgs
2022-11-18 06:13:27 -07:00
Rafael Garcia Ruiz
c4db171dae ostree_kernel_args_contains for OstreeKernelArgs
Check if an argument is present in OstreeKernelArgs. This is a way to
make easier idempotent append and delete operations.
ostree_kernel_args_append_if_missing uses it to avoid inserting a
duplicate key.

Closes #2329

Signed-off-by: Rafael Garcia Ruiz <rafael.garcia@collabora.com>
2022-11-18 13:52:08 +01:00
Colin Walters
97e9bc7fd4 fetcher: Avoid too large queues for metadata processing
We added backoff/queueing for fetching via HTTP, but we have
another queue in the metadata scanning which can also grow
up to the number of outstanding objects, which can be large.

Capping the scanning operation when we have hit our operation
limit will avoid potentially large amounts of allocations in the
case of e.g. a slow network.

Closes: https://github.com/ostreedev/ostree/issues/2732
2022-11-14 14:06:05 -05:00
Joseph Marrero Corchado
0dbd87c017
Merge pull request #2765 from cgwalters/drop-openat
rust: Drop `openat` dependency
2022-11-13 13:08:43 -05:00
Colin Walters
ba39acf942
Merge pull request #2751 from smcv/memdup2
Replace calls to g_memdup() with g_memdup2()
2022-11-13 10:50:39 -05:00
Colin Walters
8d08e563b4 rust: Drop openat dependency
We can use cap-std in our tests.
2022-11-13 09:47:53 -05:00
Joseph Marrero Corchado
06ff6a0448
Merge pull request #2764 from cgwalters/bump-cap-std
rust: Update to cap-std 1.0
2022-11-12 14:21:59 -05:00
Simon McVittie
29340dba04 Replace calls to g_memdup() with g_memdup2()
g_memdup() is subject to an integer overflow on 64-bit machines if the
object being copied is larger than UINT_MAX bytes. I suspect none of
these objects can actually be that large in practice, but it's easier
to replace all the calls than it is to assess whether we need to
replace them.

A backport in libglnx is used on systems where GLib is older than 2.68.x.

Signed-off-by: Simon McVittie <smcv@collabora.com>
2022-11-11 17:10:37 -05:00
Colin Walters
6f68e3dc4e rust: Update to cap-std 1.0
This was one source of our semver bumps; let's switch to 1.0.
2022-11-11 17:09:35 -05:00
Colin Walters
bef337e1bd
Merge pull request #2763 from cgwalters/testiso-more-memory
ci: Bump memory for ISO testing flow
2022-11-11 16:11:26 -05:00
Colin Walters
8b75be1762 ci: Bump memory for ISO testing flow
It seems likely that we're allocating more RAM here.  What we really
need to do is for cosa to express the necessary RAM
requirements declaratively, then we compute pod requirements
from that.
2022-11-11 15:03:30 -05:00
Colin Walters
de3a0cefb7
Merge pull request #2762 from lucab/ups/copr-tags
copr: only use libostree tags
2022-11-11 14:08:36 -05:00
Luca BRUNO
4bc79ada27
copr: only use libostree tags
This adds a tag filter to the logic which emits version labels for
COPR build, so that it avoids mistakenly picking up tags belonging
to the Rust bindings.
2022-11-11 14:05:56 +00:00
Luca Bruno
8cb50c16a0
Merge pull request #2760 from cgwalters/offline-deploy-no-bwrap
deploy: Don't rebuild selinux policy on first deployment
2022-11-11 10:16:17 +00:00
Colin Walters
e66e0b06ef
Merge pull request #2754 from cgwalters/remove-readdir-rand
Remove readdir-rand
2022-11-10 05:59:36 -05:00
Colin Walters
a6c97e9129
Merge pull request #2759 from oglok/http_500
Enabling retry for HTTP 500 internal server error
2022-11-09 15:34:08 -05:00
Colin Walters
bd325061dc deploy: Don't rebuild selinux policy on first deployment
Basically, it should not be necessary - the policy should be
up-to-date.  We don't want to force on continual policy rebuilds.

Even trying to run bwrap when we're *not* in a booted
root can cause failures in nested containerization scenarios.

Closes: https://github.com/ostreedev/ostree/issues/2758
2022-11-09 11:18:36 -05:00
Ricardo Noriega
6ce2324e4a Add tests for cases under random 500s
Signed-off-by: Ricardo Noriega <rnoriega@redhat.com>
2022-11-09 11:20:10 +01:00
Ricardo Noriega
722be7e3d7 Enabling retry for HTTP 500 internal server error
Signed-off-by: Ricardo Noriega <rnoriega@redhat.com>

Use G_IO_ERROR_BUSY to represent 500 error

Signed-off-by: Ricardo Noriega <rnoriega@redhat.com>

Make G_IO_ERROR_BUSY independent from glib version

Signed-off-by: Ricardo Noriega <rnoriega@redhat.com>
2022-11-08 18:14:31 +01:00
Colin Walters
e153720f89
Merge pull request #2756 from ostreedev/dependabot/submodules/libglnx-4e44fd9
build(deps): bump libglnx from `e701578` to `4e44fd9`
2022-11-04 11:47:43 -04:00
dependabot[bot]
b93c0d0262
build(deps): bump libglnx from e701578 to 4e44fd9
Bumps libglnx from `e701578` to `4e44fd9`.

---
updated-dependencies:
- dependency-name: libglnx
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-11-02 12:32:15 +00:00
Colin Walters
23446a0218 Remove readdir-rand
This was only there to reproduce a bug we hit long ago
with bootloader file ordering.  We're extremely unlikely
to reintroduce such a bug, and it's not worth carrying around
this code.
2022-11-01 16:29:17 -04:00
Colin Walters
f0c3d09618 deploy: Use semodule --refresh if available
Current FCOS emits a warning:

```
[root@cosa-devsh ~]# journalctl -b -1 -u ostree-finalize-staged --grep=deprecated
Nov 01 20:21:21 cosa-devsh ostree[2481]: The --rebuild-if-modules-changed option is deprecated. Use --refresh instead.
[root@cosa-devsh ~]#
```
2022-11-01 16:23:12 -04:00
Colin Walters
ba94997e99
Merge pull request #2752 from smcv/copy-dirent
readdir-rand: Copy full size of struct dirent
2022-10-31 08:58:21 -04:00
Simon McVittie
3f3a817375 readdir-rand: Copy full size of struct dirent
As noted in readdir(3), in the presence of long filenames it is
possible for a directory entry to be larger than `sizeof (struct dirent)`.
Copy the full length instead.

Signed-off-by: Simon McVittie <smcv@collabora.com>
2022-10-28 12:21:58 +01:00
Luca Bruno
d731ee804d
Merge pull request #2749 from lucab/ups/cargo-releases
cargo: prepare ostree 0.16.0 and ostree-sys 0.11.0
v0.16.0 ostree-sys-v0.11.0
2022-10-28 07:26:08 +00:00
Luca BRUNO
33cf347117
cargo: prepare ostree 0.16.0 and ostree-sys 0.11.0
This prepares for a new release of both crates, now using the
gtk-rs 0.15 stack.
2022-10-27 14:21:23 +00:00
Luca Bruno
2c8977443c
Merge pull request #2748 from lucab/ups/ci-rust-bump-libostree-git
ci/rust: test from git using latest feature
2022-10-27 14:19:38 +00:00
Luca BRUNO
6b2d0067f0
ci/rust: test from git using latest feature 2022-10-27 12:58:43 +00:00
Luca Bruno
fe09de9282
Merge pull request #2743 from lucab/ups/gtk-rs-0.15
rust-bindings: regenerate for gtk-rs 0.15
2022-10-27 12:24:05 +00:00
Luca BRUNO
dbb6daf101
rust/ostree: regenerate for gtk-rs 0.15 2022-10-26 13:49:35 +00:00
Luca BRUNO
0b3833bf55
rust/ostree-sys: regenerate for gtk-rs 0.15 2022-10-26 13:49:34 +00:00
Luca BRUNO
1e0e814f38
rust: update pinned gir tool to 0.15 2022-10-26 13:49:33 +00:00
Colin Walters
1258c371d6
Merge pull request #2742 from lucab/ups/rust-regenerate-2022.6
rust: regenerate bindings after latest release (2022.6)
2022-10-26 09:15:14 -04:00
Colin Walters
9672f88877
Merge pull request #2745 from lucab/ups/ci-bump-rust-linting
ci/rust: bump linting toolchain to latest stable (1.64)
2022-10-26 09:15:01 -04:00
Colin Walters
aded044149
Merge pull request #2746 from lucab/ups/lib-repo-refs-error
lib/repo-refs: properly return an error value
2022-10-26 09:14:48 -04:00
Luca BRUNO
a118410b85
lib/repo-refs: properly return an error value
This tweaks a logic check in order to return a proper error value
when the related condition is not satisfied.
2022-10-26 11:12:52 +00:00
Colin Walters
61d22e5db6
Merge pull request #2740 from lucab/ups/lib-sign-ed25519-assertions
lib/sign-ed25519: convert invariant checks to assertions
2022-10-26 06:33:04 -04:00
Luca BRUNO
9163665a29
ci/rust: bump linting toolchain to latest stable (1.64)
This bumps the Rust toolchain for clippy/rustfmt to 1.64.
2022-10-26 09:27:50 +00:00
Luca BRUNO
10cecd73f0
rust: update manual helpers 2022-10-26 09:26:56 +00:00
Luca BRUNO
6aa7d6e9f7
ostree: manually patch generated files
This manually adds a missing `ToGlibPtr` import, which seems to be result
of some bugs in `gir` code-generation.
2022-10-26 09:26:55 +00:00
Luca BRUNO
f689ca098f
rust: regenerate bindings after latest release (2022.6) 2022-10-26 09:26:54 +00:00
Luca BRUNO
99c2f52a78
lib/sign-ed25519: convert invariant checks to assertions
This converts several invariant checks to asserts. Most of the
functions in this file were already using assertions, so this aligns
the remaining few outliers to the rest.
2022-10-26 09:26:06 +00:00
Luca Bruno
9801689c74
Merge pull request #2744 from lucab/ups/ci-memory-bump
ci: bump cosaPod memory requirement to 5Gi
2022-10-26 09:23:29 +00:00
Jonathan Lebon
52810a41b9
ci: bump cosaPod memory requirement to 5Gi
We're hitting memory limits when running the reprovisioning tests. We
should investigate why we need 1Gi of overhead, but for now to get
unblocked let's just bump it.
2022-10-26 06:42:06 +00:00
Colin Walters
a19cc34883
Merge pull request #2663 from mstuehn/test-static-delta-file
lib/static-delta: document and check parameters format
2022-10-19 17:04:40 -04:00