Merge f10cbd100c into 8aaea0c65d

Release 2024.10

configure.ac

@@ -1,7 +1,7 @@
 AC_PREREQ([2.63])
 dnl To perform a release, follow the instructions in `docs/CONTRIBUTING.md`.
 m4_define([year_version], [2024])
-m4_define([release_version], [10])
+m4_define([release_version], [11])
 m4_define([package_version], [year_version.release_version])
 AC_INIT([libostree], [package_version], [walters@verbum.org])
 is_release_build=no

man/ostree-prepare-root.xml

@@ -120,20 +120,25 @@ License along with this library. If not, see <https://www.gnu.org/licenses/>.
             <varlistentry>
                 <term><varname>root.transient</varname></term>
                 <listitem><para>A boolean value; the default is <literal>false</literal>.
-                   If this is set to <literal>true</literal>, then the <literal>/</literal> filesystem will be a writable <literal>overlayfs</literal>,
+                   Setting this flag to <literal>true</literal> requires composefs (See <literal>composefs.enabled</literal>).
-                   with the upper directory being a hidden directory (in the underlying system root filesystem) that will persist across reboots by default.
+                   When enabled, the root mount point <literal>/</literal> will be an overlayfs whose contents will be stored
-                   However, changes will <emphasis>be discarded</emphasis> on OS updates!
+                   in a tmpfs, and hence discarded on OS upgrade or reboot.
                 </para>
                 <para>
-                   Enabling this option can be very useful for cases such as packages (dpkg/rpm/etc) that write content into <literal>/opt</literal>,
+                   This option is independent of <literal>etc.transient</literal> and <literal>sysroot.readonly</literal>;
-                   particularly where they expect the target to be writable at runtime.  To make that work, ensure that your <literal>/opt</literal>
-                   directory is *not* a symlink to <literal>/var/opt</literal>, but is just an empty directory.
-                </para>
-                <para>
-                   Note the <literal>/usr</literal> mount point remains read-only by default.  This option is independent of <literal>etc.transient</literal> and <literal>sysroot.readonly</literal>;
                    it is supported for example to have <literal>root.transient=true</literal> but <literal>etc.transient=false</literal> in which case changes to <literal>/etc</literal> continue
                    to persist across updates, with the default OSTree 3-way merge applied.
-                </para></listitem>
+                   Also related to persistence it is important to emphasize that <literal>/sysroot</literal> (the physical root filesystem) is still persistent
+                   by default; in-place OS upgrades can be applied.
+                </para>
+                <para>
+                  Enabling this option can make it significantly easier to adopt an image-based model in some circumstances.
+                  For example, if you have a configuration management system that is inspecting machine-specific state and
+                  e.g. dynamically installing packages or applying configuration, it can more easily be adapted to
+                  run on each boot, while still shifting a portion (or ideally most) image configuration to build time
+                  as part of the base image/commit.
+                </para>
+                </listitem>
             </varlistentry>
             <varlistentry>
                 <term><varname>composefs.enabled</varname></term>

tests/libtest.sh

@@ -107,7 +107,7 @@ export TEST_GPG_KEYHOME=${test_tmpdir}/gpghome
 export OSTREE_GPG_HOME=${test_tmpdir}/gpghome/trusted
 
 assert_has_setfattr() {
-    if ! which setfattr 2>/dev/null; then
+    if ! command -v setfattr 2>/dev/null; then
         fatal "no setfattr available to determine xattr support"
     fi
 }
@@ -727,9 +727,9 @@ which_gpg () {
     local opt
 
     # Prefer gpg2 in case gpg refers to gpg1
-    if which gpg2 &>/dev/null; then
+    if command -v gpg2 &>/dev/null; then
         gpg=gpg2
-    elif which gpg &>/dev/null; then
+    elif command -v gpg &>/dev/null; then
         gpg=gpg
     else
         # Succeed but don't return anything.

tests/test-delta-ed25519.sh

@@ -34,7 +34,7 @@ ostree_repo_init repo --mode=archive
 
 mkdir files
 for bin in ${bindatafiles}; do
-    cp $(which ${bin}) files
+    cp $(command -v ${bin}) files
 done
 
 ${CMD_PREFIX} ostree --repo=repo commit -b test -s test --tree=dir=files

tests/test-delta-sign.sh

@@ -35,7 +35,7 @@ ostree_repo_init repo --mode=archive
 
 mkdir files
 for bin in ${bindatafiles}; do
-    cp $(which ${bin}) files
+    cp $(command -v ${bin}) files
 done
 
 ${CMD_PREFIX} ostree --repo=repo commit -b test -s test --tree=dir=files

tests/test-delta.sh

@@ -33,7 +33,7 @@ ostree_repo_init repo --mode=archive
 
 mkdir files
 for bin in ${bindatafiles}; do
-    cp $(which ${bin}) files
+    cp $(command -v ${bin}) files
 done
 
 ${CMD_PREFIX} ostree --repo=repo commit -b test -s test --tree=dir=files