mirror of
https://github.com/ostreedev/ostree.git
synced 2024-12-23 21:35:26 +03:00
d4c7093e37
In the `O_RDONLY` case, we were calling `openat` without a mode argument. However, it's perfectly legal (albeit unusual) to do `open(O_RDONLY|O_CREAT)`. One such application that makes use of this is `flock(1)`. This was actually caught by `_FORTIFY_SOURCE=2`, and once we run `rofiles-fuse` with `-f`, the message is clear: ``` *** invalid openat64 call: O_CREAT or O_TMPFILE without mode ***: rofiles-fuse terminated ======= Backtrace: ========= /lib64/libc.so.6(+0x7c8dc)[0x7f36d9f188dc] /lib64/libc.so.6(__fortify_fail+0x37)[0x7f36d9fbfaa7] /lib64/libc.so.6(+0x10019a)[0x7f36d9f9c19a] rofiles-fuse[0x401768] ... ``` Without `_FORTIFY_SOURCE`, the file gets created, but its mode is completely random. I ran into this while investigating https://github.com/projectatomic/rpm-ostree/pull/1003. Closes: #1200 Approved by: cgwalters
120 lines
4.1 KiB
Bash
Executable File
120 lines
4.1 KiB
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Copyright (C) 2016 Colin Walters <walters@verbum.org>
|
|
#
|
|
# This library is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU Lesser General Public
|
|
# License as published by the Free Software Foundation; either
|
|
# version 2 of the License, or (at your option) any later version.
|
|
#
|
|
# This library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Lesser General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Lesser General Public
|
|
# License along with this library; if not, write to the
|
|
# Free Software Foundation, Inc., 59 Temple Place - Suite 330,
|
|
# Boston, MA 02111-1307, USA.
|
|
|
|
set -euo pipefail
|
|
|
|
. $(dirname $0)/libtest.sh
|
|
|
|
skip_without_fuse
|
|
skip_without_user_xattrs
|
|
|
|
setup_test_repository "bare"
|
|
|
|
echo "1..8"
|
|
|
|
cd ${test_tmpdir}
|
|
mkdir mnt
|
|
# The default content set amazingly doesn't have a non-broken link
|
|
ln -s firstfile files/firstfile-link
|
|
$OSTREE commit -b test2 --tree=dir=files
|
|
$OSTREE checkout -H test2 checkout-test2
|
|
|
|
rofiles-fuse checkout-test2 mnt
|
|
cleanup_fuse() {
|
|
fusermount -u ${test_tmpdir}/mnt || true
|
|
}
|
|
trap cleanup_fuse EXIT
|
|
assert_file_has_content mnt/firstfile first
|
|
echo "ok mount"
|
|
|
|
# Test open(O_TRUNC) directly and via symlink
|
|
for path in firstfile{,-link}; do
|
|
if cp /dev/null mnt/${path} 2>err.txt; then
|
|
assert_not_reached "inplace mutation ${path}"
|
|
fi
|
|
assert_file_has_content err.txt "Read-only file system"
|
|
assert_file_has_content mnt/firstfile first
|
|
assert_file_has_content checkout-test2/firstfile first
|
|
done
|
|
echo "ok failed inplace mutation (open O_TRUNCATE)"
|
|
|
|
# Test chmod
|
|
if chmod 0600 mnt/firstfile 2>err.txt; then
|
|
assert_not_reached "chmod inplace"
|
|
fi
|
|
assert_file_has_content err.txt "chmod:.*Read-only file system"
|
|
# Test chown with regfiles and symlinks
|
|
for path in firstfile baz/alink; do
|
|
if chown -h $(id -u) mnt/${path} 2>err.txt; then
|
|
assert_not_reached "chown inplace ${path}"
|
|
fi
|
|
assert_file_has_content err.txt "chown:.*Read-only file system"
|
|
done
|
|
# And test via dereferencing a symlink
|
|
if chown $(id -u) mnt/firstfile-link 2>err.txt; then
|
|
assert_not_reached "chown inplace firstfile-link"
|
|
fi
|
|
assert_file_has_content err.txt "chown:.*Read-only file system"
|
|
echo "ok failed mutation chmod + chown"
|
|
|
|
# Test creating new files, using chown + chmod on them as well
|
|
echo anewfile-for-fuse > mnt/anewfile-for-fuse
|
|
assert_file_has_content mnt/anewfile-for-fuse anewfile-for-fuse
|
|
assert_file_has_content checkout-test2/anewfile-for-fuse anewfile-for-fuse
|
|
ln -s anewfile-for-fuse mnt/anewfile-for-fuse-link
|
|
# And also test modifications through a symlink
|
|
echo writevialink > mnt/anewfile-for-fuse-link
|
|
for path in anewfile-for-fuse{,-link}; do
|
|
assert_file_has_content mnt/${path} writevialink
|
|
done
|
|
chown $(id -u) mnt/anewfile-for-fuse-link
|
|
|
|
mkdir mnt/newfusedir
|
|
for i in $(seq 5); do
|
|
echo ${i}-morenewfuse-${i} > mnt/newfusedir/test-morenewfuse.${i}
|
|
chmod 0600 mnt/newfusedir/test-morenewfuse.${i}
|
|
chown $(id -u) mnt/newfusedir/test-morenewfuse.${i}
|
|
done
|
|
assert_file_has_content checkout-test2/newfusedir/test-morenewfuse.3 3-morenewfuse-3
|
|
echo "ok new content"
|
|
|
|
rm mnt/baz/cow
|
|
assert_not_has_file checkout-test2/baz/cow
|
|
rm mnt/baz/another -rf
|
|
assert_not_has_dir checkout-test2/baz/another
|
|
|
|
echo "ok deletion"
|
|
|
|
${CMD_PREFIX} ostree --repo=repo commit -b test2 -s fromfuse --link-checkout-speedup --tree=dir=checkout-test2
|
|
|
|
echo "ok commit"
|
|
|
|
${CMD_PREFIX} ostree --repo=repo checkout -U test2 mnt/test2-checkout-copy-fallback
|
|
assert_file_has_content mnt/test2-checkout-copy-fallback/anewfile-for-fuse writevialink
|
|
|
|
if ${CMD_PREFIX} ostree --repo=repo checkout -UH test2 mnt/test2-checkout-copy-hardlinked 2>err.txt; then
|
|
assert_not_reached "Checking out via hardlinks across mountpoint unexpectedly succeeded!"
|
|
fi
|
|
assert_file_has_content err.txt "Unable to do hardlink checkout across devices"
|
|
|
|
echo "ok checkout copy fallback"
|
|
|
|
# check that O_RDONLY|O_CREAT is handled correctly; used by flock(1) at least
|
|
flock mnt/nonexistent-file echo "ok create file in ro mode"
|