mirror of
https://github.com/ostreedev/ostree.git
synced 2024-10-26 17:25:36 +03:00
0fbfc0b207
Currently `ostree_gpg_verify_result_require_valid_signature` always returns an error that the key used for the signature is missing from the keyring. However, all that's been determined is that there are no valid signatures. The error could also be from an expired signature, an expired key, a revoked key or an invalid signature. Provide values for these missing errors and return them from `ostree_gpg_verify_result_require_valid_signature`. The description of each result is appended to the error message, but since the result can contain more than one signature but only a single error can be returned, the status of the last signature is used for the error code. See the comment for rationale. Related: flatpak/flatpak#1450
283 lines
12 KiB
Bash
Executable File
283 lines
12 KiB
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Copyright (C) 2014 Colin Walters <walters@verbum.org>
|
|
#
|
|
# SPDX-License-Identifier: LGPL-2.0+
|
|
#
|
|
# This library is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU Lesser General Public
|
|
# License as published by the Free Software Foundation; either
|
|
# version 2 of the License, or (at your option) any later version.
|
|
#
|
|
# This library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Lesser General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Lesser General Public
|
|
# License along with this library; if not, write to the
|
|
# Free Software Foundation, Inc., 59 Temple Place - Suite 330,
|
|
# Boston, MA 02111-1307, USA.
|
|
|
|
set -euo pipefail
|
|
|
|
. $(dirname $0)/libtest.sh
|
|
|
|
COMMIT_SIGN=""
|
|
if has_gpgme; then
|
|
COMMIT_SIGN="--gpg-homedir=${TEST_GPG_KEYHOME} --gpg-sign=${TEST_GPG_KEYID_1}"
|
|
echo "1..10"
|
|
else
|
|
# Only one test don't need GPG support
|
|
echo "1..1"
|
|
fi
|
|
|
|
setup_fake_remote_repo1 "archive" "${COMMIT_SIGN}"
|
|
|
|
# Now, setup multiple branches
|
|
mkdir ${test_tmpdir}/ostree-srv/other-files
|
|
cd ${test_tmpdir}/ostree-srv/other-files
|
|
echo 'hello world another object' > hello-world
|
|
${CMD_PREFIX} ostree --repo=${test_tmpdir}/ostree-srv/gnomerepo commit ${COMMIT_SIGN} -b other -s "A commit" -m "Another Commit body"
|
|
|
|
mkdir ${test_tmpdir}/ostree-srv/yet-other-files
|
|
cd ${test_tmpdir}/ostree-srv/yet-other-files
|
|
echo 'hello world yet another object' > yet-another-hello-world
|
|
${CMD_PREFIX} ostree --repo=${test_tmpdir}/ostree-srv/gnomerepo commit ${COMMIT_SIGN} -b yet-another -s "A commit" -m "Another Commit body"
|
|
|
|
${CMD_PREFIX} ostree --repo=${test_tmpdir}/ostree-srv/gnomerepo summary -u
|
|
|
|
prev_dir=`pwd`
|
|
cd ${test_tmpdir}
|
|
ostree_repo_init repo --mode=archive
|
|
${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo
|
|
${CMD_PREFIX} ostree --repo=repo pull --mirror origin
|
|
assert_has_file repo/summary
|
|
${CMD_PREFIX} ostree --repo=repo checkout -U main main-copy
|
|
assert_file_has_content main-copy/baz/cow "moo"
|
|
${CMD_PREFIX} ostree --repo=repo checkout -U other other-copy
|
|
assert_file_has_content other-copy/hello-world "hello world another object"
|
|
${CMD_PREFIX} ostree --repo=repo checkout -U yet-another yet-another-copy
|
|
assert_file_has_content yet-another-copy/yet-another-hello-world "hello world yet another object"
|
|
${CMD_PREFIX} ostree --repo=repo fsck
|
|
echo "ok pull mirror summary"
|
|
|
|
if ! has_gpgme; then
|
|
exit 0;
|
|
fi
|
|
|
|
cd $prev_dir
|
|
|
|
${OSTREE} --repo=${test_tmpdir}/ostree-srv/gnomerepo summary -u ${COMMIT_SIGN}
|
|
|
|
repo_reinit () {
|
|
cd ${test_tmpdir}
|
|
rm -rf repo
|
|
mkdir repo
|
|
ostree_repo_init repo --mode=archive
|
|
${OSTREE} --repo=repo remote add --set=gpg-verify-summary=true origin $(cat httpd-address)/ostree/gnomerepo
|
|
}
|
|
|
|
cd ${test_tmpdir}
|
|
repo_reinit
|
|
${OSTREE} --repo=repo pull origin main
|
|
assert_has_file repo/tmp/cache/summaries/origin
|
|
assert_has_file repo/tmp/cache/summaries/origin.sig
|
|
|
|
rm repo/tmp/cache/summaries/origin
|
|
${OSTREE} --repo=repo pull origin main
|
|
assert_has_file repo/tmp/cache/summaries/origin
|
|
|
|
echo "ok pull with signed summary"
|
|
|
|
touch repo/tmp/cache/summaries/foo
|
|
touch repo/tmp/cache/summaries/foo.sig
|
|
${OSTREE} --repo=repo prune
|
|
assert_not_has_file repo/tmp/cache/summaries/foo
|
|
assert_not_has_file repo/tmp/cache/summaries/foo.sig
|
|
assert_has_file repo/tmp/cache/summaries/origin
|
|
assert_has_file repo/tmp/cache/summaries/origin.sig
|
|
echo "ok prune summary cache"
|
|
|
|
cd ${test_tmpdir}
|
|
repo_reinit
|
|
mkdir cachedir
|
|
${OSTREE} --repo=repo pull --cache-dir=cachedir origin main
|
|
assert_not_has_file repo/tmp/cache/summaries/origin
|
|
assert_not_has_file repo/tmp/cache/summaries/origin.sig
|
|
assert_has_file cachedir/summaries/origin
|
|
assert_has_file cachedir/summaries/origin.sig
|
|
|
|
rm cachedir/summaries/origin
|
|
${OSTREE} --repo=repo pull --cache-dir=cachedir origin main
|
|
assert_not_has_file repo/tmp/cache/summaries/origin
|
|
assert_has_file cachedir/summaries/origin
|
|
|
|
echo "ok pull with signed summary and cachedir"
|
|
|
|
cd ${test_tmpdir}
|
|
repo_reinit
|
|
mv ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig{,.good}
|
|
echo invalid > ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig
|
|
if ${OSTREE} --repo=repo pull origin main 2>err.txt; then
|
|
assert_not_reached "Successful pull with invalid GPG sig"
|
|
fi
|
|
assert_file_has_content err.txt "no signatures found"
|
|
mv ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig{.good,}
|
|
echo "ok pull with invalid summary gpg signature fails"
|
|
|
|
cd ${test_tmpdir}
|
|
repo_reinit
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary{,.good}
|
|
# Some leading garbage
|
|
(echo invalid && cat ${test_tmpdir}/ostree-srv/gnomerepo/summary) > summary.bad.tmp && mv summary.bad.tmp ${test_tmpdir}/ostree-srv/gnomerepo/summary
|
|
if ${OSTREE} --repo=repo pull origin main; then
|
|
assert_not_reached "Successful pull with invalid summary"
|
|
fi
|
|
mv ${test_tmpdir}/ostree-srv/gnomerepo/summary{.good,}
|
|
echo "ok pull with invalid summary (leading garbage) fails"
|
|
|
|
# Generate a delta
|
|
${OSTREE} --repo=${test_tmpdir}/ostree-srv/gnomerepo static-delta generate --empty main
|
|
${OSTREE} --repo=${test_tmpdir}/ostree-srv/gnomerepo summary -u ${COMMIT_SIGN}
|
|
|
|
cd ${test_tmpdir}
|
|
repo_reinit
|
|
${OSTREE} --repo=repo pull origin main
|
|
echo "ok pull delta with signed summary"
|
|
|
|
# Verify 'ostree remote summary' output.
|
|
${OSTREE} --repo=repo remote summary origin > summary.txt
|
|
assert_file_has_content summary.txt "* main"
|
|
assert_file_has_content summary.txt "* other"
|
|
assert_file_has_content summary.txt "* yet-another"
|
|
assert_file_has_content summary.txt "found 1 signature"
|
|
assert_file_has_content summary.txt "Good signature from \"Ostree Tester <test@test\.com>\""
|
|
grep static-deltas summary.txt > static-deltas.txt
|
|
assert_file_has_content static-deltas.txt \
|
|
$(${OSTREE} --repo=repo rev-parse origin:main)
|
|
|
|
## Tests for handling of cached summaries while racing with remote summary updates
|
|
|
|
# Make 2 different but valid summary/signature pairs to test races with
|
|
${OSTREE} --repo=${test_tmpdir}/ostree-srv/gnomerepo summary -u ${COMMIT_SIGN}
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary{,.1}
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig{,.1}
|
|
mkdir ${test_tmpdir}/ostree-srv/even-another-files
|
|
cd ${test_tmpdir}/ostree-srv/even-another-files
|
|
echo 'hello world even another object' > even-another-hello-world
|
|
${OSTREE} --repo=${test_tmpdir}/ostree-srv/gnomerepo commit ${COMMIT_SIGN} -b even-another -s "A commit" -m "Another Commit body"
|
|
${OSTREE} --repo=${test_tmpdir}/ostree-srv/gnomerepo summary -u ${COMMIT_SIGN}
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary{,.2}
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig{,.2}
|
|
cd ${test_tmpdir}
|
|
|
|
# Reset to the old valid summary and pull to cache it
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary{.1,}
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig{.1,}
|
|
repo_reinit
|
|
${OSTREE} --repo=repo pull origin main
|
|
assert_has_file repo/tmp/cache/summaries/origin
|
|
assert_has_file repo/tmp/cache/summaries/origin.sig
|
|
cmp repo/tmp/cache/summaries/origin ${test_tmpdir}/ostree-srv/gnomerepo/summary.1 >&2
|
|
cmp repo/tmp/cache/summaries/origin.sig ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig.1 >&2
|
|
|
|
# Simulate a pull race where the client gets the old summary and the new
|
|
# summary signature since it was generated on the server between the
|
|
# requests
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig{.2,}
|
|
if ${OSTREE} --repo=repo pull origin main 2>err.txt; then
|
|
assert_not_reached "Successful pull with old summary"
|
|
fi
|
|
assert_file_has_content err.txt "BAD signature"
|
|
assert_has_file repo/tmp/cache/summaries/origin
|
|
assert_has_file repo/tmp/cache/summaries/origin.sig
|
|
cmp repo/tmp/cache/summaries/origin ${test_tmpdir}/ostree-srv/gnomerepo/summary.1 >&2
|
|
cmp repo/tmp/cache/summaries/origin.sig ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig.1 >&2
|
|
|
|
# Publish correct summary and check that subsequent pull succeeds
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary{.2,}
|
|
${OSTREE} --repo=repo pull origin main
|
|
assert_has_file repo/tmp/cache/summaries/origin
|
|
assert_has_file repo/tmp/cache/summaries/origin.sig
|
|
cmp repo/tmp/cache/summaries/origin ${test_tmpdir}/ostree-srv/gnomerepo/summary.2 >&2
|
|
cmp repo/tmp/cache/summaries/origin.sig ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig.2 >&2
|
|
|
|
echo "ok pull with signed summary remote old summary"
|
|
|
|
# Reset to the old valid summary and pull to cache it
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary{.1,}
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig{.1,}
|
|
repo_reinit
|
|
${OSTREE} --repo=repo pull origin main
|
|
assert_has_file repo/tmp/cache/summaries/origin
|
|
assert_has_file repo/tmp/cache/summaries/origin.sig
|
|
cmp repo/tmp/cache/summaries/origin ${test_tmpdir}/ostree-srv/gnomerepo/summary.1 >&2
|
|
cmp repo/tmp/cache/summaries/origin.sig ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig.1 >&2
|
|
|
|
# Simulate a pull race where the client gets the new summary and the old
|
|
# summary signature. This is unlikely to happen except if the web server
|
|
# is caching the old signature. This should succeed because the cached
|
|
# old summary is used.
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary{.2,}
|
|
${OSTREE} --repo=repo pull origin main
|
|
assert_has_file repo/tmp/cache/summaries/origin
|
|
assert_has_file repo/tmp/cache/summaries/origin.sig
|
|
cmp repo/tmp/cache/summaries/origin ${test_tmpdir}/ostree-srv/gnomerepo/summary.1 >&2
|
|
cmp repo/tmp/cache/summaries/origin.sig ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig.1 >&2
|
|
|
|
# Publish correct signature and check that subsequent pull succeeds
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig{.2,}
|
|
${OSTREE} --repo=repo pull origin main
|
|
assert_has_file repo/tmp/cache/summaries/origin
|
|
assert_has_file repo/tmp/cache/summaries/origin.sig
|
|
cmp repo/tmp/cache/summaries/origin ${test_tmpdir}/ostree-srv/gnomerepo/summary.2 >&2
|
|
cmp repo/tmp/cache/summaries/origin.sig ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig.2 >&2
|
|
|
|
echo "ok pull with signed summary remote old summary signature"
|
|
|
|
# Reset to the old valid summary and pull to cache it
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary{.1,}
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig{.1,}
|
|
repo_reinit
|
|
${OSTREE} --repo=repo pull origin main
|
|
assert_has_file repo/tmp/cache/summaries/origin
|
|
assert_has_file repo/tmp/cache/summaries/origin.sig
|
|
cmp repo/tmp/cache/summaries/origin ${test_tmpdir}/ostree-srv/gnomerepo/summary.1 >&2
|
|
cmp repo/tmp/cache/summaries/origin.sig ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig.1 >&2
|
|
|
|
# Simulate a broken summary cache to see if it can be recovered from.
|
|
# Prior to commit c4c2b5eb the client would save the summary to the
|
|
# cache before validating the signature. That would mean the cache would
|
|
# have mismatched summary and signature and ostree would remain
|
|
# deadlocked there until the remote published a new signature.
|
|
#
|
|
# First pull with OSTREE_REPO_TEST_ERROR=invalid-cache to see the
|
|
# invalid cache is detected. Then pull again to check if it can be
|
|
# recovered from.
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary.2 repo/tmp/cache/summaries/origin
|
|
if OSTREE_REPO_TEST_ERROR=invalid-cache ${OSTREE} --repo=repo pull origin main 2>err.txt; then
|
|
assert_not_reached "Should have hit OSTREE_REPO_TEST_ERROR_INVALID_CACHE"
|
|
fi
|
|
assert_file_has_content err.txt "OSTREE_REPO_TEST_ERROR_INVALID_CACHE"
|
|
assert_has_file repo/tmp/cache/summaries/origin
|
|
assert_has_file repo/tmp/cache/summaries/origin.sig
|
|
cmp repo/tmp/cache/summaries/origin ${test_tmpdir}/ostree-srv/gnomerepo/summary.2 >&2
|
|
cmp repo/tmp/cache/summaries/origin.sig ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig.1 >&2
|
|
${OSTREE} --repo=repo pull origin main
|
|
assert_has_file repo/tmp/cache/summaries/origin
|
|
assert_has_file repo/tmp/cache/summaries/origin.sig
|
|
cmp repo/tmp/cache/summaries/origin ${test_tmpdir}/ostree-srv/gnomerepo/summary.1 >&2
|
|
cmp repo/tmp/cache/summaries/origin.sig ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig.1 >&2
|
|
|
|
# Publish new signature and check that subsequent pull succeeds
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary{.2,}
|
|
cp ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig{.2,}
|
|
${OSTREE} --repo=repo pull origin main
|
|
assert_has_file repo/tmp/cache/summaries/origin
|
|
assert_has_file repo/tmp/cache/summaries/origin.sig
|
|
cmp repo/tmp/cache/summaries/origin ${test_tmpdir}/ostree-srv/gnomerepo/summary.2 >&2
|
|
cmp repo/tmp/cache/summaries/origin.sig ${test_tmpdir}/ostree-srv/gnomerepo/summary.sig.2 >&2
|
|
|
|
echo "ok pull with signed summary broken cache"
|