mirror of
https://github.com/ostreedev/ostree.git
synced 2025-01-07 21:18:55 +03:00
20047ff1fe
When pulling with depth, missing parent commits are ignored. However, the check was applying to any commit, which means that it would succeed even if the requested commit was missing. This might happen on a corrupted remote repo or when using ref data from a stale summary. To achieve this, the semantics of the `commit_to_depth` hash table is changed slightly to only ever includes parent commits. This makes it easy to detect when a parent commit is being referenced (although there is a minor bug there when multiple refs are being pulled) while keeping references to commits that need their `commitpartial` files cleaned up. It also means that the table is only populated on depth pulls, which saves some memory and processing in the common depth=0 case. Fixes: #2265
98 lines
3.7 KiB
Bash
Executable File
98 lines
3.7 KiB
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Copyright (C) 2014 Colin Walters <walters@verbum.org>
|
|
#
|
|
# SPDX-License-Identifier: LGPL-2.0+
|
|
#
|
|
# This library is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU Lesser General Public
|
|
# License as published by the Free Software Foundation; either
|
|
# version 2 of the License, or (at your option) any later version.
|
|
#
|
|
# This library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Lesser General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Lesser General Public
|
|
# License along with this library; if not, write to the
|
|
# Free Software Foundation, Inc., 59 Temple Place - Suite 330,
|
|
# Boston, MA 02111-1307, USA.
|
|
|
|
set -euo pipefail
|
|
|
|
. $(dirname $0)/libtest.sh
|
|
|
|
setup_fake_remote_repo1 "archive"
|
|
|
|
echo '1..3'
|
|
|
|
cd ${test_tmpdir}
|
|
mkdir repo
|
|
ostree_repo_init repo
|
|
${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat httpd-address)/ostree/gnomerepo
|
|
|
|
${CMD_PREFIX} ostree --repo=repo pull --depth=0 origin main
|
|
find repo/objects -name '*.commit' | wc -l > commitcount
|
|
assert_file_has_content commitcount "^1$"
|
|
find repo/state -name '*.commitpartial' | wc -l > commitpartialcount
|
|
assert_file_has_content commitpartialcount "^0$"
|
|
|
|
${CMD_PREFIX} ostree --repo=repo pull --depth=0 origin main
|
|
find repo/objects -name '*.commit' | wc -l > commitcount
|
|
assert_file_has_content commitcount "^1$"
|
|
find repo/state -name '*.commitpartial' | wc -l > commitpartialcount
|
|
assert_file_has_content commitpartialcount "^0$"
|
|
|
|
${CMD_PREFIX} ostree --repo=repo pull --depth=1 origin main
|
|
find repo/objects -name '*.commit' | wc -l > commitcount
|
|
assert_file_has_content commitcount "^2$"
|
|
find repo/state -name '*.commitpartial' | wc -l > commitpartialcount
|
|
assert_file_has_content commitpartialcount "^0$"
|
|
|
|
${CMD_PREFIX} ostree --repo=repo pull --depth=1 origin main
|
|
find repo/objects -name '*.commit' | wc -l > commitcount
|
|
assert_file_has_content commitcount "^2$"
|
|
find repo/state -name '*.commitpartial' | wc -l > commitpartialcount
|
|
assert_file_has_content commitpartialcount "^0$"
|
|
|
|
${CMD_PREFIX} ostree --repo=repo pull --depth=-1 origin main
|
|
find repo/objects -name '*.commit' | wc -l > commitcount
|
|
assert_file_has_content commitcount "^3$"
|
|
find repo/state -name '*.commitpartial' | wc -l > commitpartialcount
|
|
assert_file_has_content commitpartialcount "^0$"
|
|
|
|
echo "ok pull depth"
|
|
|
|
# Check that pulling with depth != 0 succeeds with a missing parent
|
|
# commit. Prune the remote to truncate the history.
|
|
cd ${test_tmpdir}
|
|
${CMD_PREFIX} ostree --repo=ostree-srv/gnomerepo prune --refs-only --depth=0
|
|
|
|
rm -rf repo/refs/heads/* repo/refs/remotes/* repo/objects/*/*.commit
|
|
${CMD_PREFIX} ostree --repo=repo pull --depth=1 origin main
|
|
find repo/objects -name '*.commit' | wc -l > commitcount
|
|
assert_file_has_content commitcount "^1$"
|
|
find repo/state -name '*.commitpartial' | wc -l > commitpartialcount
|
|
assert_file_has_content commitpartialcount "^0$"
|
|
|
|
rm -rf repo/refs/heads/* repo/refs/remotes/* repo/objects/*/*.commit
|
|
${CMD_PREFIX} ostree --repo=repo pull --depth=-1 origin main
|
|
find repo/objects -name '*.commit' | wc -l > commitcount
|
|
assert_file_has_content commitcount "^1$"
|
|
find repo/state -name '*.commitpartial' | wc -l > commitpartialcount
|
|
assert_file_has_content commitpartialcount "^0$"
|
|
|
|
echo "ok pull depth missing parent"
|
|
|
|
# Check that it errors if the ref head commit is missing.
|
|
cd ${test_tmpdir}
|
|
rm -f ostree-srv/gnomerepo/objects/*/*.commit
|
|
|
|
rm -rf repo/refs/heads/* repo/refs/remotes/* repo/objects/*/*.commit
|
|
if ${CMD_PREFIX} ostree --repo=repo pull --depth=-1 origin main; then
|
|
fatal "Pull with depth -1 succeeded with missing HEAD commit"
|
|
fi
|
|
|
|
echo "ok pull depth missing HEAD commit"
|